Rename metadata_parser module to chip.testing #35615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 7 of 14 files. Overall, the semantic diff is 24% smaller than the GitHub diff. 1 files do not contain logic changes.
|
github-actions
bot
added
examples
scripts
gn
tests
matter-1.4-te2-script-change
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic and
dhrishi
pullapprove
bot
requested review from
saurabhst,
selissia,
tobiasgraf,
sharadb-amazon,
vivien-apple,
tcarmelveilleux,
wiba-nordic,
tecimovic,
woody-apple,
tehampson,
tima-q,
younghak-hwang and
yufengwangca
|
PR #35615: Size comparison from add0bf1 to 1c99710 Full report (45 builds for bl602, bl702, bl702l, cyw30739, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
|
PR #35615: Size comparison from add0bf1 to 09c8f44 Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Sep 17, 2024
saurabhst
approved these changes
Sep 17, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
* Rename metadata_parser module to chip.testing * MCORE_FS_1_4: Use Subprocess from chip.testing * MCORE_FS_1_3: Use Subprocess from chip.testing * Cleanup unused arguments * Restyled by isort * Fix test case to work on CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Python package name with helper modules for CHIP python testing does not reflect its purpose. Since this package might have more modules in the future, we should use meaningful and generic name for it.
Changes
metadata_parsermodule tochip.testingSubprocessfromchip.testingin MCORE_FS_1_4 and MCORE_FS_1_3fabric-sync-app.pyTesting
Locally verified that MCORE_FS_1_4 and MCORE_FS_1_3 still works as expected.
CI will verify metadata_parser rename.