-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Telink] Lighting app build with disabled CONFIG_PWM #35621
Merged
andy31415
merged 6 commits into
project-chip:master
from
s07641069:lighting-app-build-failure-if-CONFIG_PWM=n
Sep 20, 2024
Merged
[Telink] Lighting app build with disabled CONFIG_PWM #35621
andy31415
merged 6 commits into
project-chip:master
from
s07641069:lighting-app-build-failure-if-CONFIG_PWM=n
Sep 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Dummy backend to the PWM Manager Add option to execute Lightining app with LED Manager Signed-off-by: Borys Nykytiuk <[email protected]>
Review changes with SemanticDiff. |
BorysNykytiuk
changed the title
soc: riscv: telink: Lighting app run without CONFIG_PWM
[Telink] Lighting app build with disabled CONFIG_PWM
Sep 17, 2024
s07641069
approved these changes
Sep 17, 2024
PR #35621: Size comparison from 514e810 to 20a74bf Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91 and
fessehaeve
September 17, 2024 13:00
pullapprove
bot
requested review from
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
September 17, 2024 13:00
PR #35621: Size comparison from 514e810 to 8b810fb Increases above 0.2%:
Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andriy-bilynskyy
approved these changes
Sep 19, 2024
PR #35621: Size comparison from 884d9fa to 251ed4c Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Sep 20, 2024
BorysNykytiuk
deleted the
lighting-app-build-failure-if-CONFIG_PWM=n
branch
September 23, 2024 07:51
nivi-apple
pushed a commit
to nivi-apple/connectedhomeip
that referenced
this pull request
Sep 24, 2024
) * soc: riscv: telink: Lighting app run without CONFIG_PWM Add Dummy backend to the PWM Manager Add option to execute Lightining app with LED Manager Signed-off-by: Borys Nykytiuk <[email protected]> * Restyled by whitespace * Restyled by clang-format * Override method linkLed inside lighting app * Restyled by clang-format --------- Signed-off-by: Borys Nykytiuk <[email protected]> Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Alex Tsitsiura <[email protected]>
nivi-apple
pushed a commit
to nivi-apple/connectedhomeip
that referenced
this pull request
Sep 24, 2024
) * soc: riscv: telink: Lighting app run without CONFIG_PWM Add Dummy backend to the PWM Manager Add option to execute Lightining app with LED Manager Signed-off-by: Borys Nykytiuk <[email protected]> * Restyled by whitespace * Restyled by clang-format * Override method linkLed inside lighting app * Restyled by clang-format --------- Signed-off-by: Borys Nykytiuk <[email protected]> Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Alex Tsitsiura <[email protected]>
interfer
added a commit
to s07641069/connectedhomeip
that referenced
this pull request
Sep 25, 2024
related to PWM pull: [Telink] Lighting app build with disabled CONFIG_PWM project-chip#35621
interfer
added a commit
to s07641069/connectedhomeip
that referenced
this pull request
Sep 25, 2024
related to PWM pull: [Telink] Lighting app build with disabled CONFIG_PWM project-chip#35621
interfer
added a commit
to s07641069/connectedhomeip
that referenced
this pull request
Sep 25, 2024
related to PWM pull: [Telink] Lighting app build with disabled CONFIG_PWM project-chip#35621
mergify bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
…ker version 81 (#35778) * [Telink] Added W91 v2.1 board configuration * [Telink] removed config for crypto HW acceleration alternatives options removed from config CONFIG_TELINK_B9X_MBEDTLS_HW_ACCELERATION MBEDTLS_AES_ALT MBEDTLS_ECP_ALT * [Telink] fixed status-led for Lighting app related to PWM pull: [Telink] Lighting app build with disabled CONFIG_PWM #35621 * [Telink] removed v2 definition for W91 Only left board and board_v1 * [Telink] minor review fixes * [Telink] Remove all partitions instead of one by one * [Telink] Change N22 Image offset & size * [Telink] OTA multi image in single slot * [Telink] use corect key * [Telink] Update test revision and add W91 continue-on-error * [Telink] First verision of python script for process binaries * [Telink] update readme files * [Telink] Improve process binaries script * [Telink] Use merged.bin always * [Telink] Update Zephyr rev for build test * [Telink] Fix code-lints & Spelling errors * [Telink] Update Zephyr rev for build test * [Telink] set correct order for set env * [Telink] Clean up merged.bin from previuse build * [Telink] Fix CI build * [Telink] Update Zephyr rev for build test * Restyled by autopep8 * [Telink] Add debug prints to check fill gap issue * [Telink] Fix issue with enabled Factory Data only * Restyled by autopep8 * [Telink] Update builds to docker version 81 * [Telink] disable debug part * [Telink] Update NXP to docker version 81 * merge conflict resolve issue fix --------- Co-authored-by: Alex Tsitsiura <[email protected]> Co-authored-by: Restyled.io <[email protected]>
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
) * soc: riscv: telink: Lighting app run without CONFIG_PWM Add Dummy backend to the PWM Manager Add option to execute Lightining app with LED Manager Signed-off-by: Borys Nykytiuk <[email protected]> * Restyled by whitespace * Restyled by clang-format * Override method linkLed inside lighting app * Restyled by clang-format --------- Signed-off-by: Borys Nykytiuk <[email protected]> Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Alex Tsitsiura <[email protected]>
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…ker version 81 (project-chip#35778) * [Telink] Added W91 v2.1 board configuration * [Telink] removed config for crypto HW acceleration alternatives options removed from config CONFIG_TELINK_B9X_MBEDTLS_HW_ACCELERATION MBEDTLS_AES_ALT MBEDTLS_ECP_ALT * [Telink] fixed status-led for Lighting app related to PWM pull: [Telink] Lighting app build with disabled CONFIG_PWM project-chip#35621 * [Telink] removed v2 definition for W91 Only left board and board_v1 * [Telink] minor review fixes * [Telink] Remove all partitions instead of one by one * [Telink] Change N22 Image offset & size * [Telink] OTA multi image in single slot * [Telink] use corect key * [Telink] Update test revision and add W91 continue-on-error * [Telink] First verision of python script for process binaries * [Telink] update readme files * [Telink] Improve process binaries script * [Telink] Use merged.bin always * [Telink] Update Zephyr rev for build test * [Telink] Fix code-lints & Spelling errors * [Telink] Update Zephyr rev for build test * [Telink] set correct order for set env * [Telink] Clean up merged.bin from previuse build * [Telink] Fix CI build * [Telink] Update Zephyr rev for build test * Restyled by autopep8 * [Telink] Add debug prints to check fill gap issue * [Telink] Fix issue with enabled Factory Data only * Restyled by autopep8 * [Telink] Update builds to docker version 81 * [Telink] disable debug part * [Telink] Update NXP to docker version 81 * merge conflict resolve issue fix --------- Co-authored-by: Alex Tsitsiura <[email protected]> Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change overview