Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FabricSync] Changed SDK TODO comment to spec TODO comment #35622

Merged
merged 1 commit into from
Sep 17, 2024
Merged

[FabricSync] Changed SDK TODO comment to spec TODO comment #35622

merged 1 commit into from
Sep 17, 2024

Conversation

tehampson
Copy link
Contributor

@tehampson tehampson commented Sep 17, 2024 •
edited
Loading

Chatting with Chris this is the option we decided to do for now in the example as spec is undefined for this particular situation. This is issue is expected to be addressed in Matter 1.5.

Also updated to other comments to be a little more clear on why we are doing assertChipStackLockedByCurrentThread

https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/10448

@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

PR #35622: Size comparison from 64f859b to f19041d

Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 64f859b f19041d change % change
bl602 lighting-app bl602 FLASH 1278168 1278168 0 0.0
RAM 95824 95824 0 0.0
bl602+mfd FLASH 1292278 1292278 0 0.0
RAM 95968 95968 0 0.0
bl602+rpc FLASH 1317132 1317132 0 0.0
RAM 104248 104248 0 0.0
bl702 lighting-app bl702 FLASH 943874 943874 0 0.0
RAM 15145 15145 0 0.0
bl702+mfd FLASH 946274 946274 0 0.0
RAM 15305 15305 0 0.0
bl702+rpc FLASH 1039194 1039194 0 0.0
RAM 24173 24173 0 0.0
bl706-eth FLASH 646070 646070 0 0.0
RAM 25233 25233 0 0.0
bl706-wifi FLASH 894082 894082 0 0.0
RAM 14477 14477 0 0.0
bl702l lighting-app bl702l FLASH 960534 960534 0 0.0
RAM 16804 16804 0 0.0
bl702l+mfd FLASH 963156 963156 0 0.0
RAM 16964 16964 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 677261 677261 0 0.0
RAM 78492 78492 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 697113 697113 0 0.0
RAM 81124 81124 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 697113 697113 0 0.0
RAM 81124 81124 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 654041 654041 0 0.0
RAM 73560 73560 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 613453 613453 0 0.0
RAM 71452 71452 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 633081 633081 0 0.0
RAM 74004 74004 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 633081 633081 0 0.0
RAM 74004 74004 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 632573 632573 0 0.0
RAM 74500 74500 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 652289 652289 0 0.0
RAM 77052 77052 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 652289 652289 0 0.0
RAM 77052 77052 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 607989 607989 0 0.0
RAM 68588 68588 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 627841 627841 0 0.0
RAM 71220 71220 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 627841 627841 0 0.0
RAM 71220 71220 0 0.0
efr32 lighting-app BRD4187C FLASH 932468 932468 0 0.0
RAM 135056 135056 0 0.0
lock-app BRD2605a FLASH 739960 739952 -8 -0.0
RAM 231212 231212 0 0.0
BRD4338a FLASH 740608 740600 -8 -0.0
RAM 231244 231244 0 0.0
window-app BRD4187C FLASH 1015544 1015536 -8 -0.0
RAM 126996 126996 0 0.0
esp32 all-clusters-app c3devkit DRAM 94152 94152 0 0.0
FLASH 1539526 1539526 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115096 115096 0 0.0
FLASH 1549846 1549846 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2771233 2771233 0 0.0
RAM 128944 128944 0 0.0
all-clusters-app debug unknown 5456 5456 0 0.0
FLASH 6082726 6082726 0 0.0
RAM 514288 514288 0 0.0
all-clusters-minimal-app debug unknown 5352 5352 0 0.0
FLASH 5406782 5406782 0 0.0
RAM 240640 240640 0 0.0
bridge-app debug unknown 5336 5336 0 0.0
FLASH 4740294 4740294 0 0.0
RAM 217840 217840 0 0.0
chip-tool debug unknown 5888 5888 0 0.0
FLASH 1267635 1267635 0 0.0
RAM 562282 562282 0 0.0
chip-tool-ipv6only arm64 unknown 20384 20384 0 0.0
FLASH 11341604 11341604 0 0.0
RAM 612384 612384 0 0.0
fabric-admin debug unknown 5720 5720 0 0.0
FLASH 10979239 10979239 0 0.0
RAM 561322 561322 0 0.0
fabric-bridge-app debug unknown 4568 4568 0 0.0
FLASH 4563032 4563032 0 0.0
RAM 204456 204456 0 0.0
lighting-app debug+rpc+ui unknown 5984 5984 0 0.0
FLASH 5676609 5676609 0 0.0
RAM 228128 228128 0 0.0
lock-app debug unknown 5272 5272 0 0.0
FLASH 4789574 4789574 0 0.0
RAM 203928 203928 0 0.0
ota-provider-app debug unknown 4648 4648 0 0.0
FLASH 4422762 4422762 0 0.0
RAM 197632 197632 0 0.0
ota-requestor-app debug unknown 4584 4584 0 0.0
FLASH 4561508 4561508 0 0.0
RAM 202200 202200 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3107901 3107901 0 0.0
RAM 159448 159448 0 0.0
thermostat-no-ble arm64 unknown 9336 9336 0 0.0
FLASH 4333260 4333260 0 0.0
RAM 242256 242256 0 0.0
tv-app debug unknown 5552 5552 0 0.0
FLASH 6022261 6022261 0 0.0
RAM 587088 587088 0 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 10883805 10883805 0 0.0
RAM 650256 650256 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 915124 915124 0 0.0
RAM 142259 142259 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 886440 886440 0 0.0
RAM 140398 140398 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 846468 846468 0 0.0
RAM 141077 141077 0 0.0
nxp contact k32w0+release FLASH 580520 580520 0 0.0
RAM 70720 70720 0 0.0
k32w1+release FLASH 593344 593344 0 0.0
RAM 62896 62896 0 0.0
mcxw71+release FLASH 593096 593096 0 0.0
RAM 62896 62896 0 0.0
light k32w0+release FLASH 616316 616316 0 0.0
RAM 70184 70184 0 0.0
k32w1+release FLASH 679584 679584 0 0.0
RAM 48512 48512 0 0.0
mcxw71+release FLASH 679600 679600 0 0.0
RAM 48512 48512 0 0.0
lock k32w1+release FLASH 701896 701896 0 0.0
RAM 67036 67036 0 0.0
mcxw71+release FLASH 701904 701904 0 0.0
RAM 67036 67036 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646916 1646916 0 0.0
RAM 210952 210952 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1550556 1550556 0 0.0
RAM 207664 207664 0 0.0
light cy8ckit_062s2_43012 FLASH 1466468 1466468 0 0.0
RAM 200672 200672 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462988 1462988 0 0.0
RAM 225024 225024 0 0.0
qpg lighting-app qpg6105+debug FLASH 659096 659096 0 0.0
RAM 105212 105212 0 0.0
lock-app qpg6105+debug FLASH 616988 616988 0 0.0
RAM 99688 99688 0 0.0
stm32 light STM32WB5MM-DK FLASH 480568 480568 0 0.0
RAM 144668 144668 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 621708 621708 0 0.0
RAM 50964 50964 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 688210 688210 0 0.0
RAM 148388 148388 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 779892 779892 0 0.0
RAM 110756 110756 0 0.0
bridge-app tlsr9258a FLASH 680728 680728 0 0.0
RAM 91620 91620 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621472 621472 0 0.0
RAM 50916 50916 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 707404 707404 0 0.0
RAM 74256 74256 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 624626 624626 0 0.0
RAM 144292 144292 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 810034 810034 0 0.0
RAM 99424 99424 0 0.0
lock-app-dfu tlsr9528a FLASH 655224 655224 0 0.0
RAM 66976 66976 0 0.0
ota-requestor-app tlsr9258a FLASH 696704 696704 0 0.0
RAM 91212 91212 0 0.0
pump-app-usb tlsr9518adk80d FLASH 633060 633060 0 0.0
RAM 55792 55792 0 0.0
pump-controller-app tlsr9518adk80d FLASH 610250 610250 0 0.0
RAM 53036 53036 0 0.0
shell tlsr9518adk80d FLASH 467176 467176 0 0.0
RAM 68668 68668 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 628436 628436 0 0.0
RAM 52636 52636 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 652386 652386 0 0.0
RAM 56584 56584 0 0.0
thermostat tlsr9518adk80d FLASH 636980 636980 0 0.0
RAM 53428 53428 0 0.0
window-covering tlsr9118bdk40d FLASH 523156 523156 0 0.0
RAM 97268 97268 0 0.0
tizen all-clusters-app arm unknown 4852 4852 0 0.0
FLASH 1724840 1724840 0 0.0
RAM 89524 89524 0 0.0
chip-tool-ubsan arm unknown 10284 10284 0 0.0
FLASH 17532050 17532050 0 0.0
RAM 7609748 7609748 0 0.0

@tehampson tehampson enabled auto-merge (squash) September 17, 2024 18:16
@tehampson tehampson merged commit 2106492 into project-chip:master Sep 17, 2024
69 checks passed
yyzhong-g pushed a commit to yyzhong-g/connectedhomeip that referenced this pull request Dec 12, 2024
@tehampson @yyzhong-g
[FabricSync] Changed SDK TODO comment to spec TODO comment (project-c…
4b2363b 
…hip#35622)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@axelnxp axelnxp Awaiting requested review from axelnxp

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chapongatien chapongatien Awaiting requested review from chapongatien

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@doru91 doru91 Awaiting requested review from doru91

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@ReneJosefsen ReneJosefsen Awaiting requested review from ReneJosefsen

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@andy31415 andy31415 Awaiting requested review from andy31415

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tima-q tima-q Awaiting requested review from tima-q

@arkq arkq Awaiting requested review from arkq

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tehampson @andy31415 @arkq