[Test] Creating TC_CADMIN_1_22 and TC_CADMIN_1_24 python test modules #35632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
j-ororke
commented
Sep 17, 2024
•
j-ororke
commented
- Created CADMIN_1_22 python test module following steps in PR here: TC_CADMIN_1_22
- Created CADMIN_1_24 python test module following steps in PR here: TC_CADMIN_1_24
- Removed following yaml test modules:
-
- Test_TC_CADMIN_1_21.yaml, Test_TC_CADMIN_1_22.yaml, Test_TC_CADMIN_1_23.yaml, Test_TC_CADMIN_1_24.yaml
- Created CADMIN_1_22 python test module following steps in PR here: - Created CADMIN_1_24 python test module following steps in PR here: - Removed following yaml test modules: -- Test_TC_CADMIN_1_21.yaml, Test_TC_CADMIN_1_22.yaml, Test_TC_CADMIN_1_23.yaml, Test_TC_CADMIN_1_24.yaml
|
Review changes with Changed Files
|
github-actions
bot
added
app
tests
matter-1.4-te2-script-change
|
PR #35632: Size comparison from 31894f6 to e244d98 Full report (11 builds for nxp, qpg, stm32, tizen)
|
- Resolved linting issues
|
PR #35632: Size comparison from 31894f6 to c8a2509 Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex and
harsha-rajendran
|
PR #35632: Size comparison from 1f4e81e to 9259c24 Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
- Resolved issues with CI args in TC_CADMIN_1_22_24 test module - Removed yaml calls for 1_21, 1_22, 1_23, and 1_24, also removed yaml call for 1_9 from manualTests.json
|
PR #35632: Size comparison from 1f4e81e to fd13214 Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cecille
removed
the
matter-1.4-te2-script-change
cecille
approved these changes
Oct 29, 2024
tehampson
reviewed
Oct 29, 2024
tehampson
reviewed
Oct 29, 2024
tehampson
reviewed
Oct 29, 2024
- Resolving comments from tehampson as these were needed changes to be made -- Substituted to using cleaner code for assert.asserts_equal instead of just assert.failure -- Resolving copy paste error in TC_CADMIN_1_4 test -- Made comments cleaner by rewording to include what the error code was referring too
github-actions
bot
added
the
matter-1.4-te2-script-change
- Changing method for test step 3 on TC_CADMIN_1_24 test now using timeout for 30 seconds instead of revoke commissioning
tehampson
reviewed
Nov 4, 2024
tehampson
reviewed
Nov 4, 2024
tehampson
reviewed
Nov 4, 2024
tehampson
reviewed
Nov 4, 2024
- Unnesting asserts from if statements
- Adding this suggested change from Terrence into the code, as it does make the code much cleaner Co-authored-by: Terence Hampson <[email protected]>
-Updating to changing static value to being stored in variable for easier readability as Terrence has suggested, making the code easier to read.
- Removed unneccessary await from asserts
|
@j-ororke Just an FYI please feel free to mark comments where you believe you 100% addressed them as resolved. If there is some sort of discussion those you can keep open to see if the reviewer is happy, but otherwise I think it is perfectly reasonable to mark comments that are completed by you as resolved. |
tehampson
approved these changes
Nov 19, 2024
raju-apple
approved these changes
Nov 20, 2024
andy31415
reviewed
Nov 27, 2024
| nodeid=self.dut_node_id, timeout=180, iteration=10000, discriminator=self.discriminator, option=1) | ||
|
|
||
| self.step(3) | ||
| sleep(180) |
There was a problem hiding this comment.
yaml used to wait for 181 seconds instead of 180 for some reason.
Also this is absolutely terrible for CI. Could we make CI sleep less? Or maybe have an interface to skip slow in PR CI the same like we have for YAML: https://github.com/project-chip/connectedhomeip/blob/master/scripts/tests/chiptest/__init__.py#L98
There was a problem hiding this comment.
I apologize for this test having caused some issues in the CI currently due to the sleep time.
I will file a PR here soon to remove this test from running in the CI moving forward, sounds like this test is not needed to be run in the CI.
There was a problem hiding this comment.
Hi @andy31415,
I noticed that there is some new code in src/python_testing/test_metadata.yaml in the master branch.
In the slow_tests section of that yaml file there appears to be CADMIN_1_9, CADMIN_1_19, and CADMIN_1_22_24 tests with duration of test runs added currently.
Does this resolve the issue with the CI and the test from this above PR? Can this comment be resolved?
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…project-chip#35632) * [Test] Creating TC_CADMIN_1_22 and TC_CADMIN_1_24: - Created CADMIN_1_22 python test module following steps in PR here: - Created CADMIN_1_24 python test module following steps in PR here: - Removed following yaml test modules: -- Test_TC_CADMIN_1_21.yaml, Test_TC_CADMIN_1_22.yaml, Test_TC_CADMIN_1_23.yaml, Test_TC_CADMIN_1_24.yaml * Restyled by autopep8 * Updating TC_CADMIN_1_22 and TC_CADMIN_1_24: - Resolved linting issues * Created TC_CADMIN_1_22_24 test module: - Merged TC_CADMIN_1_24 and TC_CADMIN_1_22 standalone test modules into a single test module - Found enum for window closed value and replaced it in the tests - Removed generate_unique_value and AttemptCommission functions - Updated CI arguments format to YAML'esque format * Restyled by autopep8 * Updated TC_CADMIN_1_22_24: - Renamed class to TC_CADMIN_1_22_24 * Updating TC_CADMIN_1_22_24: - Resolving lint errors * Update TC_CADMIN_1_22_24.py Updated to include dependency location change for matter_testing support module * Updated TC_CADMIN_1_22_24.py: - Resolved issues with CI args in TC_CADMIN_1_22_24 test module - Removed yaml calls for 1_21, 1_22, 1_23, and 1_24, also removed yaml call for 1_9 from manualTests.json * Updating TC_CADMIN_1_22_24 test module: - Resolving comments from tehampson as these were needed changes to be made -- Substituted to using cleaner code for assert.asserts_equal instead of just assert.failure -- Resolving copy paste error in TC_CADMIN_1_4 test -- Made comments cleaner by rewording to include what the error code was referring too * Update TC_CADMIN_1_22_24 test module: - Changing method for test step 3 on TC_CADMIN_1_24 test now using timeout for 30 seconds instead of revoke commissioning * Restyled by autopep8 * Update TC_CADMIN_1_22_24.py - Unnesting asserts from if statements * Update src/python_testing/TC_CADMIN_1_22_24.py - Adding this suggested change from Terrence into the code, as it does make the code much cleaner Co-authored-by: Terence Hampson <[email protected]> * Update TC_CADMIN_1_22_24.py -Updating to changing static value to being stored in variable for easier readability as Terrence has suggested, making the code easier to read. * Restyled by autopep8 * Updated TC_CADMIN_1_22_24 test module: - Removed unneccessary await from asserts * Restyled by autopep8 --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Terence Hampson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.