Update pigweed to the latest version #35644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 4 of 43 files. Overall, the semantic diff is 8% smaller than the GitHub diff. File Information
|
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no and
kpschoedel
|
PR #35644: Size comparison from 12f04dc to 2c71e0b Full report (93 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35644: Size comparison from 3166e3a to ef2c36f Full report (32 builds for cyw30739, linux, nxp, psoc6, qpg, stm32, tizen)
|
jmartinez-silabs
approved these changes
Sep 20, 2024
@jmartinez-silabs it is ok in CI because CI on the silabs image does not have a PW_ENVIRONMENT_ROOT set. it would be required for people testing in the vscode (or any custom local environment that uses it). |
|
PR #35644: Size comparison from 3166e3a to 1fafe89 Full report (93 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35644: Size comparison from 3166e3a to 6e00260 Full report (9 builds for nxp, stm32, tizen)
|
|
PR #35644: Size comparison from 3166e3a to 41e3165 Full report (13 builds for nxp, qpg, stm32, tizen)
|
|
PR #35644: Size comparison from 3166e3a to 1d2bfe9 Full report (93 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cecille
approved these changes
Sep 20, 2024
|
Q: it looks like there's a fair number of formatting changes. They look reasonably/ better, but is that going to mess stuff up for folks when they build products with zap files that aren't in the SDK? |
The reason for them is that we use clang-format from pigweed when formatting stuff with zap-regen (logic here was to have a clang-format that works on both linux and darwin the same ... and pigweed one is a fixed version). I don't think others will be affected: this is strictly SDK generated files and all the rest of the files are restyle.io or not at all (whatever others are using) |
nivi-apple
pushed a commit
to nivi-apple/connectedhomeip
that referenced
this pull request
Sep 24, 2024
* Pull latest pigweed * Make pigweed pull python 3.11 on macs, to have a consistent build environment * Restyle * Remove unused import * Update signature of WriteLine - this was updated in pigwed to use std::string_view pass by value * Workaround for slc errors for efr32 * Disable openssl warning of invalid function cast. This is already covered in connect.c via OPENSSL_MSVC_PRAGMA and is intentional * ZAP regen because we change clang-format version * SystemConfig includes ICDServerBuildConfig.h. Add the dependency as a formal dependency * Fix typo in WriteLine parameter * Restyle * Fix the typo .. again, I had deleted the wrong thing * Look to fix openiot sdk build * Restyle * Fix clang-tidy: it became stricter on unused arguments * Fix tidy run for real this time ... at least one file passes locally * Different fix for clang-tidy, seems more targeted * More updates: -S is also a flag that clang tidy would not like according to https://github.com/llvm/llvm-project/pull/101103/files * Fix typo * Disable two more diagnostics that seem to show up in clang-tidy * Need comma for - updated config * Fix some clang-tidy findings * More clang-tidy fixes * Generate script update: make sure metadata is generated * more tidy and dependency fixes * more clang tidy make happy updates * Restyle * Fix too many args error * Clean up an odd dependency * Signature update for android test functions * Fix type cast for android callback on type * Fix the order of checks in TCP endpoint implementations to be what tests expect ... ugly that we verify input args first * Fix invalid verify * Fix typo * Additional socket checks for socket inet implementations * Self-review update * Undo merge error * Undo pigweed repo loss * One more extra check to make clang-tidy happy * One more extra check to make clang-tidy happy * Switch to nolint * Avoid large code deltas * Restyle * Restyled by clang-format * Undo changes to build of attestation_verifier: it seems not needed * Fix for clang-tidy requiring updated template keywords * Fix the template argument ... there is a 2nd invoke type * Another fix --------- Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Restyled.io <[email protected]>
nivi-apple
pushed a commit
to nivi-apple/connectedhomeip
that referenced
this pull request
Sep 24, 2024
* Pull latest pigweed * Make pigweed pull python 3.11 on macs, to have a consistent build environment * Restyle * Remove unused import * Update signature of WriteLine - this was updated in pigwed to use std::string_view pass by value * Workaround for slc errors for efr32 * Disable openssl warning of invalid function cast. This is already covered in connect.c via OPENSSL_MSVC_PRAGMA and is intentional * ZAP regen because we change clang-format version * SystemConfig includes ICDServerBuildConfig.h. Add the dependency as a formal dependency * Fix typo in WriteLine parameter * Restyle * Fix the typo .. again, I had deleted the wrong thing * Look to fix openiot sdk build * Restyle * Fix clang-tidy: it became stricter on unused arguments * Fix tidy run for real this time ... at least one file passes locally * Different fix for clang-tidy, seems more targeted * More updates: -S is also a flag that clang tidy would not like according to https://github.com/llvm/llvm-project/pull/101103/files * Fix typo * Disable two more diagnostics that seem to show up in clang-tidy * Need comma for - updated config * Fix some clang-tidy findings * More clang-tidy fixes * Generate script update: make sure metadata is generated * more tidy and dependency fixes * more clang tidy make happy updates * Restyle * Fix too many args error * Clean up an odd dependency * Signature update for android test functions * Fix type cast for android callback on type * Fix the order of checks in TCP endpoint implementations to be what tests expect ... ugly that we verify input args first * Fix invalid verify * Fix typo * Additional socket checks for socket inet implementations * Self-review update * Undo merge error * Undo pigweed repo loss * One more extra check to make clang-tidy happy * One more extra check to make clang-tidy happy * Switch to nolint * Avoid large code deltas * Restyle * Restyled by clang-format * Undo changes to build of attestation_verifier: it seems not needed * Fix for clang-tidy requiring updated template keywords * Fix the template argument ... there is a 2nd invoke type * Another fix --------- Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Restyled.io <[email protected]>
DavidKorczynski
pushed a commit
to google/oss-fuzz
that referenced
this pull request
Sep 25, 2024
- OSS-Fuzz builds are failing after pigweed was rebased in project-chip/connectedhomeip#35644 - One of the failures is related to pigweed becoming incompatible with python <3.9. Such as using subscript notation in the type hints. - Fix: Base images in OSS-Fuzz use python 3.8, This PR aims to force the usage of python3.10 instead ### Example Error ``` Step #1: Traceback (most recent call last): Step #1: File "../../third_party/pigweed/repo/pw_build/py/pw_build/python_runner.py", line 38, in <module> Step #1: import gn_resolver # type: ignore Step #1: File "/src/connectedhomeip/third_party/pigweed/repo/pw_build/py/pw_build/gn_resolver.py", line 319, in <module> Step #1: _Actions = Iterator[tuple[_ArgAction, str]] Step #1: TypeError: 'type' object is not subscriptable Step #1: [137/1234] ln -f ../../third_party/pigweed/repo/pw_thread/pw_thread_protos/thread_snapshot_service.proto ```
This was referenced Sep 27, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
* Pull latest pigweed * Make pigweed pull python 3.11 on macs, to have a consistent build environment * Restyle * Remove unused import * Update signature of WriteLine - this was updated in pigwed to use std::string_view pass by value * Workaround for slc errors for efr32 * Disable openssl warning of invalid function cast. This is already covered in connect.c via OPENSSL_MSVC_PRAGMA and is intentional * ZAP regen because we change clang-format version * SystemConfig includes ICDServerBuildConfig.h. Add the dependency as a formal dependency * Fix typo in WriteLine parameter * Restyle * Fix the typo .. again, I had deleted the wrong thing * Look to fix openiot sdk build * Restyle * Fix clang-tidy: it became stricter on unused arguments * Fix tidy run for real this time ... at least one file passes locally * Different fix for clang-tidy, seems more targeted * More updates: -S is also a flag that clang tidy would not like according to https://github.com/llvm/llvm-project/pull/101103/files * Fix typo * Disable two more diagnostics that seem to show up in clang-tidy * Need comma for - updated config * Fix some clang-tidy findings * More clang-tidy fixes * Generate script update: make sure metadata is generated * more tidy and dependency fixes * more clang tidy make happy updates * Restyle * Fix too many args error * Clean up an odd dependency * Signature update for android test functions * Fix type cast for android callback on type * Fix the order of checks in TCP endpoint implementations to be what tests expect ... ugly that we verify input args first * Fix invalid verify * Fix typo * Additional socket checks for socket inet implementations * Self-review update * Undo merge error * Undo pigweed repo loss * One more extra check to make clang-tidy happy * One more extra check to make clang-tidy happy * Switch to nolint * Avoid large code deltas * Restyle * Restyled by clang-format * Undo changes to build of attestation_verifier: it seems not needed * Fix for clang-tidy requiring updated template keywords * Fix the template argument ... there is a 2nd invoke type * Another fix --------- Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have not updated pigweed for about 6 months due to the dropped support of python 3.9 (and ubuntu 20.04 only had that one).
Changes
const std::string_view&to juststd::string_view/usr/binto PATH makes it use the right python and I do not fail with ajinja2 ModuleNotFounderrorconnect.con a cast of functions. Unsure why this fails only now, assuming clang is more strict, however that cast seems to be on purpose and borigssl explicitly tries to disable that warning but for MSVC only. I added the disable in the build.gn for boringssl itself.-c(and [Tooling] -fsyntax-only adjuster: remove -c and -S llvm/llvm-project#101103 says that-Sis also in the same category). Added code in our clang-tidy runner to auto-skip -c and -S arguments..template MemberCall(...calls. Updated tv code to do this.ConnnectiontoConnection(found while fixing java call signatures)