Update pigweed to the latest version#35644
Merged
mergify[bot] merged 56 commits intoproject-chip:masterfrom Sep 20, 2024
Merged
Update pigweed to the latest version#35644mergify[bot] merged 56 commits intoproject-chip:masterfrom
mergify[bot] merged 56 commits intoproject-chip:masterfrom
Conversation
|
Review changes with SemanticDiff. Analyzed 4 of 43 files. Overall, the semantic diff is 8% smaller than the GitHub diff. File Information
|
pullapprove
Bot
requested review from
Damian-Nordic,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no and
kpschoedel
|
PR #35644: Size comparison from 12f04dc to 2a201e0 Full report (93 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35644: Size comparison from 12f04dc to 2c71e0b Full report (93 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35644: Size comparison from 3166e3a to ef2c36f Full report (32 builds for cyw30739, linux, nxp, psoc6, qpg, stm32, tizen)
|
jmartinez-silabs
approved these changes
Sep 20, 2024
Member
jmartinez-silabs
left a comment
jmartinez-silabs
left a comment
There was a problem hiding this comment.
Adding a check for the PW_ENVIRONMENT_ROOT variable gn_silabs_example.sh was not needed in the end?
Contributor
Author
@jmartinez-silabs it is ok in CI because CI on the silabs image does not have a PW_ENVIRONMENT_ROOT set. it would be required for people testing in the vscode (or any custom local environment that uses it). |
|
PR #35644: Size comparison from 3166e3a to 1fafe89 Full report (93 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35644: Size comparison from 3166e3a to 6e00260 Full report (9 builds for nxp, stm32, tizen)
|
|
PR #35644: Size comparison from 3166e3a to 41e3165 Full report (13 builds for nxp, qpg, stm32, tizen)
|
|
PR #35644: Size comparison from 3166e3a to 1d2bfe9 Full report (93 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cecille
approved these changes
Sep 20, 2024
Contributor
|
Q: it looks like there's a fair number of formatting changes. They look reasonably/ better, but is that going to mess stuff up for folks when they build products with zap files that aren't in the SDK? |
Contributor
Author
The reason for them is that we use clang-format from pigweed when formatting stuff with zap-regen (logic here was to have a clang-format that works on both linux and darwin the same ... and pigweed one is a fixed version). I don't think others will be affected: this is strictly SDK generated files and all the rest of the files are restyle.io or not at all (whatever others are using) |
This was referenced Sep 24, 2024
This was referenced Sep 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have not updated pigweed for about 6 months due to the dropped support of python 3.9 (and ubuntu 20.04 only had that one).
Changes
const std::string_view&to juststd::string_view/usr/binto PATH makes it use the right python and I do not fail with ajinja2 ModuleNotFounderrorconnect.con a cast of functions. Unsure why this fails only now, assuming clang is more strict, however that cast seems to be on purpose and borigssl explicitly tries to disable that warning but for MSVC only. I added the disable in the build.gn for boringssl itself.-c(and [Tooling] -fsyntax-only adjuster: remove -c and -S llvm/llvm-project#101103 says that-Sis also in the same category). Added code in our clang-tidy runner to auto-skip -c and -S arguments..template MemberCall(...calls. Updated tv code to do this.ConnnectiontoConnection(found while fixing java call signatures)