Clean up the "subclasses must implement this" machinery in MTRDevice. #35657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a lot of copy/paste that we can factor out.
|
Review changes with SemanticDiff. |
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kiel-apple
pullapprove
bot
requested review from
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
jtung-apple
approved these changes
Sep 18, 2024
|
PR #35657: Size comparison from 2396bb4 to 2d7ea48 Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Sep 18, 2024
kiel-apple
reviewed
Sep 18, 2024
kiel-apple
reviewed
Sep 18, 2024
kiel-apple
reviewed
Sep 18, 2024
|
PR #35657: Size comparison from 2396bb4 to 106bcce Increases above 0.2%:
Full report (33 builds for cyw30739, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
bzbarsky-apple
force-pushed
the
simpler-subclass-impl
branch
from
106bcce to
4780268
Compare
ksperling-apple
approved these changes
Sep 19, 2024
bzbarsky-apple
force-pushed
the
simpler-subclass-impl
branch
from
4780268 to
eb4db0f
Compare
|
PR #35657: Size comparison from 70cfc89 to eb4db0f Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…project-chip#35657) * Clean up the "subclasses must implement this" machinery in MTRDevice. We had a lot of copy/paste that we can factor out. * Address review comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a lot of copy/paste that we can factor out.