-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates comments for the excluded python test scripts based on their current status in the CI pipeline #35660
Merged
mergify
merged 5 commits into
project-chip:master
from
vatsalghelani-csa:fixCommentingForExcludedPythonTestsViaGlobRun
Sep 19, 2024
Merged
Updates comments for the excluded python test scripts based on their current status in the CI pipeline #35660
mergify
merged 5 commits into
project-chip:master
from
vatsalghelani-csa:fixCommentingForExcludedPythonTestsViaGlobRun
Sep 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review changes with SemanticDiff. Analyzed 1 of 1 files. Overall, the semantic diff is 51% smaller than the GitHub diff.
|
github-actions
bot
added
tests
matter-1.4-te2-script-change
Script changes before end of Matter 1.4 TE2
labels
Sep 18, 2024
andy31415
reviewed
Sep 18, 2024
andy31415
approved these changes
Sep 18, 2024
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs and
jmeg-sfy
September 18, 2024 19:18
pullapprove
bot
requested review from
nivi-apple,
p0fi,
plauric,
rcasallas-silabs,
ReneJosefsen,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple and
younghak-hwang
September 18, 2024 19:18
PR #35660: Size comparison from 0b8ffb7 to d33abd5 Full report (16 builds for nrfconnect, nxp, qpg, stm32, tizen)
|
PR #35660: Size comparison from 0b8ffb7 to df535c2 Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
arkq
approved these changes
Sep 19, 2024
PR #35660: Size comparison from 0b8ffb7 to 20dc8ee Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
vatsalghelani-csa
deleted the
fixCommentingForExcludedPythonTestsViaGlobRun
branch
September 19, 2024 16:07
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Sep 20, 2024
…current status in the CI pipeline (project-chip#35660) * Script updated with comments on why the scripts have been included from the glob run * Restyled by autopep8 * Removed exclusion test script explanation * Fixed comments on the test scripts * Fix excluded scripts for adding support scripts still in the directory --------- Co-authored-by: Restyled.io <[email protected]>
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…current status in the CI pipeline (project-chip#35660) * Script updated with comments on why the scripts have been included from the glob run * Restyled by autopep8 * Removed exclusion test script explanation * Fixed comments on the test scripts * Fix excluded scripts for adding support scripts still in the directory --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work for Issue #31317
Follow up to PR #35539
PR 18 - This PR updates individual comments for the excluded python test scripts from glob run script based on their current status in the CI pipeline or project dependencies. The excluded tests include those tests that are not actively executed in CI, depend on unavailable example applications, or are shared utility code for other test cases.