[Energy Management] Silabs Dishwasher, Electrical sensor and DEM app #35948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 2 of 46 files. File Information
|
lpbeliveau-silabs
force-pushed
the
feature/silabs_dishwasher_app
branch
from
955e7ba to
7c9fdec
Compare
lpbeliveau-silabs
force-pushed
the
feature/silabs_dishwasher_app
branch
from
7c9fdec to
7b54229
Compare
|
PR #35948: Size comparison from 1c2ad2e to 7b54229 Full report (22 builds for cc13x4_26x4, cc32xx, nrfconnect, nxp, qpg, stm32, tizen)
|
lpbeliveau-silabs
requested review from
jamesharrow and
PeterC1965
and removed request for
a team and
jamesharrow
Somewhat acceptable state, build & runs, got to try the tests
lpbeliveau-silabs
force-pushed
the
feature/silabs_dishwasher_app
branch
from
7b54229 to
2cdbd2e
Compare
|
PR #35948: Size comparison from 4ec1716 to 2cdbd2e Full report (51 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
|
PR #35948: Size comparison from 4ec1716 to b63e1c9 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jamesharrow
reviewed
Oct 7, 2024
There was a problem hiding this comment.
I have a PR which is in flight doing some similar things:
#35616
It would be nice to see if we can add a PowerForecast for the dishwasher / washing machine into DEM which shows the estimated duration of each slot etc., but think that is a separate PR to work on.
examples/dishwasher-app/silabs/include/ElectricalEnergyMeasurementInstance.h
Show resolved
Hide resolved
jamesharrow
reviewed
Oct 7, 2024
examples/dishwasher-app/silabs/src/ElectricalEnergyMeasurementInstance.cpp
Outdated
Show resolved
Hide resolved
jmartinez-silabs
approved these changes
Oct 7, 2024
bzbarsky-apple
approved these changes
Oct 7, 2024
marius-alex-tache
pushed a commit
to NXP/matter
that referenced
this pull request
Nov 14, 2024
…or and DEM app (project-chip#35948) * Adding a Silabs dishwasher app, supports Electrical sensor and DEM Somewhat acceptable state, build & runs, got to try the tests * Removed the lock on Device Energy Management Mode * Applied suggestions related to Electrical Sensor (cherry picked from commit 8dc3d39)
marius-alex-tache
pushed a commit
to NXP/matter
that referenced
this pull request
Nov 14, 2024
…cal sensor and DEM app (project-chip#35948)" This reverts commit ddcca63. Signed-off-by: Gatien Chapon <[email protected]>
TE-N-ElvenWang
pushed a commit
to NXP/matter
that referenced
this pull request
Dec 6, 2024
…roject-chip#35948) * Adding a Silabs dishwasher app, supports Electrical sensor and DEM Somewhat acceptable state, build & runs, got to try the tests * Removed the lock on Device Energy Management Mode * Applied suggestions related to Electrical Sensor Change-Id: I0b4acdfa506967a5b08e9f0e9132814b915d120e Reviewed-on: http://androidsource.nxp.com/project/26507 Reviewed-by: Elven Wang <[email protected]>
GabrielCouturier
pushed a commit
to NXP/matter
that referenced
this pull request
Dec 11, 2024
…or and DEM app (project-chip#35948) * Adding a Silabs dishwasher app, supports Electrical sensor and DEM Somewhat acceptable state, build & runs, got to try the tests * Removed the lock on Device Energy Management Mode * Applied suggestions related to Electrical Sensor (cherry picked from commit 8dc3d39)
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…roject-chip#35948) * Adding a Silabs dishwasher app, supports Electrical sensor and DEM Somewhat acceptable state, build & runs, got to try the tests * Removed the lock on Device Energy Management Mode * Applied suggestions related to Electrical Sensor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a Silabs dishwasher app, supports Electrical sensor and DEM.
Relies on energy-management-app's common device-energy-management and energy-reporting files.
Slightly modified energy-management-app's DEM test event trigger and fake readings to allow them to be used by apps that are not EVSE.
Also modified energy-management-app's energy-management-mode to stop enforcing endpoint 1, and added a shutdown callback.
Can be used as POC to implement Energy management apps on top of existing device example apps.
In the long run, I suggest we ad a BUILD.gn file for device-energy-management and energy-reporting so we can just include those files as dependencies of projects that want to re-use them.