[darwin-framework-tool] Add a command to initialize a MTRDevice such … #36287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the the initial subscription is setted up without having to issue an additional command (e.g read or write)
|
Review changes with |
|
PR #36287: Size comparison from 4ed1e88 to f7975a6 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
approved these changes
Oct 30, 2024
| { | ||
| AddArgument("node-id", 0, UINT64_MAX, &mNodeId, "The Node ID of the device instance to create."); | ||
| AddArgument("pretend-thread-enabled", 0, 1, &mPretendThreadEnabled, | ||
| "When the device is configured using an MTRDevice (via -use-mtr-device), instructs the MTRDevice to treat the " |
There was a problem hiding this comment.
I don't get this comment. This command always sets up an MTRDevice... What device is "configured" with "-use-mtr-device" for purposes of this command? (And shouldn't it be --use-mtr-device anyway?)
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…the the initial subscription is setted up without having to issue an additional command (e.g read or write) (project-chip#36287)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…the the initial subscription is setted up without having to issue an additional command (e.g read or write)
Problem
This PR adds a command to
darwin-framework-toolthat enables the initial subscription fromMTRDeviceto be set up without requiring an additional command (likeread-by-idorwrite-by-idfor now).Additionally, it introduces extra configuration options for the device delegate and supports having a separate device delegate per device instance (rather than a single shared delegate).