Skip to content

[NXP][platform][common] Updates to support CHIP configuration using generated macros#36322

Merged
mergify[bot] merged 2 commits intoproject-chip:masterfrom
NXP:nxp_upstream_chip_config
Nov 7, 2024
Merged

[NXP][platform][common] Updates to support CHIP configuration using generated macros#36322
mergify[bot] merged 2 commits intoproject-chip:masterfrom
NXP:nxp_upstream_chip_config

Conversation

@dinabenamar
Copy link
Copy Markdown
Contributor

This PR presents some updates in the NXP CHIP config header files to support configuration with generated macros.
Files modified :

  • src/platform/nxp/common/CHIPDeviceNXPPlatformDefaultConfig.h
  • src/platform/nxp/common/CHIPNXPPlatformDefaultConfig.h

Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
@dinabenamar dinabenamar requested a review from a team as a code owner October 31, 2024 15:28
@semanticdiff-com
Copy link
Copy Markdown

Review changes with  SemanticDiff

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 31, 2024

PR #36322: Size comparison from 6aa13c0 to cabca37

Full report (46 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, nrfconnect, psoc6, qpg, stm32, telink, tizen)
platform target config section 6aa13c0 cabca37 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1351880 1351880 0 0.0
RAM 104080 104080 0 0.0
bl702 lighting-app bl702+eth FLASH 649246 649246 0 0.0
RAM 25321 25321 0 0.0
bl702+wifi FLASH 826826 826826 0 0.0
RAM 14053 14053 0 0.0
bl706+mfd+rpc+littlefs FLASH 1056486 1056486 0 0.0
RAM 23901 23901 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 976652 976652 0 0.0
RAM 16556 16556 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 838028 838028 0 0.0
RAM 123628 123628 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823792 823792 0 0.0
RAM 125516 125516 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770532 770532 0 0.0
RAM 113984 113984 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 754736 754736 0 0.0
RAM 114192 114192 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 627342 627342 0 0.0
RAM 205780 205780 0 0.0
lock CC3235SF_LAUNCHXL FLASH 667078 667078 0 0.0
RAM 205932 205932 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 679689 679689 0 0.0
RAM 78684 78684 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 699541 699541 0 0.0
RAM 81324 81324 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 699541 699541 0 0.0
RAM 81324 81324 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 656477 656477 0 0.0
RAM 73752 73752 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616393 616393 0 0.0
RAM 71644 71644 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 636021 636021 0 0.0
RAM 74188 74188 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 636021 636021 0 0.0
RAM 74188 74188 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635857 635857 0 0.0
RAM 74692 74692 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 655565 655565 0 0.0
RAM 77236 77236 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 655565 655565 0 0.0
RAM 77236 77236 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 611253 611253 0 0.0
RAM 68772 68772 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631113 631113 0 0.0
RAM 71412 71412 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631113 631113 0 0.0
RAM 71412 71412 0 0.0
efr32 lock-app BRD4187C FLASH 928652 928652 0 0.0
RAM 160164 160164 0 0.0
BRD4338a FLASH 743352 743352 0 0.0
RAM 233272 233272 0 0.0
window-app BRD4187C FLASH 1018520 1018520 0 0.0
RAM 128260 128260 0 0.0
linux chip-tool-ipv6only arm64 unknown 21416 21416 0 0.0
FLASH 11029376 11029376 0 0.0
RAM 635400 635400 0 0.0
thermostat-no-ble arm64 unknown 9456 9456 0 0.0
FLASH 4117192 4117192 0 0.0
RAM 242936 242936 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 915096 915096 0 0.0
RAM 143281 143281 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 887740 887740 0 0.0
RAM 141468 141468 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 849160 849160 0 0.0
RAM 142189 142189 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1642780 1642780 0 0.0
RAM 212056 212056 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1550324 1550324 0 0.0
RAM 208856 208856 0 0.0
light cy8ckit_062s2_43012 FLASH 1466924 1466924 0 0.0
RAM 200840 200840 0 0.0
lock cy8ckit_062s2_43012 FLASH 1464636 1464636 0 0.0
RAM 225200 225200 0 0.0
qpg lighting-app qpg6105+debug FLASH 662336 662336 0 0.0
RAM 105380 105380 0 0.0
lock-app qpg6105+debug FLASH 620300 620300 0 0.0
RAM 99832 99832 0 0.0
stm32 light STM32WB5MM-DK FLASH 483160 483160 0 0.0
RAM 144844 144844 0 0.0
telink bridge-app tlsr9258a FLASH 683142 683142 0 0.0
RAM 91232 91232 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622538 622538 0 0.0
RAM 50464 50464 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 710454 710454 0 0.0
RAM 73804 73804 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 627100 627100 0 0.0
RAM 144404 144404 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 813660 813660 0 0.0
RAM 99036 99036 0 0.0
tizen all-clusters-app arm unknown 4932 4932 0 0.0
FLASH 1722100 1722100 0 0.0
RAM 90608 90608 0 0.0
chip-tool-ubsan arm unknown 10820 10820 0 0.0
FLASH 18008310 18008310 0 0.0
RAM 7858000 7858000 0 0.0

Comment thread src/platform/nxp/common/CHIPDeviceNXPPlatformDefaultConfig.h Outdated
Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 31, 2024

PR #36322: Size comparison from 6aa13c0 to 268c445

Increases above 0.2%:

platform target config section 6aa13c0 268c445 change % change
telink bridge-app tlsr9258a RAM 91232 91528 296 0.3
lighting-app-ota-factory-data tlsr9118bdk40d RAM 144404 145384 980 0.7
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d RAM 99036 100004 968 1.0
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 6aa13c0 268c445 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1351880 1351454 -426 -0.0
RAM 104080 104080 0 0.0
bl702 lighting-app bl702+eth FLASH 649246 649058 -188 -0.0
RAM 25321 25321 0 0.0
bl702+wifi FLASH 826826 826638 -188 -0.0
RAM 14053 14053 0 0.0
bl706+mfd+rpc+littlefs FLASH 1056486 1056298 -188 -0.0
RAM 23901 23901 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 976652 976464 -188 -0.0
RAM 16556 16556 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 838028 837924 -104 -0.0
RAM 123628 123628 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823792 823696 -96 -0.0
RAM 125516 125516 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770532 770436 -96 -0.0
RAM 113984 113984 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 754736 754640 -96 -0.0
RAM 114192 114192 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 627342 627382 40 0.0
RAM 205780 205780 0 0.0
lock CC3235SF_LAUNCHXL FLASH 667078 667126 48 0.0
RAM 205932 205932 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 679689 679585 -104 -0.0
RAM 78684 78684 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 699541 699437 -104 -0.0
RAM 81324 81324 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 699541 699437 -104 -0.0
RAM 81324 81324 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 656477 656373 -104 -0.0
RAM 73752 73752 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616393 616289 -104 -0.0
RAM 71644 71644 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 636021 635917 -104 -0.0
RAM 74188 74188 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 636021 635917 -104 -0.0
RAM 74188 74188 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635857 635753 -104 -0.0
RAM 74692 74692 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 655565 655469 -96 -0.0
RAM 77236 77236 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 655565 655469 -96 -0.0
RAM 77236 77236 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 611253 611157 -96 -0.0
RAM 68772 68772 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631113 631009 -104 -0.0
RAM 71412 71412 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631113 631009 -104 -0.0
RAM 71412 71412 0 0.0
efr32 lock-app BRD4187C FLASH 928652 928556 -96 -0.0
RAM 160164 160164 0 0.0
BRD4338a FLASH 743352 743400 48 0.0
RAM 233272 233272 0 0.0
window-app BRD4187C FLASH 1018520 1018552 32 0.0
RAM 128260 128260 0 0.0
esp32 all-clusters-app c3devkit DRAM 95328 95328 0 0.0
FLASH 1540094 1539912 -182 -0.0
IRAM 82542 82542 0 0.0
m5stack DRAM 116256 116256 0 0.0
FLASH 1549262 1549102 -160 -0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2731595 2730639 -956 -0.0
RAM 129616 129616 0 0.0
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 6019704 6018748 -956 -0.0
RAM 523872 523872 0 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5356946 5355990 -956 -0.0
RAM 242448 242448 0 0.0
bridge-app debug unknown 5408 5408 0 0.0
FLASH 4700450 4699494 -956 -0.0
RAM 218400 218400 0 0.0
chip-tool debug unknown 5960 5960 0 0.0
FLASH 12901222 12900268 -954 -0.0
RAM 584466 584466 0 0.0
chip-tool-ipv6only arm64 unknown 21416 21416 0 0.0
FLASH 11029376 11028352 -1024 -0.0
RAM 635400 635400 0 0.0
fabric-admin debug unknown 5792 5792 0 0.0
FLASH 11308753 11307799 -954 -0.0
RAM 584922 584922 0 0.0
fabric-bridge-app debug unknown 4632 4632 0 0.0
FLASH 4527502 4526546 -956 -0.0
RAM 205368 205368 0 0.0
fabric-sync debug unknown 4840 4840 0 0.0
FLASH 5239621 5238645 -976 -0.0
RAM 465432 465432 0 0.0
lighting-app debug+rpc+ui unknown 6056 6056 0 0.0
FLASH 5637313 5636353 -960 -0.0
RAM 228520 228520 0 0.0
lock-app debug unknown 5344 5344 0 0.0
FLASH 4748870 4747914 -956 -0.0
RAM 204520 204520 0 0.0
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4375630 4374674 -956 -0.0
RAM 198240 198240 0 0.0
ota-requestor-app debug unknown 4656 4656 0 0.0
FLASH 4513870 4512914 -956 -0.0
RAM 202808 202808 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3046973 3046061 -912 -0.0
RAM 160336 160336 0 0.0
thermostat-no-ble arm64 unknown 9456 9456 0 0.0
FLASH 4117192 4116152 -1040 -0.0
RAM 242936 242936 0 0.0
tv-app debug unknown 5624 5624 0 0.0
FLASH 5971893 5970933 -960 -0.0
RAM 596304 596304 0 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 11108589 11107629 -960 -0.0
RAM 694552 694552 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 915096 914996 -100 -0.0
RAM 143281 143281 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 887740 887572 -168 -0.0
RAM 141468 141468 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 849160 849060 -100 -0.0
RAM 142189 142189 0 0.0
nxp contact k32w0+release FLASH 584208 584112 -96 -0.0
RAM 71044 71044 0 0.0
mcxw71+release FLASH 598744 598648 -96 -0.0
RAM 63144 63144 0 0.0
light k32w0+release FLASH 611252 611156 -96 -0.0
RAM 70436 70436 0 0.0
k32w1+release FLASH 685048 684944 -104 -0.0
RAM 48776 48776 0 0.0
lock mcxw71+release FLASH 748576 748480 -96 -0.0
RAM 67300 67300 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1642780 1642828 48 0.0
RAM 212056 212056 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1550324 1550356 32 0.0
RAM 208856 208856 0 0.0
light cy8ckit_062s2_43012 FLASH 1466924 1466956 32 0.0
RAM 200840 200840 0 0.0
lock cy8ckit_062s2_43012 FLASH 1464636 1464684 48 0.0
RAM 225200 225200 0 0.0
qpg lighting-app qpg6105+debug FLASH 662336 662232 -104 -0.0
RAM 105380 105380 0 0.0
lock-app qpg6105+debug FLASH 620300 620196 -104 -0.0
RAM 99832 99832 0 0.0
stm32 light STM32WB5MM-DK FLASH 483160 483056 -104 -0.0
RAM 144844 144844 0 0.0
telink bridge-app tlsr9258a FLASH 683142 684252 1110 0.2
RAM 91232 91528 296 0.3
contact-sensor-app tlsr9528a_retention FLASH 622538 622362 -176 -0.0
RAM 50464 50464 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 710454 710278 -176 -0.0
RAM 73804 73804 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 627100 628468 1368 0.2
RAM 144404 145384 980 0.7
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 813660 814816 1156 0.1
RAM 99036 100004 968 1.0
tizen all-clusters-app arm unknown 4932 4932 0 0.0
FLASH 1722100 1721588 -512 -0.0
RAM 90608 90608 0 0.0
chip-tool-ubsan arm unknown 10820 10820 0 0.0
FLASH 18008310 18006486 -1824 -0.0
RAM 7858000 7857312 -688 -0.0

@dinabenamar dinabenamar requested a review from andy31415 November 7, 2024 07:55
@mergify mergify Bot merged commit 8797fa0 into project-chip:master Nov 7, 2024
@dinabenamar dinabenamar deleted the nxp_upstream_chip_config branch November 14, 2024 12:33
GabrielCouturier pushed a commit to NXP/matter that referenced this pull request Dec 11, 2024
…uration using generated macros (project-chip#36322)

* [NXP][platform][common] Support to configure CHIP using generated macros

Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>

* [NXP] Remove unused macro from config header file

Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>

---------

Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
(cherry picked from commit 8797fa0)
yyzhong-g pushed a commit to yyzhong-g/connectedhomeip that referenced this pull request Dec 12, 2024
…enerated macros (project-chip#36322)

* [NXP][platform][common] Support to configure CHIP using generated macros

Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>

* [NXP] Remove unused macro from config header file

Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>

---------

Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
Martin-NXP pushed a commit to NXP/matter that referenced this pull request Jan 10, 2025
…uration using generated macros (project-chip#36322)

* [NXP][platform][common] Support to configure CHIP using generated macros

Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>

* [NXP] Remove unused macro from config header file

Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>

---------

Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com>
(cherry picked from commit 8797fa0)
Martin-NXP pushed a commit to NXP/matter that referenced this pull request Jan 10, 2025
…P configuration using generated macros (project-chip#36322)"

This reverts commit 9aca1e8.

Signed-off-by: marius-alex-tache <marius.tache@nxp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants