[CASESession] refactoring and improving testability of Sigma1 sending and handling, and Sigma2 Sending #36679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
Alami-Amine
force-pushed
the
AA/CASERefactorSigma1
branch
from
3b59b16 to
13a8f48
Compare
|
PR #36679: Size comparison from d37eae1 to 13a8f48 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36679: Size comparison from d37eae1 to 224a626 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Alami-Amine
force-pushed
the
AA/CASERefactorSigma1
branch
from
cf3ac6a to
a2624fa
Compare
|
PR #36679: Size comparison from 5d42d92 to a2624fa Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Alami-Amine
force-pushed
the
AA/CASERefactorSigma1
branch
2 times, most recently
from
a70c7c5 to
673c53b
Compare
|
PR #36679: Size comparison from 41a9dea to 673c53b Full report (11 builds for cc13x4_26x4, cc32xx, qpg, stm32, tizen)
|
Alami-Amine
force-pushed
the
AA/CASERefactorSigma1
branch
from
673c53b to
7d0b4a6
Compare
|
PR #36679: Size comparison from 41a9dea to 7d0b4a6 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Alami-Amine
force-pushed
the
AA/CASERefactorSigma1
branch
from
0013419 to
6c13347
Compare
|
PR #36679: Size comparison from 75ab4c9 to 6c13347 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Alami-Amine
changed the title
|
PR #36679: Size comparison from 1c92162 to 3060675 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
requested changes
Dec 18, 2024
|
PR #36679: Size comparison from c1afc02 to bd0252a Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Alami-Amine
force-pushed
the
AA/CASERefactorSigma1
branch
from
4ddcb46 to
eca5000
Compare
|
PR #36679: Size comparison from c1afc02 to eca5000 Full report (19 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
…d a Sigma message or a status report
Alami-Amine
force-pushed
the
AA/CASERefactorSigma1
branch
from
eca5000 to
264ba3e
Compare
Alami-Amine
force-pushed
the
AA/CASERefactorSigma1
branch
from
4e5c6e7 to
993edbd
Compare
|
PR #36679: Size comparison from 4c725be to 993edbd Full report (5 builds for cc32xx, stm32, tizen)
|
Alami-Amine
force-pushed
the
AA/CASERefactorSigma1
branch
from
7eacf31 to
a30fc3c
Compare
|
PR #36679: Size comparison from 4c725be to a30fc3c Full report (9 builds for cc13x4_26x4, cc32xx, stm32, tizen)
|
Alami-Amine
force-pushed
the
AA/CASERefactorSigma1
branch
from
a30fc3c to
6a9068f
Compare
|
PR #36679: Size comparison from 4c725be to 6a9068f Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Dec 20, 2024
|
PR #36679: Size comparison from 4c725be to a89758a Increases above 0.2%:
Full report (49 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
Alami-Amine
force-pushed
the
AA/CASERefactorSigma1
branch
from
a89758a to
db95d7c
Compare
|
PR #36679: Size comparison from 017e8b5 to db95d7c Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in the PR
Sending Sigma1
EncodeSigma1()method; removing the bits from Networking and Messaging layers --> that way it could be tested without needingSessionManagerandExchangeContext.HandleSigma1_and_SendSigma2HandleSigma1_and_SendSigma2:previously, this method was primarily a wrapper to
HandleSigma1(); which in turn handled with all the validation and parsing of Sigma1 as well as the generation, and logic involved in sending Sigma2 or Sigma2Resume...in a very sequential manner.Fix: This was changed to be more modular, by factoring out the
Sending Sigma2calls out ofHandleSigma1(), and encapsulating it in a switch-case statement, and then breaking downSigma2 Sendingmethods into two more methods: one for generating and preparing the Logic for the Sigma2, and one for Encoding it into TLV-format.ParseSigma1(): made the output in the form of a struct, and decoupling it from exchange context, which was moved toHandleSigma1()EncodeSigma2()andEncodeSigma2Resume(): created and refactored into them the TLV encoding for the final Sigma2/Sigma2Resume messages that will be sent.PrepareSigma2()andPrepareSigma2Resume(): refactored into them all the steps that happen before Encoding the Sigma2/Sigma2Resume messages.CASESession.cppandPASESession.cppshould be using named tag #30476Testing