[chip-tool][darwin-framework-tool] Add libs to the declare_args secti… #36762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #36762: Size comparison from af8d173 to 2148272 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Dec 9, 2024
| @@ -25,6 +25,10 @@ if (config_use_interactive_mode) { | |||
|
|
|||
| assert(chip_build_tools) | |||
|
|
|||
| declare_args() { | |||
| libs = [] | |||
There was a problem hiding this comment.
libs seems quite a generic argument name. Can we be more specific?
Please add comments explaining purpose and usage.
There was a problem hiding this comment.
Why does chip-tool need this? I see darwin-framework-tool uses it only.
There was a problem hiding this comment.
libs seems quite a generic argument name. Can we be more specific?
This is a built-in gn variable. See https://gn.googlesource.com/gn/+/main/docs/reference.md#var_libs
The idea is to be able to pass, on command line, additional libraries to link, it looks like. So you won't see "uses" in chip-tool, just "uses" when someone builds chip-tool.
There was a problem hiding this comment.
By "uses" I mean to justify use cases in comments. This PR asks to add something that we need to then maintain and because nobody uses it, we won't have CI for this. Maybe we should have some CI (e.g. some malloc library for testing? I have no idea)...
I am pushing back on adding something that is very broad (can add any library here) that has no tests and no description of practical use. I am sure it has a practical use in mind, but nothing documented and nothing in CI/tested is concerning.
andy31415
requested changes
Dec 9, 2024
There was a problem hiding this comment.
This needs more explanation (in commments near the argument) of what "testing with custom libraries" actually means.
I am unsure we want this build system flexibility: if we need custom builds, people should create custom builds. Allowing a hook of "inject anything" seems super broad and requires explanations/documentation.
andy31415
reviewed
Dec 13, 2024
There was a problem hiding this comment.
The SWTT standup has a Testing section requirement now. That seems to potentially serve well here as it forces an explanation on "how was this tested" and that implies we may get some examples on how these libs arguments were used (and why this affects both chip-tool and darwin-framework-tool)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on of BUILD.gn
Problem
This PR introduces the
libsargument to thedeclare_argssections of bothchip-tool/BUILD.gnanddarwin-framework-tool/BUILD.gn.Adding the libs argument facilitates testing against custom libraries.