[ESP32]: Remove the same configs as defaults #36940
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DejinChen
force-pushed
the
esp32/remove_same_configs
branch
from
793e834 to
5b3b55a
Compare
|
PR #36940: Size comparison from 2249628 to 5b3b55a Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
DejinChen
force-pushed
the
esp32/remove_same_configs
branch
from
5b3b55a to
8f67708
Compare
|
PR #36940: Size comparison from 2249628 to 8f67708 Increases above 0.2%:
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Jan 6, 2025
| if board == Esp32Board.C3DevKit: | ||
| return 'sdkconfig.defaults.esp32c3' | ||
| else: | ||
| return '' |
There was a problem hiding this comment.
empty string seems more magic ... how about making this return Optional[str] and then return None? A check of is not None seems more clear/intuitive than == ""
andy31415
reviewed
Jan 6, 2025
| @@ -111,6 +111,20 @@ def IsCompatible(self, board: Esp32Board): | |||
| return (board in {Esp32Board.M5Stack, Esp32Board.DevKitC}) and (self != Esp32App.TESTS) | |||
|
|
|||
|
|
|||
| def TargetName(board: Esp32Board): | |||
There was a problem hiding this comment.
these can be @property methods on Esp32Board for consistency of style with existing Esp32App properties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For esp32, if
sdkconfig.defaultsis the default config file andIDF_TARGETis set, the build system will also attempt to load configs from ansdkconfig.defaults.IDF_TARGET. So modified the CI to support this and removed the same configs as defaults in other target configs.