generate.py: fix build on 32 bit system #36942
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setting max-old-space-size to more than 4GB cause node to fail instantly on 32 bit systems, even to run zap-cli --version.
|
Review changes with |
|
|
|
PR #36942: Size comparison from 2249628 to 290a8f5 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jan 3, 2025
andy31415
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Approving without a ###Testing section for now as the change seems somewhat obvious. However for the future @symphorien please make sure to include a ### Testing section to describe how changes were tested (if they do not contain obvious unit/integration tests)
|
I tested that by building the NixOS packaging of https://github.com/home-assistant-libs/chip-wheels/ for armv7 native. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setting max-old-space-size to more than 4GB causes node to fail instantly on 32 bit systems, even to run zap-cli --version.
Fixes: build fails with
fatal javascript OOM in GC during deserializationwhen building on armv7 (a 32 bit system)