[bouffalo lab] fix crash issues in route hook and rpc uart driver mod… #36944
+11
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #36944: Size comparison from 2249628 to d264fba Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
Commission BL602DK and after connect to Wi-Fi router. Changing IPv6 address prefix of Wi-Fi router four times will get BL602 crashed.
With this PR, changing IPv6 address prefix of Wi-Fi router four more times will not get BL602 crashed.
The uartRead function returning 0 results in Status::FailedPrecondition, which causes an unexpected exit of the RPC and leads to a crash.
uartRead begins to retrieve the last byte from the data queue while a UART FIFO RX timeout interrupt occurs. At that point, the last byte has not yet been read, but it signals to the RPC task that data is available. The last byte is then read by uartRead, and when uartRead is called again by the RPC task, it returns 0.
The fault occurs in extreme environments and during stress testing. We have conducted tests using the Matter auto-test framework, which employs the PRC protocol to communicate with the device for Matter testing. After dozens of tests, we observe this fault occurring once.