-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple ember functions from general diagnostics cluster #37001
Decouple ember functions from general diagnostics cluster #37001
Conversation
4c50c70
to
6275a44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yufengwangca could you please write longer details for manual testing? we want to make this detailed both to have it reproducible by others and avoid having "manual testing" an easy default to avoid writing tests.
Please describe what things you built, what environment, what commands you ran to test and observed results. Also explain why automated testing in CI is not possible (or if it is, if there is a followup to add them and that manual testing is temporary only)
Updated with detailed manual testing steps. This is also verified by the automated testing in CI. |
src/app/clusters/general-diagnostics-server/general-diagnostics-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/general-diagnostics-server/general-diagnostics-server.cpp
Show resolved
Hide resolved
ff20eae
to
05286ea
Compare
1ed29da
to
7a0945d
Compare
7a0945d
to
dc224fb
Compare
PR #37001: Size comparison from 6ffcd19 to dc224fb Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
dc224fb
to
ee65203
Compare
PR #37001: Size comparison from 11a6571 to ee65203 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #37001: Size comparison from 839a11d to 574b934 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
scripts/tools/zap/tests/outputs/all-clusters-app/app-templates/gen_config.h
Outdated
Show resolved
Hide resolved
src/app/clusters/general-diagnostics-server/general-diagnostics-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/general-diagnostics-server/general-diagnostics-server.cpp
Show resolved
Hide resolved
PR #37001: Size comparison from 839a11d to 2ccaf34 Increases above 0.2%:
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
2ccaf34
to
313eb29
Compare
PR #37001: Size comparison from c389092 to 313eb29 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Decouple General Diagnostics Cluster from ember and migrate to use CHI (CommandHandlerInterface) instead
Fix: #36844
Testing
It is also verified by the CI