Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update VideoStreamModify command in CameraAVStreamMgmt xml. #37016

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Update VideoStreamModify command in CameraAVStreamMgmt xml. #37016

merged 1 commit into from
Jan 22, 2025
+5 −5

Conversation

pidarped
Copy link
Contributor

@pidarped pidarped commented Jan 9, 2025 •
edited
Loading

Minor modification in the command description to account for the removal of an argument in the Spec.

Testing

No functional changes

@pidarped pidarped requested a review from a team as a code owner January 9, 2025 19:46
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Jan 9, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  src/app/zap-templates/zcl/data-model/chip/camera-av-stream-management-cluster.xml  0% smaller
  src/controller/data_model/controller-clusters.matter Unsupported file format
  src/darwin/Framework/CHIP/zap-generated/MTRBaseClusters.h Unsupported file format

@pidarped pidarped requested a review from a team January 9, 2025 19:47
@pidarped pidarped force-pushed the CameraAVStreamMgmtSpecUpdates branch from 99e7eae to 6b8122f Compare January 16, 2025 19:32
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2025 •
edited
Loading

PR #37016: Size comparison from e8196ff to 6b8122f

Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section e8196ff 6b8122f change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1094048 1094048 0 0.0
RAM 103354 103354 0 0.0
bl702 lighting-app bl702+eth FLASH 652110 652110 0 0.0
RAM 25361 25361 0 0.0
bl702+wifi FLASH 830034 830034 0 0.0
RAM 14101 14101 0 0.0
bl706+mfd+rpc+littlefs FLASH 1057320 1057320 0 0.0
RAM 23957 23957 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 890344 890344 0 0.0
RAM 18632 18632 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 973304 973304 0 0.0
RAM 16480 16480 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 839628 839628 0 0.0
RAM 123536 123536 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 825080 825080 0 0.0
RAM 125424 125424 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 772072 772072 0 0.0
RAM 113900 113900 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 756252 756252 0 0.0
RAM 114100 114100 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 539693 539693 0 0.0
RAM 205288 205288 0 0.0
lock CC3235SF_LAUNCHXL FLASH 573789 573789 0 0.0
RAM 205432 205432 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 681097 681097 0 0.0
RAM 78596 78596 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 700949 700949 0 0.0
RAM 81236 81236 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 700949 700949 0 0.0
RAM 81236 81236 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 657885 657885 0 0.0
RAM 73664 73664 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 617633 617633 0 0.0
RAM 71588 71588 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 637269 637269 0 0.0
RAM 74132 74132 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 637269 637269 0 0.0
RAM 74132 74132 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 637081 637081 0 0.0
RAM 74596 74596 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 656789 656789 0 0.0
RAM 77140 77140 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 656789 656789 0 0.0
RAM 77140 77140 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 613829 613829 0 0.0
RAM 68684 68684 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 633681 633681 0 0.0
RAM 71316 71316 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 633681 633681 0 0.0
RAM 71316 71316 0 0.0
efr32 lock-app BRD4187C FLASH 936448 936448 0 0.0
RAM 160004 160004 0 0.0
BRD4338a FLASH 732212 732204 -8 -0.0
RAM 234844 234844 0 0.0
window-app BRD4187C FLASH 1031960 1031960 0 0.0
RAM 128112 128112 0 0.0
esp32 all-clusters-app c3devkit DRAM 95192 95192 0 0.0
FLASH 1541312 1541312 0 0.0
IRAM 82552 82552 0 0.0
m5stack DRAM 116172 116172 0 0.0
FLASH 1547798 1547798 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4752 4752 0 0.0
FLASH 2714813 2714813 0 0.0
RAM 133096 133096 0 0.0
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 5985354 5985354 0 0.0
RAM 531832 531832 0 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5331698 5331698 0 0.0
RAM 243008 243008 0 0.0
bridge-app debug unknown 5472 5472 0 0.0
FLASH 4687652 4687652 0 0.0
RAM 221760 221760 0 0.0
chip-tool debug unknown 5984 5984 0 0.0
FLASH 13045170 13045170 0 0.0
RAM 596634 596634 0 0.0
chip-tool-ipv6only arm64 unknown 21816 21816 0 0.0
FLASH 11125584 11125584 0 0.0
RAM 648168 648168 0 0.0
fabric-admin debug unknown 5808 5808 0 0.0
FLASH 11392145 11392145 0 0.0
RAM 596978 596978 0 0.0
fabric-bridge-app debug unknown 4728 4728 0 0.0
FLASH 4511888 4511888 0 0.0
RAM 208880 208880 0 0.0
fabric-sync debug unknown 4968 4968 0 0.0
FLASH 5614693 5614693 0 0.0
RAM 483656 483656 0 0.0
lighting-app debug+rpc+ui unknown 6136 6136 0 0.0
FLASH 5622433 5622433 0 0.0
RAM 232008 232008 0 0.0
lock-app debug unknown 5408 5408 0 0.0
FLASH 4736048 4736048 0 0.0
RAM 208008 208008 0 0.0
ota-provider-app debug unknown 4768 4768 0 0.0
FLASH 4365018 4365018 0 0.0
RAM 201696 201696 0 0.0
ota-requestor-app debug unknown 4720 4720 0 0.0
FLASH 4502944 4502944 0 0.0
RAM 206280 206280 0 0.0
shell debug unknown 4248 4248 0 0.0
FLASH 3014861 3014861 0 0.0
RAM 160736 160736 0 0.0
thermostat-no-ble arm64 unknown 9552 9552 0 0.0
FLASH 4105624 4105624 0 0.0
RAM 246224 246224 0 0.0
tv-app debug unknown 5736 5736 0 0.0
FLASH 5956933 5956933 0 0.0
RAM 607088 607088 0 0.0
tv-casting-app debug unknown 5312 5312 0 0.0
FLASH 11277869 11277869 0 0.0
RAM 711064 711064 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 917388 917388 0 0.0
RAM 143172 143172 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 890880 890880 0 0.0
RAM 141359 141359 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 851516 851516 0 0.0
RAM 142084 142084 0 0.0
nxp contact k32w0+release FLASH 585464 585464 0 0.0
RAM 70952 70952 0 0.0
mcxw71+release FLASH 600984 600984 0 0.0
RAM 63168 63168 0 0.0
light k32w0+release FLASH 612148 612148 0 0.0
RAM 70344 70344 0 0.0
k32w1+release FLASH 686696 686696 0 0.0
RAM 48760 48760 0 0.0
lock mcxw71+release FLASH 762952 762952 0 0.0
RAM 70796 70796 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1650908 1650908 0 0.0
RAM 211624 211624 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1556916 1556916 0 0.0
RAM 208440 208440 0 0.0
light cy8ckit_062s2_43012 FLASH 1471596 1471596 0 0.0
RAM 200408 200408 0 0.0
lock cy8ckit_062s2_43012 FLASH 1469332 1469332 0 0.0
RAM 224760 224760 0 0.0
qpg lighting-app qpg6105+debug FLASH 663688 663688 0 0.0
RAM 105296 105296 0 0.0
lock-app qpg6105+debug FLASH 621500 621500 0 0.0
RAM 99748 99748 0 0.0
stm32 light STM32WB5MM-DK FLASH 484448 484448 0 0.0
RAM 144752 144752 0 0.0
telink bridge-app tlsr9258a FLASH 683134 683134 0 0.0
RAM 91088 91088 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 623392 623392 0 0.0
RAM 31488 31488 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 772234 772234 0 0.0
RAM 49348 49348 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 776838 776838 0 0.0
RAM 99652 99652 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 710774 710774 0 0.0
RAM 73384 73384 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 627776 627776 0 0.0
RAM 142020 142020 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 813848 813848 0 0.0
RAM 99564 99564 0 0.0
tizen all-clusters-app arm unknown 5120 5120 0 0.0
FLASH 1761104 1761104 0 0.0
RAM 93672 93672 0 0.0
chip-tool-ubsan arm unknown 11044 11044 0 0.0
FLASH 18216310 18216310 0 0.0
RAM 7958272 7958272 0 0.0

@pidarped
Update VideoStreamModify command in CameraAVStreamMgmt xml.
48d68c5 
Minor modification in the command description to account for the removal
of an argument in the Spec.
@pidarped pidarped force-pushed the CameraAVStreamMgmtSpecUpdates branch from 6b8122f to 48d68c5 Compare January 22, 2025 20:58
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

PR #37016: Size comparison from 2d0f857 to 48d68c5

Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 2d0f857 48d68c5 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1092312 1092312 0 0.0
RAM 103282 103282 0 0.0
bl702 lighting-app bl702+eth FLASH 650236 650236 0 0.0
RAM 25265 25265 0 0.0
bl702+wifi FLASH 828400 828400 0 0.0
RAM 13981 13981 0 0.0
bl706+mfd+rpc+littlefs FLASH 1055136 1055136 0 0.0
RAM 23845 23845 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 888134 888134 0 0.0
RAM 18504 18504 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 971120 971120 0 0.0
RAM 16368 16368 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 838000 838000 0 0.0
RAM 123464 123464 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823412 823412 0 0.0
RAM 125344 125344 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770636 770636 0 0.0
RAM 113804 113804 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 754888 754888 0 0.0
RAM 114012 114012 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538433 538433 0 0.0
RAM 205192 205192 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572297 572297 0 0.0
RAM 205344 205344 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 679401 679401 0 0.0
RAM 78532 78532 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 699253 699253 0 0.0
RAM 81172 81172 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 699253 699253 0 0.0
RAM 81172 81172 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 656181 656181 0 0.0
RAM 73600 73600 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 615793 615793 0 0.0
RAM 71516 71516 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635421 635421 0 0.0
RAM 74060 74060 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635421 635421 0 0.0
RAM 74060 74060 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635265 635265 0 0.0
RAM 74524 74524 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 654973 654973 0 0.0
RAM 77068 77068 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 654973 654973 0 0.0
RAM 77068 77068 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 611701 611701 0 0.0
RAM 68612 68612 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631561 631561 0 0.0
RAM 71252 71252 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631561 631561 0 0.0
RAM 71252 71252 0 0.0
efr32 lock-app BRD4187C FLASH 934672 934672 0 0.0
RAM 159904 159904 0 0.0
BRD4338a FLASH 729676 729668 -8 -0.0
RAM 234768 234768 0 0.0
window-app BRD4187C FLASH 1029352 1029344 -8 -0.0
RAM 128040 128040 0 0.0
esp32 all-clusters-app c3devkit DRAM 95104 95104 0 0.0
FLASH 1536860 1536860 0 0.0
IRAM 82552 82552 0 0.0
m5stack DRAM 116092 116092 0 0.0
FLASH 1544946 1544946 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4752 4752 0 0.0
FLASH 2708845 2708845 0 0.0
RAM 132800 132800 0 0.0
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 5974932 5974932 0 0.0
RAM 531616 531616 0 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5323618 5323618 0 0.0
RAM 242728 242728 0 0.0
bridge-app debug unknown 5472 5472 0 0.0
FLASH 4681806 4681806 0 0.0
RAM 221464 221464 0 0.0
chip-tool debug unknown 5984 5984 0 0.0
FLASH 13046874 13046874 0 0.0
RAM 596178 596178 0 0.0
chip-tool-ipv6only arm64 unknown 21776 21776 0 0.0
FLASH 11124048 11124048 0 0.0
RAM 647920 647920 0 0.0
fabric-admin debug unknown 5808 5808 0 0.0
FLASH 11393881 11393881 0 0.0
RAM 596522 596522 0 0.0
fabric-bridge-app debug unknown 4728 4728 0 0.0
FLASH 4507202 4507202 0 0.0
RAM 208648 208648 0 0.0
fabric-sync debug unknown 4968 4968 0 0.0
FLASH 5612613 5612613 0 0.0
RAM 483520 483520 0 0.0
lighting-app debug+rpc+ui unknown 6136 6136 0 0.0
FLASH 5615921 5615921 0 0.0
RAM 231744 231744 0 0.0
lock-app debug unknown 5408 5408 0 0.0
FLASH 4730856 4730856 0 0.0
RAM 207712 207712 0 0.0
ota-provider-app debug unknown 4768 4768 0 0.0
FLASH 4359432 4359432 0 0.0
RAM 201352 201352 0 0.0
ota-requestor-app debug unknown 4720 4720 0 0.0
FLASH 4496936 4496936 0 0.0
RAM 205936 205936 0 0.0
shell debug unknown 4248 4248 0 0.0
FLASH 3005021 3005021 0 0.0
RAM 160504 160504 0 0.0
thermostat-no-ble arm64 unknown 9536 9536 0 0.0
FLASH 4098896 4098896 0 0.0
RAM 246136 246136 0 0.0
tv-app debug unknown 5736 5736 0 0.0
FLASH 5952245 5952245 0 0.0
RAM 606920 606920 0 0.0
tv-casting-app debug unknown 5312 5312 0 0.0
FLASH 11272349 11272349 0 0.0
RAM 710864 710864 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 913652 913652 0 0.0
RAM 143168 143168 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 888632 888632 0 0.0
RAM 141355 141355 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 848696 848696 0 0.0
RAM 142080 142080 0 0.0
nxp contact k32w0+release FLASH 584288 584288 0 0.0
RAM 70860 70860 0 0.0
mcxw71+release FLASH 599632 599632 0 0.0
RAM 63080 63080 0 0.0
light k32w0+release FLASH 610716 610716 0 0.0
RAM 70252 70252 0 0.0
k32w1+release FLASH 685184 685184 0 0.0
RAM 48664 48664 0 0.0
lock mcxw71+release FLASH 748648 748648 0 0.0
RAM 67476 67476 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646420 1646420 0 0.0
RAM 211560 211560 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1553212 1553212 0 0.0
RAM 208376 208376 0 0.0
light cy8ckit_062s2_43012 FLASH 1468876 1468876 0 0.0
RAM 200352 200352 0 0.0
lock cy8ckit_062s2_43012 FLASH 1466908 1466908 0 0.0
RAM 224688 224688 0 0.0
qpg lighting-app qpg6105+debug FLASH 661992 661992 0 0.0
RAM 105204 105204 0 0.0
lock-app qpg6105+debug FLASH 619772 619772 0 0.0
RAM 99648 99648 0 0.0
stm32 light STM32WB5MM-DK FLASH 482608 482608 0 0.0
RAM 144672 144672 0 0.0
telink bridge-app tlsr9258a FLASH 681522 681522 0 0.0
RAM 91084 91084 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621556 621556 0 0.0
RAM 31484 31484 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 770426 770426 0 0.0
RAM 49344 49344 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 774822 774822 0 0.0
RAM 99648 99648 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 708724 708724 0 0.0
RAM 73376 73376 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625832 625832 0 0.0
RAM 142016 142016 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811882 811882 0 0.0
RAM 99560 99560 0 0.0
tizen all-clusters-app arm unknown 5112 5112 0 0.0
FLASH 1751312 1751312 0 0.0
RAM 93524 93524 0 0.0
chip-tool-ubsan arm unknown 11024 11024 0 0.0
FLASH 18213990 18213990 0 0.0
RAM 7955248 7955248 0 0.0

@mergify mergify bot merged commit 4412d0c into project-chip:master Jan 22, 2025
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@aronrosenberg aronrosenberg aronrosenberg approved these changes

Assignees
No one assigned
Labels
app controller darwin review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pidarped @aronrosenberg @yufengwangca @bzbarsky-apple