Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icd management: make the feature map and operating mode managed by AAI #37062

Merged
merged 11 commits into from
Jan 17, 2025
Merged

icd management: make the feature map and operating mode managed by AAI #37062

merged 11 commits into from
Jan 17, 2025

Conversation

wqx6
Copy link
Contributor

@wqx6 wqx6 commented Jan 14, 2025

The OperatingMode attribute and FeatureMap attribute of ICDManagement cluster should be managed by AAI instead of ember as the ICDConfigurationData maintains values for the two attributes

Testing

  • The unit test should pass
  • Tested lit-icd-app on ESP32-H2.

@wqx6 wqx6 requested review from a team as code owners January 14, 2025 11:40
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Jan 14, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  src/app/zap-templates/zcl/zcl-with-test-extensions.json  50% smaller
  src/app/zap-templates/zcl/zcl.json  50% smaller
  examples/contact-sensor-app/bouffalolab/data_model/contact-sensor-app.matter Unsupported file format
  examples/contact-sensor-app/nxp/zap-lit/contact-sensor-app.matter Unsupported file format
  examples/contact-sensor-app/nxp/zap-sit/contact-sensor-app.matter Unsupported file format
  examples/light-switch-app/light-switch-common/icd-lit-light-switch-app.matter Unsupported file format
  examples/light-switch-app/light-switch-common/light-switch-app.matter Unsupported file format
  examples/light-switch-app/qpg/zap/switch.matter Unsupported file format
  examples/lit-icd-app/lit-icd-common/lit-icd-server-app.matter Unsupported file format
  examples/lock-app/lock-common/lock-app.matter Unsupported file format
  examples/lock-app/nxp/zap/lock-app.matter Unsupported file format
  examples/lock-app/qpg/zap/lock.matter Unsupported file format
  examples/lock-app/silabs/data_model/lock-app.matter Unsupported file format
  examples/smoke-co-alarm-app/smoke-co-alarm-common/smoke-co-alarm-app.matter Unsupported file format
  examples/window-app/common/window-app.matter Unsupported file format
  src/app/clusters/icd-management-server/icd-management-server.cpp Unsupported file format
  src/app/icd/server/BUILD.gn Unsupported file format
  src/app/icd/server/ICDConfigurationData.h Unsupported file format
  src/app/icd/server/ICDManager.cpp Unsupported file format
  src/app/icd/server/ICDManager.h Unsupported file format
  src/app/icd/server/tests/ICDConfigurationDataTestAccess.h Unsupported file format
  src/app/icd/server/tests/TestICDManager.cpp Unsupported file format
  zzz_generated/app-common/app-common/zap-generated/attributes/Accessors.cpp Unsupported file format
  zzz_generated/app-common/app-common/zap-generated/attributes/Accessors.h Unsupported file format

@github-actions github-actions bot added examples app icd Intermittently Connected Devices labels Jan 14, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 14, 2025 •
edited
Loading

PR #37062: Size comparison from 5bd63d5 to 4282d48

Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 5bd63d5 4282d48f change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1355350 1355354 4 0.0
RAM 103952 103960 8 0.0
bl702 lighting-app bl702+eth FLASH 726034 726034 0 0.0
RAM 25353 25357 4 0.0
bl702+wifi FLASH 912904 912904 0 0.0
RAM 14093 14097 4 0.0
bl706+mfd+rpc+littlefs FLASH 1173762 1173762 0 0.0
RAM 23933 23933 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 1082790 1082790 0 0.0
RAM 16604 16608 4 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 840176 840176 0 0.0
RAM 123552 123552 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 825692 825740 48 0.0
RAM 125440 125432 -8 -0.0
pump-app LP_EM_CC1354P10_6 FLASH 772620 772628 8 0.0
RAM 113916 113924 8 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 756816 756824 8 0.0
RAM 114116 114124 8 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 540041 540049 8 0.0
RAM 205304 205312 8 0.0
lock CC3235SF_LAUNCHXL FLASH 574209 574257 48 0.0
RAM 205448 205448 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 681569 681569 0 0.0
RAM 78596 78604 8 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 701413 701421 8 0.0
RAM 81236 81244 8 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 701413 701421 8 0.0
RAM 81236 81244 8 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 658357 658357 0 0.0
RAM 73664 73672 8 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 618153 618121 -32 -0.0
RAM 71588 71588 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 637789 637757 -32 -0.0
RAM 74132 74132 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 637789 637757 -32 -0.0
RAM 74132 74132 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 637601 637569 -32 -0.0
RAM 74596 74596 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 657317 657277 -40 -0.0
RAM 77140 77140 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 657317 657277 -40 -0.0
RAM 77140 77140 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614213 614133 -80 -0.0
RAM 68684 68692 8 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634065 633985 -80 -0.0
RAM 71316 71324 8 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634065 633985 -80 -0.0
RAM 71316 71324 8 0.0
efr32 lock-app BRD4187C FLASH 932468 932436 -32 -0.0
RAM 160068 160068 0 0.0
BRD4338a FLASH 749232 749272 40 0.0
RAM 233196 233196 0 0.0
window-app BRD4187C FLASH 1026864 1026920 56 0.0
RAM 128172 128172 0 0.0
esp32 all-clusters-app c3devkit DRAM 95192 95192 0 0.0
FLASH 1541904 1541904 0 0.0
IRAM 82552 82552 0 0.0
m5stack DRAM 116172 116172 0 0.0
FLASH 1548458 1548458 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4752 4752 0 0.0
FLASH 2723229 2723271 42 0.0
RAM 133160 133160 0 0.0
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 5996466 5996508 42 0.0
RAM 526072 526072 0 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5341652 5341694 42 0.0
RAM 243072 243072 0 0.0
bridge-app debug unknown 5472 5472 0 0.0
FLASH 4696806 4696848 42 0.0
RAM 221824 221824 0 0.0
chip-tool debug unknown 5984 5984 0 0.0
FLASH 12867152 12867192 40 0.0
RAM 587002 587002 0 0.0
chip-tool-ipv6only arm64 unknown 21536 21536 0 0.0
FLASH 10989440 10989456 16 0.0
RAM 638048 638048 0 0.0
fabric-admin debug unknown 5808 5808 0 0.0
FLASH 11274263 11274303 40 0.0
RAM 587346 587346 0 0.0
fabric-bridge-app debug unknown 4728 4728 0 0.0
FLASH 4521756 4521798 42 0.0
RAM 208928 208928 0 0.0
fabric-sync debug unknown 4968 4968 0 0.0
FLASH 5622981 5623029 48 0.0
RAM 477880 477880 0 0.0
lighting-app debug+rpc+ui unknown 6136 6136 0 0.0
FLASH 5631329 5631377 48 0.0
RAM 232072 232072 0 0.0
lock-app debug unknown 5408 5408 0 0.0
FLASH 4744568 4745628 1060 0.0
RAM 208072 208072 0 0.0
ota-provider-app debug unknown 4768 4768 0 0.0
FLASH 4372108 4372150 42 0.0
RAM 201744 201744 0 0.0
ota-requestor-app debug unknown 4720 4720 0 0.0
FLASH 4510120 4510162 42 0.0
RAM 206312 206312 0 0.0
shell debug unknown 4248 4248 0 0.0
FLASH 3023197 3023245 48 0.0
RAM 160792 160792 0 0.0
thermostat-no-ble arm64 unknown 9552 9552 0 0.0
FLASH 4110296 4110328 32 0.0
RAM 246368 246368 0 0.0
tv-app debug unknown 5736 5736 0 0.0
FLASH 5966741 5966789 48 0.0
RAM 601312 601312 0 0.0
tv-casting-app debug unknown 5312 5312 0 0.0
FLASH 11102349 11102381 32 0.0
RAM 700496 700496 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 917804 917808 4 0.0
RAM 143172 143176 4 0.0
nrf7002dk_nrf5340_cpuapp FLASH 890868 890868 0 0.0
RAM 141359 141363 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 851932 851936 4 0.0
RAM 142084 142088 4 0.0
nxp contact k32w0+release FLASH 585968 585920 -48 -0.0
RAM 70952 70960 8 0.0
mcxw71+release FLASH 601488 601448 -40 -0.0
RAM 63168 63176 8 0.0
light k32w0+release FLASH 612588 612604 16 0.0
RAM 70344 70352 8 0.0
k32w1+release FLASH 687152 687160 8 0.0
RAM 48760 48768 8 0.0
lock mcxw71+release FLASH 763464 763424 -40 -0.0
RAM 70796 70788 -8 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1652124 1652124 0 0.0
RAM 211632 211632 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1557884 1557900 16 0.0
RAM 208448 208456 8 0.0
light cy8ckit_062s2_43012 FLASH 1472492 1472492 0 0.0
RAM 200416 200424 8 0.0
lock cy8ckit_062s2_43012 FLASH 1470276 1470404 128 0.0
RAM 224768 224768 0 0.0
qpg lighting-app qpg6105+debug FLASH 664144 664152 8 0.0
RAM 105296 105296 0 0.0
lock-app qpg6105+debug FLASH 622004 621964 -40 -0.0
RAM 99748 99748 0 0.0
stm32 light STM32WB5MM-DK FLASH 484976 484984 8 0.0
RAM 144752 144752 0 0.0
telink bridge-app tlsr9258a FLASH 683552 683556 4 0.0
RAM 91088 91092 4 0.0
contact-sensor-app tlsr9528a_retention FLASH 623810 623704 -106 -0.0
RAM 31488 31492 4 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 772652 772656 4 0.0
RAM 49348 49352 4 0.0
light-app-ota-shell-factory-data tl7218x FLASH 777256 777260 4 0.0
RAM 99652 99656 4 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 711250 711190 -60 -0.0
RAM 73384 73384 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 628264 628268 4 0.0
RAM 142020 142024 4 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 814266 814270 4 0.0
RAM 99564 99568 4 0.0
tizen all-clusters-app arm unknown 5120 5120 0 0.0
FLASH 1767272 1767320 48 0.0
RAM 93708 93716 8 0.0
chip-tool-ubsan arm unknown 10904 10904 0 0.0
FLASH 17949774 17950070 296 0.0
RAM 7842672 7842840 168 0.0

@github-actions GitHub Actions
Copy link

PR #37062: Size comparison from 5bd63d5 to d422523

Full report (3 builds for cc32xx, stm32)
platform target config section 5bd63d5 d422523 change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 540041 540029 -12 -0.0
RAM 205304 205296 -8 -0.0
lock CC3235SF_LAUNCHXL FLASH 574209 574237 28 0.0
RAM 205448 205432 -16 -0.0
stm32 light STM32WB5MM-DK FLASH 484976 484984 8 0.0
RAM 144752 144752 0 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Jan 15, 2025
View reviewed changes
src/app/icd/server/BUILD.gn Outdated Show resolved Hide resolved
src/app/icd/server/BUILD.gn Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

PR #37062: Size comparison from 26a867c to d24a2cd

Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 26a867c d24a2cdd change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1094560 1094560 0 0.0
RAM 103346 103354 8 0.0
bl702 lighting-app bl702+eth FLASH 652366 652366 0 0.0
RAM 25353 25357 4 0.0
bl702+wifi FLASH 830546 830546 0 0.0
RAM 14093 14097 4 0.0
bl706+mfd+rpc+littlefs FLASH 1057832 1057832 0 0.0
RAM 23949 23949 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 890856 890802 -54 -0.0
RAM 18624 18628 4 0.0
lighting-app bl702l+mfd+littlefs FLASH 973816 973816 0 0.0
RAM 16472 16476 4 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 840084 840084 0 0.0
RAM 123536 123536 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 825600 825648 48 0.0
RAM 125424 125416 -8 -0.0
pump-app LP_EM_CC1354P10_6 FLASH 772528 772536 8 0.0
RAM 113900 113908 8 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 756724 756732 8 0.0
RAM 114100 114108 8 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 540021 540029 8 0.0
RAM 205288 205296 8 0.0
lock CC3235SF_LAUNCHXL FLASH 574189 574237 48 0.0
RAM 205432 205432 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 681569 681569 0 0.0
RAM 78596 78604 8 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 701413 701421 8 0.0
RAM 81236 81244 8 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 701413 701421 8 0.0
RAM 81236 81244 8 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 658357 658357 0 0.0
RAM 73664 73672 8 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 618153 618121 -32 -0.0
RAM 71588 71588 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 637789 637757 -32 -0.0
RAM 74132 74132 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 637789 637757 -32 -0.0
RAM 74132 74132 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 637601 637569 -32 -0.0
RAM 74596 74596 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 657317 657277 -40 -0.0
RAM 77140 77140 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 657317 657277 -40 -0.0
RAM 77140 77140 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614213 614133 -80 -0.0
RAM 68684 68692 8 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634065 633985 -80 -0.0
RAM 71316 71324 8 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634065 633985 -80 -0.0
RAM 71316 71324 8 0.0
efr32 lock-app BRD4187C FLASH 932644 932612 -32 -0.0
RAM 160068 160068 0 0.0
BRD4338a FLASH 749232 749272 40 0.0
RAM 233196 233196 0 0.0
window-app BRD4187C FLASH 1027040 1027104 64 0.0
RAM 128172 128172 0 0.0
esp32 all-clusters-app c3devkit DRAM 95192 95192 0 0.0
FLASH 1541904 1541904 0 0.0
IRAM 82552 82552 0 0.0
m5stack DRAM 116172 116172 0 0.0
FLASH 1548458 1548458 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4752 4752 0 0.0
FLASH 2722523 2722565 42 0.0
RAM 133096 133096 0 0.0
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 5996110 5996152 42 0.0
RAM 526008 526008 0 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5341296 5341338 42 0.0
RAM 243008 243008 0 0.0
bridge-app debug unknown 5472 5472 0 0.0
FLASH 4696450 4696492 42 0.0
RAM 221760 221760 0 0.0
chip-tool debug unknown 5984 5984 0 0.0
FLASH 12865776 12865816 40 0.0
RAM 586938 586938 0 0.0
chip-tool-ipv6only arm64 unknown 21536 21536 0 0.0
FLASH 10988368 10988368 0 0.0
RAM 637984 637984 0 0.0
fabric-admin debug unknown 5808 5808 0 0.0
FLASH 11273363 11273403 40 0.0
RAM 587282 587282 0 0.0
fabric-bridge-app debug unknown 4728 4728 0 0.0
FLASH 4521480 4521522 42 0.0
RAM 208880 208880 0 0.0
fabric-sync debug unknown 4968 4968 0 0.0
FLASH 5622085 5622117 32 0.0
RAM 477832 477832 0 0.0
lighting-app debug+rpc+ui unknown 6136 6136 0 0.0
FLASH 5630625 5630673 48 0.0
RAM 232008 232008 0 0.0
lock-app debug unknown 5408 5408 0 0.0
FLASH 4744212 4745272 1060 0.0
RAM 208008 208008 0 0.0
ota-provider-app debug unknown 4768 4768 0 0.0
FLASH 4371832 4371874 42 0.0
RAM 201696 201696 0 0.0
ota-requestor-app debug unknown 4720 4720 0 0.0
FLASH 4509844 4509886 42 0.0
RAM 206280 206280 0 0.0
shell debug unknown 4248 4248 0 0.0
FLASH 3022845 3022893 48 0.0
RAM 160736 160736 0 0.0
thermostat-no-ble arm64 unknown 9552 9552 0 0.0
FLASH 4109896 4109944 48 0.0
RAM 246328 246328 0 0.0
tv-app debug unknown 5736 5736 0 0.0
FLASH 5965749 5965797 48 0.0
RAM 601264 601264 0 0.0
tv-casting-app debug unknown 5312 5312 0 0.0
FLASH 11101645 11101677 32 0.0
RAM 700424 700424 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 917804 917808 4 0.0
RAM 143172 143176 4 0.0
nrf7002dk_nrf5340_cpuapp FLASH 890868 890868 0 0.0
RAM 141359 141363 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 851932 851936 4 0.0
RAM 142084 142088 4 0.0
nxp contact k32w0+release FLASH 585968 585920 -48 -0.0
RAM 70952 70960 8 0.0
mcxw71+release FLASH 601488 601448 -40 -0.0
RAM 63168 63176 8 0.0
light k32w0+release FLASH 612588 612604 16 0.0
RAM 70344 70352 8 0.0
k32w1+release FLASH 687152 687160 8 0.0
RAM 48760 48768 8 0.0
lock mcxw71+release FLASH 763464 763424 -40 -0.0
RAM 70796 70788 -8 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1652092 1652092 0 0.0
RAM 211624 211624 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1557860 1557876 16 0.0
RAM 208440 208448 8 0.0
light cy8ckit_062s2_43012 FLASH 1472460 1472460 0 0.0
RAM 200408 200416 8 0.0
lock cy8ckit_062s2_43012 FLASH 1470244 1470372 128 0.0
RAM 224760 224760 0 0.0
qpg lighting-app qpg6105+debug FLASH 664144 664152 8 0.0
RAM 105296 105296 0 0.0
lock-app qpg6105+debug FLASH 622004 621964 -40 -0.0
RAM 99748 99748 0 0.0
stm32 light STM32WB5MM-DK FLASH 484976 484984 8 0.0
RAM 144752 144752 0 0.0
telink bridge-app tlsr9258a FLASH 683552 683556 4 0.0
RAM 91088 91092 4 0.0
contact-sensor-app tlsr9528a_retention FLASH 623810 623704 -106 -0.0
RAM 31488 31492 4 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 772652 772656 4 0.0
RAM 49348 49352 4 0.0
light-app-ota-shell-factory-data tl7218x FLASH 777256 777260 4 0.0
RAM 99652 99656 4 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 711250 711190 -60 -0.0
RAM 73384 73384 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 628264 628268 4 0.0
RAM 142020 142024 4 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 814266 814270 4 0.0
RAM 99564 99568 4 0.0
tizen all-clusters-app arm unknown 5120 5120 0 0.0
FLASH 1766960 1767008 48 0.0
RAM 93672 93680 8 0.0
chip-tool-ubsan arm unknown 10904 10904 0 0.0
FLASH 17946038 17946334 296 0.0
RAM 7841372 7841540 168 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2025 •
edited
Loading

PR #37062: Size comparison from 26a867c to ab4aea1

Increases above 0.2%:

platform target config section 26a867c ab4aea1 change % change
efr32 lock-app BRD4187C FLASH 932644 936920 4276 0.5
window-app BRD4187C FLASH 1027040 1032696 5656 0.6
linux all-clusters-app debug RAM 526008 531832 5824 1.1
chip-tool debug FLASH 12865776 13046508 180732 1.4
RAM 586938 596634 9696 1.7
chip-tool-ipv6only arm64 unknown 21536 21816 280 1.3
FLASH 10988368 11126400 138032 1.3
RAM 637984 648168 10184 1.6
fabric-admin debug FLASH 11273363 11393483 120120 1.1
RAM 587282 596978 9696 1.7
fabric-sync debug RAM 477832 483656 5824 1.2
tv-app debug RAM 601264 607088 5824 1.0
tv-casting-app debug FLASH 11101645 11286125 184480 1.7
RAM 700424 711064 10640 1.5
tizen chip-tool-ubsan arm unknown 10904 11044 140 1.3
FLASH 17946038 18219230 273192 1.5
RAM 7841372 7959600 118228 1.5
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 26a867c ab4aea1 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1094560 1094560 0 0.0
RAM 103346 103354 8 0.0
bl702 lighting-app bl702+eth FLASH 652366 652366 0 0.0
RAM 25353 25357 4 0.0
bl702+wifi FLASH 830546 830546 0 0.0
RAM 14093 14097 4 0.0
bl706+mfd+rpc+littlefs FLASH 1057832 1057832 0 0.0
RAM 23949 23949 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 890856 890802 -54 -0.0
RAM 18624 18628 4 0.0
lighting-app bl702l+mfd+littlefs FLASH 973816 973816 0 0.0
RAM 16472 16476 4 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 840084 840084 0 0.0
RAM 123536 123536 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 825600 825648 48 0.0
RAM 125424 125416 -8 -0.0
pump-app LP_EM_CC1354P10_6 FLASH 772528 772536 8 0.0
RAM 113900 113908 8 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 756724 756732 8 0.0
RAM 114100 114108 8 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 540021 540029 8 0.0
RAM 205288 205296 8 0.0
lock CC3235SF_LAUNCHXL FLASH 574189 574237 48 0.0
RAM 205432 205432 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 681569 681569 0 0.0
RAM 78596 78604 8 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 701413 701421 8 0.0
RAM 81236 81244 8 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 701413 701421 8 0.0
RAM 81236 81244 8 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 658357 658357 0 0.0
RAM 73664 73672 8 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 618153 618121 -32 -0.0
RAM 71588 71588 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 637789 637757 -32 -0.0
RAM 74132 74132 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 637789 637757 -32 -0.0
RAM 74132 74132 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 637601 637569 -32 -0.0
RAM 74596 74596 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 657317 657277 -40 -0.0
RAM 77140 77140 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 657317 657277 -40 -0.0
RAM 77140 77140 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614213 614133 -80 -0.0
RAM 68684 68692 8 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634065 633985 -80 -0.0
RAM 71316 71324 8 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634065 633985 -80 -0.0
RAM 71316 71324 8 0.0
efr32 lock-app BRD4187C FLASH 932644 936920 4276 0.5
RAM 160068 160004 -64 -0.0
BRD4338a FLASH 749232 733340 -15892 -2.1
RAM 233196 218884 -14312 -6.1
window-app BRD4187C FLASH 1027040 1032696 5656 0.6
RAM 128172 128112 -60 -0.0
esp32 all-clusters-app c3devkit DRAM 95192 95192 0 0.0
FLASH 1541904 1541922 18 0.0
IRAM 82552 82552 0 0.0
m5stack DRAM 116172 116172 0 0.0
FLASH 1548458 1548454 -4 -0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4752 4752 0 0.0
FLASH 2722523 2722579 56 0.0
RAM 133096 133096 0 0.0
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 5996110 5997736 1626 0.0
RAM 526008 531832 5824 1.1
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5341296 5341352 56 0.0
RAM 243008 243008 0 0.0
bridge-app debug unknown 5472 5472 0 0.0
FLASH 4696450 4696508 58 0.0
RAM 221760 221760 0 0.0
chip-tool debug unknown 5984 5984 0 0.0
FLASH 12865776 13046508 180732 1.4
RAM 586938 596634 9696 1.7
chip-tool-ipv6only arm64 unknown 21536 21816 280 1.3
FLASH 10988368 11126400 138032 1.3
RAM 637984 648168 10184 1.6
fabric-admin debug unknown 5808 5808 0 0.0
FLASH 11273363 11393483 120120 1.1
RAM 587282 596978 9696 1.7
fabric-bridge-app debug unknown 4728 4728 0 0.0
FLASH 4521480 4521538 58 0.0
RAM 208880 208880 0 0.0
fabric-sync debug unknown 4968 4968 0 0.0
FLASH 5622085 5623845 1760 0.0
RAM 477832 483656 5824 1.2
lighting-app debug+rpc+ui unknown 6136 6136 0 0.0
FLASH 5630625 5630689 64 0.0
RAM 232008 232008 0 0.0
lock-app debug unknown 5408 5408 0 0.0
FLASH 4744212 4745288 1076 0.0
RAM 208008 208008 0 0.0
ota-provider-app debug unknown 4768 4768 0 0.0
FLASH 4371832 4371890 58 0.0
RAM 201696 201696 0 0.0
ota-requestor-app debug unknown 4720 4720 0 0.0
FLASH 4509844 4509902 58 0.0
RAM 206280 206280 0 0.0
shell debug unknown 4248 4248 0 0.0
FLASH 3022845 3022909 64 0.0
RAM 160736 160736 0 0.0
thermostat-no-ble arm64 unknown 9552 9552 0 0.0
FLASH 4109896 4109992 96 0.0
RAM 246328 246304 -24 -0.0
tv-app debug unknown 5736 5736 0 0.0
FLASH 5965749 5967381 1632 0.0
RAM 601264 607088 5824 1.0
tv-casting-app debug unknown 5312 5312 0 0.0
FLASH 11101645 11286125 184480 1.7
RAM 700424 711064 10640 1.5
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 917804 917808 4 0.0
RAM 143172 143176 4 0.0
nrf7002dk_nrf5340_cpuapp FLASH 890868 890868 0 0.0
RAM 141359 141363 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 851932 851936 4 0.0
RAM 142084 142088 4 0.0
nxp contact k32w0+release FLASH 585968 585920 -48 -0.0
RAM 70952 70960 8 0.0
mcxw71+release FLASH 601488 601448 -40 -0.0
RAM 63168 63176 8 0.0
light k32w0+release FLASH 612588 612604 16 0.0
RAM 70344 70352 8 0.0
k32w1+release FLASH 687152 687160 8 0.0
RAM 48760 48768 8 0.0
lock mcxw71+release FLASH 763464 763424 -40 -0.0
RAM 70796 70788 -8 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1652092 1652092 0 0.0
RAM 211624 211624 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1557860 1557876 16 0.0
RAM 208440 208448 8 0.0
light cy8ckit_062s2_43012 FLASH 1472460 1472460 0 0.0
RAM 200408 200416 8 0.0
lock cy8ckit_062s2_43012 FLASH 1470244 1470372 128 0.0
RAM 224760 224760 0 0.0
qpg lighting-app qpg6105+debug FLASH 664144 664152 8 0.0
RAM 105296 105296 0 0.0
lock-app qpg6105+debug FLASH 622004 621964 -40 -0.0
RAM 99748 99748 0 0.0
stm32 light STM32WB5MM-DK FLASH 484976 484984 8 0.0
RAM 144752 144752 0 0.0
telink bridge-app tlsr9258a FLASH 683552 683556 4 0.0
RAM 91088 91092 4 0.0
contact-sensor-app tlsr9528a_retention FLASH 623810 623704 -106 -0.0
RAM 31488 31492 4 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 772652 772656 4 0.0
RAM 49348 49352 4 0.0
light-app-ota-shell-factory-data tl7218x FLASH 777256 777260 4 0.0
RAM 99652 99656 4 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 711250 711190 -60 -0.0
RAM 73384 73384 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 628264 628268 4 0.0
RAM 142020 142024 4 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 814266 814270 4 0.0
RAM 99564 99568 4 0.0
tizen all-clusters-app arm unknown 5120 5120 0 0.0
FLASH 1766960 1767024 64 0.0
RAM 93672 93680 8 0.0
chip-tool-ubsan arm unknown 10904 11044 140 1.3
FLASH 17946038 18219230 273192 1.5
RAM 7841372 7959600 118228 1.5

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

PR #37062: Size comparison from 2d57f8c to c7d76fa

Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 2d57f8c c7d76fa change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1093164 1093164 0 0.0
RAM 103354 103362 8 0.0
bl702 lighting-app bl702+eth FLASH 651226 651226 0 0.0
RAM 25361 25365 4 0.0
bl702+wifi FLASH 829150 829150 0 0.0
RAM 14101 14105 4 0.0
bl706+mfd+rpc+littlefs FLASH 1056180 1056180 0 0.0
RAM 23957 23957 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 889204 889150 -54 -0.0
RAM 18632 18636 4 0.0
lighting-app bl702l+mfd+littlefs FLASH 972164 972164 0 0.0
RAM 16480 16484 4 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 838436 838436 0 0.0
RAM 123536 123536 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823784 823832 48 0.0
RAM 125416 125416 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 771104 771112 8 0.0
RAM 113900 113908 8 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 755300 755308 8 0.0
RAM 114100 114108 8 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538781 538789 8 0.0
RAM 205288 205296 8 0.0
lock CC3235SF_LAUNCHXL FLASH 572629 572677 48 0.0
RAM 205424 205432 8 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 679881 679889 8 0.0
RAM 78596 78604 8 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 699733 699733 0 0.0
RAM 81236 81244 8 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 699733 699733 0 0.0
RAM 81236 81244 8 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 656669 656677 8 0.0
RAM 73664 73672 8 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616289 616257 -32 -0.0
RAM 71588 71588 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635925 635893 -32 -0.0
RAM 74132 74132 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635925 635893 -32 -0.0
RAM 74132 74132 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635753 635721 -32 -0.0
RAM 74588 74596 8 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 655469 655429 -40 -0.0
RAM 77132 77140 8 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 655469 655429 -40 -0.0
RAM 77132 77140 8 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 612301 612229 -72 -0.0
RAM 68684 68692 8 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 632161 632089 -72 -0.0
RAM 71316 71324 8 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 632161 632089 -72 -0.0
RAM 71316 71324 8 0.0
efr32 lock-app BRD4187C FLASH 935112 935080 -32 -0.0
RAM 160004 160004 0 0.0
BRD4338a FLASH 730804 730844 40 0.0
RAM 234844 234844 0 0.0
window-app BRD4187C FLASH 1030456 1030520 64 0.0
RAM 128112 128112 0 0.0
esp32 all-clusters-app c3devkit DRAM 95192 95192 0 0.0
FLASH 1538592 1538592 0 0.0
IRAM 82552 82552 0 0.0
m5stack DRAM 116172 116172 0 0.0
FLASH 1545810 1545810 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4752 4752 0 0.0
FLASH 2710271 2710313 42 0.0
RAM 133096 133096 0 0.0
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 5976336 5976378 42 0.0
RAM 531880 531880 0 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5324354 5324396 42 0.0
RAM 242992 242992 0 0.0
bridge-app debug unknown 5472 5472 0 0.0
FLASH 4682582 4682624 42 0.0
RAM 221744 221744 0 0.0
chip-tool debug unknown 5984 5984 0 0.0
FLASH 13045234 13045274 40 0.0
RAM 596634 596634 0 0.0
chip-tool-ipv6only arm64 unknown 21816 21816 0 0.0
FLASH 11125744 11125760 16 0.0
RAM 648168 648168 0 0.0
fabric-admin debug unknown 5808 5808 0 0.0
FLASH 11392209 11392249 40 0.0
RAM 596978 596978 0 0.0
fabric-bridge-app debug unknown 4728 4728 0 0.0
FLASH 4507632 4507674 42 0.0
RAM 208880 208880 0 0.0
fabric-sync debug unknown 4968 4968 0 0.0
FLASH 5610437 5610469 32 0.0
RAM 483656 483656 0 0.0
lighting-app debug+rpc+ui unknown 6136 6136 0 0.0
FLASH 5617905 5617953 48 0.0
RAM 232008 232008 0 0.0
lock-app debug unknown 5408 5408 0 0.0
FLASH 4731538 4732582 1044 0.0
RAM 207976 207976 0 0.0
ota-provider-app debug unknown 4768 4768 0 0.0
FLASH 4361240 4361282 42 0.0
RAM 201696 201696 0 0.0
ota-requestor-app debug unknown 4720 4720 0 0.0
FLASH 4498914 4498956 42 0.0
RAM 206280 206280 0 0.0
shell debug unknown 4248 4248 0 0.0
FLASH 3006717 3006765 48 0.0
RAM 160736 160736 0 0.0
thermostat-no-ble arm64 unknown 9568 9568 0 0.0
FLASH 4102184 4102232 48 0.0
RAM 246224 246224 0 0.0
tv-app debug unknown 5736 5736 0 0.0
FLASH 5950597 5950645 48 0.0
RAM 607088 607088 0 0.0
tv-casting-app debug unknown 5312 5312 0 0.0
FLASH 11273069 11273101 32 0.0
RAM 711064 711064 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914768 914772 4 0.0
RAM 143172 143176 4 0.0
nrf7002dk_nrf5340_cpuapp FLASH 890116 890116 0 0.0
RAM 141359 141363 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 849488 849492 4 0.0
RAM 142084 142088 4 0.0
nxp contact k32w0+release FLASH 584504 584456 -48 -0.0
RAM 70952 70960 8 0.0
mcxw71+release FLASH 600024 600000 -24 -0.0
RAM 63168 63176 8 0.0
light k32w0+release FLASH 611188 611204 16 0.0
RAM 70344 70352 8 0.0
k32w1+release FLASH 685736 685744 8 0.0
RAM 48760 48768 8 0.0
lock mcxw71+release FLASH 761800 761776 -24 -0.0
RAM 70796 70788 -8 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1648060 1648060 0 0.0
RAM 211624 211624 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1554628 1554628 0 0.0
RAM 208440 208448 8 0.0
light cy8ckit_062s2_43012 FLASH 1470172 1470172 0 0.0
RAM 200408 200416 8 0.0
lock cy8ckit_062s2_43012 FLASH 1467884 1468028 144 0.0
RAM 224760 224760 0 0.0
qpg lighting-app qpg6105+debug FLASH 662552 662560 8 0.0
RAM 105296 105296 0 0.0
lock-app qpg6105+debug FLASH 620268 620228 -40 -0.0
RAM 99748 99748 0 0.0
stm32 light STM32WB5MM-DK FLASH 483240 483240 0 0.0
RAM 144752 144752 0 0.0
telink bridge-app tlsr9258a FLASH 682276 682280 4 0.0
RAM 91088 91092 4 0.0
contact-sensor-app tlsr9528a_retention FLASH 622566 622460 -106 -0.0
RAM 31488 31492 4 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 771344 771348 4 0.0
RAM 49348 49352 4 0.0
light-app-ota-shell-factory-data tl7218x FLASH 775948 775952 4 0.0
RAM 99652 99656 4 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709794 709734 -60 -0.0
RAM 73384 73384 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 626894 626898 4 0.0
RAM 142020 142024 4 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 812958 812962 4 0.0
RAM 99564 99568 4 0.0
tizen all-clusters-app arm unknown 5132 5132 0 0.0
FLASH 1755280 1755320 40 0.0
RAM 93672 93680 8 0.0
chip-tool-ubsan arm unknown 11044 11044 0 0.0
FLASH 18216638 18216926 288 0.0
RAM 7958464 7958632 168 0.0

@mergify mergify bot merged commit 594ffe2 into project-chip:master Jan 17, 2025
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

Assignees
No one assigned
Labels
app examples icd Intermittently Connected Devices review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wqx6 @andy31415 @bzbarsky-apple @restyled-commits