Reduce AddStatus calls for errors in IMCommandHandler code generation
#37110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #37110: Size comparison from 4fd7215 to 10813fd Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yufengwangca
approved these changes
Jan 17, 2025
|
PR #37110: Size comparison from 4fd7215 to f57cec6 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMCommandHandler has a AddStatus for every cluster implementation as well as a final one for invalid clusters. Instead we just need to know if a status needs to be set or not, so I changed the code to use an optional statuscode along with a single invocation of AddStatus.
I started out as
std::optional<status>however it turns out optional also has an overhad, so I moved it to haveSuccessmean no status needs to be added and anything else will be added. This should reduce flash overall and not add std::optional overhead at the expense of slight readability (success status is not added).Expectation is that this saves some Flash.
Testing
CI should validate this as this is generated code for applications