Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

controller/python: add device attestation revocation support #37134

Merged
merged 3 commits into from
Jan 30, 2025
Merged

controller/python: add device attestation revocation support #37134

merged 3 commits into from
Jan 30, 2025

Conversation

shubhamdp
Copy link
Contributor

@shubhamdp shubhamdp commented Jan 21, 2025 •
edited
Loading

  • Added the required changes in the python binding.
  • Added the cli option to matter testing framework for setting the dac revocation set path.
  • src/credentials: add an API to DeviceAttestationVerifier interface to set the revocation delegate

Testing

  • Manually tested by running TC_RR_1_1 and verified that commissioning stops with error "dac-revoked" in first case. And Test pass successfully when used without the arguments.
# Terminal 1
./out/host/chip-lighting-app --dac_provider credentials/test/revoked-attestation-certificates/dac-provider-test-vectors/revoked-pai.json

# Terminal 2
./scripts/build_python.sh --enable_ble true -i out/py-env

python3 src/python_testing/TC_RR_1_1.py -m on-network -p 20202021 -d 3840 --int-arg use_pase_only:0 --dac-revocation-set-path credentials/test/revoked-attestation-certificates/revocation-sets/revocation-set-for-paa.json

NOTE: Used the dac-provider-test-vectors from #37122

@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Jan 21, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  src/controller/python/chip/FabricAdmin.py  26% smaller
  src/python_testing/matter_testing_infrastructure/chip/testing/matter_testing.py  25% smaller
  src/controller/python/BUILD.gn Unsupported file format
  src/controller/python/OpCredsBinding.cpp Unsupported file format
  src/controller/python/chip/ChipDeviceCtrl.py  0% smaller
  src/credentials/attestation_verifier/DefaultDeviceAttestationVerifier.h Unsupported file format
  src/credentials/attestation_verifier/DeviceAttestationVerifier.h Unsupported file format

@shubhamdp shubhamdp mentioned this pull request Jan 21, 2025
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 21, 2025 •
edited
Loading

PR #37134: Size comparison from e6e9614 to df97121

Full report (56 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section e6e9614 df97121 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1092018 1092018 0 0.0
RAM 103258 103258 0 0.0
bl702 lighting-app bl702+eth FLASH 650236 650236 0 0.0
RAM 25265 25265 0 0.0
bl702+wifi FLASH 828106 828106 0 0.0
RAM 13981 13981 0 0.0
bl706+mfd+rpc+littlefs FLASH 1055136 1055136 0 0.0
RAM 23845 23845 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 888134 888134 0 0.0
RAM 18504 18504 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 971120 971120 0 0.0
RAM 16368 16368 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 838024 838024 0 0.0
RAM 123448 123448 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823452 823452 0 0.0
RAM 125320 125320 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770636 770636 0 0.0
RAM 113804 113804 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 754888 754888 0 0.0
RAM 114012 114012 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538433 538433 0 0.0
RAM 205192 205192 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572369 572369 0 0.0
RAM 205320 205320 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 679473 679473 0 0.0
RAM 78508 78508 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 699317 699317 0 0.0
RAM 81148 81148 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 699317 699317 0 0.0
RAM 81148 81148 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 656253 656253 0 0.0
RAM 73576 73576 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 615833 615833 0 0.0
RAM 71492 71492 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635461 635461 0 0.0
RAM 74036 74036 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635461 635461 0 0.0
RAM 74036 74036 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635329 635329 0 0.0
RAM 74500 74500 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 655045 655045 0 0.0
RAM 77044 77044 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 655045 655045 0 0.0
RAM 77044 77044 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 611773 611773 0 0.0
RAM 68588 68588 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631633 631633 0 0.0
RAM 71228 71228 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631633 631633 0 0.0
RAM 71228 71228 0 0.0
efr32 lock-app BRD4187C FLASH 934704 934704 0 0.0
RAM 159904 159904 0 0.0
BRD4338a FLASH 729580 729572 -8 -0.0
RAM 234748 234748 0 0.0
window-app BRD4187C FLASH 1029288 1029280 -8 -0.0
RAM 128008 128008 0 0.0
esp32 all-clusters-app c3devkit DRAM 95088 95088 0 0.0
FLASH 1536886 1536886 0 0.0
IRAM 82552 82552 0 0.0
m5stack DRAM 116076 116076 0 0.0
FLASH 1544970 1544970 0 0.0
IRAM 117039 117039 0 0.0
linux chip-tool-ipv6only arm64 unknown 21776 21776 0 0.0
FLASH 1112372 1112372 0 0.0
RAM 647920 647920 0 0.0
thermostat-no-ble arm64 unknown 9536 9536 0 0.0
FLASH 4098720 4098720 0 0.0
RAM 246064 246064 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 913664 913664 0 0.0
RAM 143148 143148 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 888544 888544 0 0.0
RAM 141335 141335 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 848552 848552 0 0.0
RAM 142060 142060 0 0.0
nxp contact k32w0+release FLASH 584288 584288 0 0.0
RAM 70860 70860 0 0.0
mcxw71+release FLASH 599632 599632 0 0.0
RAM 63080 63080 0 0.0
light k32w0+release FLASH 610716 610716 0 0.0
RAM 70252 70252 0 0.0
k32w1+release FLASH 685184 685184 0 0.0
RAM 48664 48664 0 0.0
lock mcxw71+release FLASH 761264 761264 0 0.0
RAM 70708 70708 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646340 1646340 0 0.0
RAM 211544 211544 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1552892 1552892 0 0.0
RAM 208352 208352 0 0.0
light cy8ckit_062s2_43012 FLASH 1468780 1468780 0 0.0
RAM 200328 200328 0 0.0
lock cy8ckit_062s2_43012 FLASH 1466828 1466828 0 0.0
RAM 224672 224672 0 0.0
qpg lighting-app qpg6105+debug FLASH 661992 661992 0 0.0
RAM 105204 105204 0 0.0
lock-app qpg6105+debug FLASH 619772 619772 0 0.0
RAM 99648 99648 0 0.0
stm32 light STM32WB5MM-DK FLASH 482648 482648 0 0.0
RAM 144656 144656 0 0.0
telink bridge-app tlsr9258a FLASH 681396 681396 0 0.0
RAM 91064 91064 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621608 621608 0 0.0
RAM 31464 31464 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 770454 770454 0 0.0
RAM 49324 49324 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 774872 774872 0 0.0
RAM 99628 99628 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 708782 708782 0 0.0
RAM 73356 73356 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625882 625882 0 0.0
RAM 141996 141996 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811932 811932 0 0.0
RAM 99540 99540 0 0.0
tizen all-clusters-app arm unknown 5112 5112 0 0.0
FLASH 1751184 1751184 0 0.0
RAM 93468 93468 0 0.0
chip-tool-ubsan arm unknown 11024 11024 0 0.0
FLASH 18213494 18213494 0 0.0
RAM 7955128 7955128 0 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 21, 2025 •
edited
Loading

PR #37134: Size comparison from e6e9614 to 5cf1981

Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section e6e9614 5cf1981 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1092018 1092018 0 0.0
RAM 103258 103258 0 0.0
bl702 lighting-app bl702+eth FLASH 650236 650236 0 0.0
RAM 25265 25265 0 0.0
bl702+wifi FLASH 828106 828106 0 0.0
RAM 13981 13981 0 0.0
bl706+mfd+rpc+littlefs FLASH 1055136 1055136 0 0.0
RAM 23845 23845 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 888134 888134 0 0.0
RAM 18504 18504 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 971120 971120 0 0.0
RAM 16368 16368 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 838024 838024 0 0.0
RAM 123448 123448 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823452 823452 0 0.0
RAM 125320 125320 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770636 770636 0 0.0
RAM 113804 113804 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 754888 754888 0 0.0
RAM 114012 114012 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538433 538433 0 0.0
RAM 205192 205192 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572369 572369 0 0.0
RAM 205320 205320 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 679473 679473 0 0.0
RAM 78508 78508 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 699317 699317 0 0.0
RAM 81148 81148 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 699317 699317 0 0.0
RAM 81148 81148 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 656253 656253 0 0.0
RAM 73576 73576 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 615833 615833 0 0.0
RAM 71492 71492 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635461 635461 0 0.0
RAM 74036 74036 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635461 635461 0 0.0
RAM 74036 74036 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635329 635329 0 0.0
RAM 74500 74500 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 655045 655045 0 0.0
RAM 77044 77044 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 655045 655045 0 0.0
RAM 77044 77044 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 611773 611773 0 0.0
RAM 68588 68588 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631633 631633 0 0.0
RAM 71228 71228 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631633 631633 0 0.0
RAM 71228 71228 0 0.0
efr32 lock-app BRD4187C FLASH 934704 934704 0 0.0
RAM 159904 159904 0 0.0
BRD4338a FLASH 729580 729572 -8 -0.0
RAM 234748 234748 0 0.0
window-app BRD4187C FLASH 1029288 1029280 -8 -0.0
RAM 128008 128008 0 0.0
esp32 all-clusters-app c3devkit DRAM 95088 95088 0 0.0
FLASH 1536886 1536886 0 0.0
IRAM 82552 82552 0 0.0
m5stack DRAM 116076 116076 0 0.0
FLASH 1544970 1544970 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4752 4752 0 0.0
FLASH 2708845 2708845 0 0.0
RAM 132800 132800 0 0.0
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 5974698 5974698 0 0.0
RAM 531520 531520 0 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5322484 5322484 0 0.0
RAM 242632 242632 0 0.0
bridge-app debug unknown 5472 5472 0 0.0
FLASH 4680640 4680640 0 0.0
RAM 221368 221368 0 0.0
chip-tool debug unknown 5984 5984 0 0.0
FLASH 13046528 13046528 0 0.0
RAM 596178 596178 0 0.0
chip-tool-ipv6only arm64 unknown 21776 21776 0 0.0
FLASH 1112372 1112372 0 0.0
RAM 647920 647920 0 0.0
fabric-admin debug unknown 5808 5808 0 0.0
FLASH 11393503 11393503 0 0.0
RAM 596522 596522 0 0.0
fabric-bridge-app debug unknown 4728 4728 0 0.0
FLASH 4506068 4506068 0 0.0
RAM 208552 208552 0 0.0
fabric-sync debug unknown 4968 4968 0 0.0
FLASH 5611141 5611141 0 0.0
RAM 483424 483424 0 0.0
lighting-app debug+rpc+ui unknown 6136 6136 0 0.0
FLASH 5615681 5615681 0 0.0
RAM 231648 231648 0 0.0
lock-app debug unknown 5408 5408 0 0.0
FLASH 4730586 4730586 0 0.0
RAM 207616 207616 0 0.0
ota-provider-app debug unknown 4768 4768 0 0.0
FLASH 4359432 4359432 0 0.0
RAM 201352 201352 0 0.0
ota-requestor-app debug unknown 4720 4720 0 0.0
FLASH 4496936 4496936 0 0.0
RAM 205936 205936 0 0.0
shell debug unknown 4248 4248 0 0.0
FLASH 3004781 3004781 0 0.0
RAM 160408 160408 0 0.0
thermostat-no-ble arm64 unknown 9536 9536 0 0.0
FLASH 4098720 4098720 0 0.0
RAM 246064 246064 0 0.0
tv-app debug unknown 5736 5736 0 0.0
FLASH 5951077 5951077 0 0.0
RAM 606824 606824 0 0.0
tv-casting-app debug unknown 5312 5312 0 0.0
FLASH 11271213 11271213 0 0.0
RAM 710736 710736 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 913664 913664 0 0.0
RAM 143148 143148 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 888544 888544 0 0.0
RAM 141335 141335 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 848552 848552 0 0.0
RAM 142060 142060 0 0.0
nxp contact k32w0+release FLASH 584288 584288 0 0.0
RAM 70860 70860 0 0.0
mcxw71+release FLASH 599632 599632 0 0.0
RAM 63080 63080 0 0.0
light k32w0+release FLASH 610716 610716 0 0.0
RAM 70252 70252 0 0.0
k32w1+release FLASH 685184 685184 0 0.0
RAM 48664 48664 0 0.0
lock mcxw71+release FLASH 761264 761264 0 0.0
RAM 70708 70708 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646340 1646340 0 0.0
RAM 211544 211544 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1552892 1552892 0 0.0
RAM 208352 208352 0 0.0
light cy8ckit_062s2_43012 FLASH 1468780 1468780 0 0.0
RAM 200328 200328 0 0.0
lock cy8ckit_062s2_43012 FLASH 1466828 1466828 0 0.0
RAM 224672 224672 0 0.0
qpg lighting-app qpg6105+debug FLASH 661992 661992 0 0.0
RAM 105204 105204 0 0.0
lock-app qpg6105+debug FLASH 619772 619772 0 0.0
RAM 99648 99648 0 0.0
stm32 light STM32WB5MM-DK FLASH 482648 482648 0 0.0
RAM 144656 144656 0 0.0
telink bridge-app tlsr9258a FLASH 681396 681396 0 0.0
RAM 91064 91064 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621608 621608 0 0.0
RAM 31464 31464 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 770454 770454 0 0.0
RAM 49324 49324 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 774872 774872 0 0.0
RAM 99628 99628 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 708782 708782 0 0.0
RAM 73356 73356 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625882 625882 0 0.0
RAM 141996 141996 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811932 811932 0 0.0
RAM 99540 99540 0 0.0
tizen all-clusters-app arm unknown 5112 5112 0 0.0
FLASH 1751184 1751184 0 0.0
RAM 93468 93468 0 0.0
chip-tool-ubsan arm unknown 11024 11024 0 0.0
FLASH 18213494 18213494 0 0.0
RAM 7955128 7955128 0 0.0

@shubhamdp shubhamdp marked this pull request as ready for review January 21, 2025 15:56
tehampson
tehampson previously approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@tehampson tehampson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional approval

src/controller/python/chip/ChipDeviceCtrl.py Outdated Show resolved Hide resolved
@shubhamdp shubhamdp force-pushed the dac-revocation-py-controller branch from 5cf1981 to ac35000 Compare January 27, 2025 11:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 27, 2025 •
edited
Loading

PR #37134: Size comparison from 22cd392 to 18b8b44

Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 22cd392 18b8b44 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1093530 1093530 0 0.0
RAM 103298 103298 0 0.0
bl702 lighting-app bl702+eth FLASH 650142 650142 0 0.0
RAM 25265 25265 0 0.0
bl702+wifi FLASH 828050 828050 0 0.0
RAM 13981 13981 0 0.0
bl706+mfd+rpc+littlefs FLASH 1056602 1056602 0 0.0
RAM 23861 23861 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 888036 888036 0 0.0
RAM 18504 18504 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 971022 971022 0 0.0
RAM 16368 16368 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 837944 837944 0 0.0
RAM 123464 123464 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823364 823364 0 0.0
RAM 125344 125344 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770580 770580 0 0.0
RAM 113804 113804 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 754824 754824 0 0.0
RAM 114012 114012 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538405 538405 0 0.0
RAM 205192 205192 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572269 572269 0 0.0
RAM 205344 205344 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 679353 679353 0 0.0
RAM 78532 78532 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 699205 699205 0 0.0
RAM 81172 81172 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 699205 699205 0 0.0
RAM 81172 81172 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 656133 656133 0 0.0
RAM 73600 73600 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 615737 615737 0 0.0
RAM 71516 71516 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635365 635365 0 0.0
RAM 74060 74060 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635365 635365 0 0.0
RAM 74060 74060 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635209 635209 0 0.0
RAM 74524 74524 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 654917 654917 0 0.0
RAM 77068 77068 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 654917 654917 0 0.0
RAM 77068 77068 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 611653 611653 0 0.0
RAM 68612 68612 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631513 631513 0 0.0
RAM 71252 71252 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631513 631513 0 0.0
RAM 71252 71252 0 0.0
efr32 lock-app BRD4187C FLASH 936168 936168 0 0.0
RAM 159904 159904 0 0.0
BRD4338a FLASH 729580 729572 -8 -0.0
RAM 234768 234768 0 0.0
window-app BRD4187C FLASH 1029128 1029120 -8 -0.0
RAM 128040 128040 0 0.0
esp32 all-clusters-app c3devkit DRAM 97296 97296 0 0.0
FLASH 1576974 1576974 0 0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 116092 116092 0 0.0
FLASH 1544918 1544918 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4760 4760 0 0.0
FLASH 2707793 2707793 0 0.0
RAM 132800 132800 0 0.0
all-clusters-app debug unknown 5568 5568 0 0.0
FLASH 5973848 5973848 0 0.0
RAM 531616 531616 0 0.0
all-clusters-minimal-app debug unknown 5464 5464 0 0.0
FLASH 5322534 5322534 0 0.0
RAM 242728 242728 0 0.0
bridge-app debug unknown 5480 5480 0 0.0
FLASH 4680722 4680722 0 0.0
RAM 221464 221464 0 0.0
chip-tool debug unknown 5984 5984 0 0.0
FLASH 13041760 13041760 0 0.0
RAM 596178 596178 0 0.0
chip-tool-ipv6only arm64 unknown 21776 21776 0 0.0
FLASH 11118640 11118640 0 0.0
RAM 647920 647920 0 0.0
fabric-admin debug unknown 5808 5808 0 0.0
FLASH 11387841 11387841 0 0.0
RAM 596522 596522 0 0.0
fabric-bridge-app debug unknown 4736 4736 0 0.0
FLASH 4505320 4505320 0 0.0
RAM 208648 208648 0 0.0
fabric-sync debug unknown 4976 4976 0 0.0
FLASH 5611557 5611557 0 0.0
RAM 483520 483520 0 0.0
lighting-app debug+rpc+ui unknown 6144 6144 0 0.0
FLASH 5623505 5623505 0 0.0
RAM 231744 231744 0 0.0
lock-app debug unknown 5416 5416 0 0.0
FLASH 4729772 4729772 0 0.0
RAM 207712 207712 0 0.0
ota-provider-app debug unknown 4776 4776 0 0.0
FLASH 4358348 4358348 0 0.0
RAM 201352 201352 0 0.0
ota-requestor-app debug unknown 4728 4728 0 0.0
FLASH 4495852 4495852 0 0.0
RAM 205936 205936 0 0.0
shell debug unknown 4256 4256 0 0.0
FLASH 3003933 3003933 0 0.0
RAM 160504 160504 0 0.0
thermostat-no-ble arm64 unknown 9536 9536 0 0.0
FLASH 4097952 4097952 0 0.0
RAM 246136 246136 0 0.0
tv-app debug unknown 5744 5744 0 0.0
FLASH 5951189 5951189 0 0.0
RAM 606920 606920 0 0.0
tv-casting-app debug unknown 5320 5320 0 0.0
FLASH 11268573 11268573 0 0.0
RAM 710864 710864 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 913600 913600 0 0.0
RAM 143168 143168 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 888464 888464 0 0.0
RAM 141355 141355 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 848640 848640 0 0.0
RAM 142080 142080 0 0.0
nxp contact k32w0+release FLASH 584240 584240 0 0.0
RAM 70860 70860 0 0.0
mcxw71+release FLASH 599568 599568 0 0.0
RAM 63080 63080 0 0.0
light k32w0+release FLASH 610668 610668 0 0.0
RAM 70252 70252 0 0.0
k32w1+release FLASH 685136 685136 0 0.0
RAM 48664 48664 0 0.0
lock mcxw71+release FLASH 748600 748600 0 0.0
RAM 67476 67476 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646260 1646260 0 0.0
RAM 211560 211560 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1553036 1553036 0 0.0
RAM 208376 208376 0 0.0
light cy8ckit_062s2_43012 FLASH 1468700 1468700 0 0.0
RAM 200352 200352 0 0.0
lock cy8ckit_062s2_43012 FLASH 1466748 1466748 0 0.0
RAM 224688 224688 0 0.0
qpg lighting-app qpg6105+debug FLASH 661928 661928 0 0.0
RAM 105204 105204 0 0.0
lock-app qpg6105+debug FLASH 619724 619724 0 0.0
RAM 99648 99648 0 0.0
stm32 light STM32WB5MM-DK FLASH 482552 482552 0 0.0
RAM 144672 144672 0 0.0
telink bridge-app tlsr9258a FLASH 681300 681300 0 0.0
RAM 91084 91084 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621330 621330 0 0.0
RAM 31484 31484 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 770184 770184 0 0.0
RAM 49344 49344 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 774600 774600 0 0.0
RAM 99648 99648 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 708502 708502 0 0.0
RAM 73376 73376 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625610 625610 0 0.0
RAM 142016 142016 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 812982 812982 0 0.0
RAM 99560 99560 0 0.0
tizen all-clusters-app arm unknown 5116 5116 0 0.0
FLASH 1751452 1751452 0 0.0
RAM 93524 93524 0 0.0
chip-tool-ubsan arm unknown 11024 11024 0 0.0
FLASH 18211390 18211390 0 0.0
RAM 7953724 7953724 0 0.0

@tehampson tehampson dismissed their stale review January 27, 2025 13:39

Other comments from other reviewers should be addressed

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2025 •
edited
Loading

PR #37134: Size comparison from 22cd392 to 2be5da2

Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 22cd392 2be5da2 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1093530 1093546 16 0.0
RAM 103298 103298 0 0.0
bl702 lighting-app bl702+eth FLASH 650142 650158 16 0.0
RAM 25265 25265 0 0.0
bl702+wifi FLASH 828050 828066 16 0.0
RAM 13981 13981 0 0.0
bl706+mfd+rpc+littlefs FLASH 1056602 1056618 16 0.0
RAM 23861 23861 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 888036 888052 16 0.0
RAM 18504 18504 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 971022 971038 16 0.0
RAM 16368 16368 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 837944 837952 8 0.0
RAM 123464 123464 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823364 823372 8 0.0
RAM 125344 125344 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770580 770596 16 0.0
RAM 113804 113804 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 754824 754840 16 0.0
RAM 114012 114012 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538405 538413 8 0.0
RAM 205192 205192 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572269 572277 8 0.0
RAM 205344 205344 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 679353 679361 8 0.0
RAM 78532 78532 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 699205 699213 8 0.0
RAM 81172 81172 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 699205 699213 8 0.0
RAM 81172 81172 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 656133 656149 16 0.0
RAM 73600 73600 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 615737 615745 8 0.0
RAM 71516 71516 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635365 635381 16 0.0
RAM 74060 74060 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635365 635381 16 0.0
RAM 74060 74060 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635209 635217 8 0.0
RAM 74524 74524 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 654917 654925 8 0.0
RAM 77068 77068 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 654917 654925 8 0.0
RAM 77068 77068 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 611653 611669 16 0.0
RAM 68612 68612 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631513 631529 16 0.0
RAM 71252 71252 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631513 631529 16 0.0
RAM 71252 71252 0 0.0
efr32 lock-app BRD4187C FLASH 936168 936200 32 0.0
RAM 159904 159904 0 0.0
BRD4338a FLASH 729580 729572 -8 -0.0
RAM 234768 234768 0 0.0
window-app BRD4187C FLASH 1029128 1029120 -8 -0.0
RAM 128040 128040 0 0.0
esp32 all-clusters-app c3devkit DRAM 97296 97296 0 0.0
FLASH 1576974 1576990 16 0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 116092 116092 0 0.0
FLASH 1544918 1544926 8 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4760 4760 0 0.0
FLASH 2707793 2707835 42 0.0
RAM 132800 132800 0 0.0
all-clusters-app debug unknown 5568 5568 0 0.0
FLASH 5973848 5973890 42 0.0
RAM 531616 531616 0 0.0
all-clusters-minimal-app debug unknown 5464 5464 0 0.0
FLASH 5322534 5322576 42 0.0
RAM 242728 242728 0 0.0
bridge-app debug unknown 5480 5480 0 0.0
FLASH 4680722 4680764 42 0.0
RAM 221464 221464 0 0.0
chip-tool debug unknown 5984 5984 0 0.0
FLASH 13041760 13041816 56 0.0
RAM 596178 596178 0 0.0
chip-tool-ipv6only arm64 unknown 21776 21776 0 0.0
FLASH 11118640 11118688 48 0.0
RAM 647920 647936 16 0.0
fabric-admin debug unknown 5808 5808 0 0.0
FLASH 11387841 11387897 56 0.0
RAM 596522 596522 0 0.0
fabric-bridge-app debug unknown 4736 4736 0 0.0
FLASH 4505320 4505362 42 0.0
RAM 208648 208648 0 0.0
fabric-sync debug unknown 4976 4976 0 0.0
FLASH 5611557 5611621 64 0.0
RAM 483520 483520 0 0.0
lighting-app debug+rpc+ui unknown 6144 6144 0 0.0
FLASH 5623505 5623521 16 0.0
RAM 231744 231744 0 0.0
lock-app debug unknown 5416 5416 0 0.0
FLASH 4729772 4729814 42 0.0
RAM 207712 207712 0 0.0
ota-provider-app debug unknown 4776 4776 0 0.0
FLASH 4358348 4358390 42 0.0
RAM 201352 201352 0 0.0
ota-requestor-app debug unknown 4728 4728 0 0.0
FLASH 4495852 4495894 42 0.0
RAM 205936 205936 0 0.0
shell debug unknown 4256 4256 0 0.0
FLASH 3003933 3003981 48 0.0
RAM 160504 160504 0 0.0
thermostat-no-ble arm64 unknown 9536 9536 0 0.0
FLASH 4097952 4097984 32 0.0
RAM 246136 246136 0 0.0
tv-app debug unknown 5744 5744 0 0.0
FLASH 5951189 5951253 64 0.0
RAM 606920 606920 0 0.0
tv-casting-app debug unknown 5320 5320 0 0.0
FLASH 11268573 11268621 48 0.0
RAM 710864 710864 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 913600 913616 16 0.0
RAM 143168 143168 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 888464 888468 4 0.0
RAM 141355 141355 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 848640 848644 4 0.0
RAM 142080 142080 0 0.0
nxp contact k32w0+release FLASH 584240 584240 0 0.0
RAM 70860 70860 0 0.0
mcxw71+release FLASH 599568 599584 16 0.0
RAM 63080 63080 0 0.0
light k32w0+release FLASH 610668 610684 16 0.0
RAM 70252 70252 0 0.0
k32w1+release FLASH 685136 685152 16 0.0
RAM 48664 48664 0 0.0
lock mcxw71+release FLASH 748600 748616 16 0.0
RAM 67476 67476 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646260 1646260 0 0.0
RAM 211560 211560 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1553036 1553036 0 0.0
RAM 208376 208376 0 0.0
light cy8ckit_062s2_43012 FLASH 1468700 1468716 16 0.0
RAM 200352 200352 0 0.0
lock cy8ckit_062s2_43012 FLASH 1466748 1466748 0 0.0
RAM 224688 224688 0 0.0
qpg lighting-app qpg6105+debug FLASH 661928 661944 16 0.0
RAM 105204 105204 0 0.0
lock-app qpg6105+debug FLASH 619724 619740 16 0.0
RAM 99648 99648 0 0.0
stm32 light STM32WB5MM-DK FLASH 482552 482568 16 0.0
RAM 144672 144672 0 0.0
telink bridge-app tlsr9258a FLASH 681300 681316 16 0.0
RAM 91084 91084 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621330 621348 18 0.0
RAM 31484 31484 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 770184 770186 2 0.0
RAM 49344 49344 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 774600 774616 16 0.0
RAM 99648 99648 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 708502 708520 18 0.0
RAM 73376 73376 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625610 625626 16 0.0
RAM 142016 142016 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 812982 812998 16 0.0
RAM 99560 99560 0 0.0
tizen all-clusters-app arm unknown 5116 5116 0 0.0
FLASH 1751452 1751476 24 0.0
RAM 93524 93524 0 0.0
chip-tool-ubsan arm unknown 11024 11024 0 0.0
FLASH 18211390 18211542 152 0.0
RAM 7953724 7953780 56 0.0

@shubhamdp
src/credentials: add an API to DeviceAttestationVerifier interface to
a7c8600 
set the revocation delegate
@shubhamdp
controller/python: add device attestation revocation support
3cc67f6 
- Added the cli option to matter testing framework for setting the dac
  revocation set path
- Added the required changes in the python bindings
- Added an API to the python controller to set the dac revocation set
  path.
@shubhamdp shubhamdp force-pushed the dac-revocation-py-controller branch from 2be5da2 to 3cc67f6 Compare January 29, 2025 07:01
@shubhamdp shubhamdp requested a review from tehampson January 29, 2025 07:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 29, 2025 •
edited
Loading

PR #37134: Size comparison from 6e8676b to 3cc67f6

Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink)
platform target config section 6e8676b 3cc67f6a change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1093546 1093546 0 0.0
RAM 103298 103298 0 0.0
bl702 lighting-app bl702+eth FLASH 650158 650158 0 0.0
RAM 25265 25265 0 0.0
bl702+wifi FLASH 828066 828066 0 0.0
RAM 13981 13981 0 0.0
bl706+mfd+rpc+littlefs FLASH 1056626 1056626 0 0.0
RAM 23861 23861 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 888060 888060 0 0.0
RAM 18504 18504 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 971046 971046 0 0.0
RAM 16368 16368 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 837968 837968 0 0.0
RAM 123464 123464 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823388 823388 0 0.0
RAM 125344 125344 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770612 770612 0 0.0
RAM 113804 113804 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 754856 754856 0 0.0
RAM 114012 114012 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538413 538413 0 0.0
RAM 205192 205192 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572277 572277 0 0.0
RAM 205344 205344 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 679377 679377 0 0.0
RAM 78532 78532 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 699229 699229 0 0.0
RAM 81172 81172 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 699229 699229 0 0.0
RAM 81172 81172 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 656157 656157 0 0.0
RAM 73600 73600 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 615761 615761 0 0.0
RAM 71516 71516 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635389 635389 0 0.0
RAM 74060 74060 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635389 635389 0 0.0
RAM 74060 74060 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635233 635233 0 0.0
RAM 74524 74524 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 654941 654941 0 0.0
RAM 77068 77068 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 654941 654941 0 0.0
RAM 77068 77068 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 611677 611677 0 0.0
RAM 68612 68612 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631537 631537 0 0.0
RAM 71252 71252 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631537 631537 0 0.0
RAM 71252 71252 0 0.0
efr32 lock-app BRD4187C FLASH 936200 936200 0 0.0
RAM 159904 159904 0 0.0
BRD4338a FLASH 729788 729780 -8 -0.0
RAM 234764 234764 0 0.0
window-app BRD4187C FLASH 1029128 1029120 -8 -0.0
RAM 128040 128040 0 0.0
esp32 all-clusters-app c3devkit DRAM 97296 97296 0 0.0
FLASH 1576990 1576990 0 0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 116092 116092 0 0.0
FLASH 1544926 1544926 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4760 4760 0 0.0
FLASH 2707835 2708055 220 0.0
RAM 132800 132816 16 0.0
all-clusters-app debug unknown 5568 5568 0 0.0
FLASH 5973890 5974078 188 0.0
RAM 531616 531632 16 0.0
all-clusters-minimal-app debug unknown 5464 5464 0 0.0
FLASH 5322576 5322764 188 0.0
RAM 242728 242744 16 0.0
bridge-app debug unknown 5480 5480 0 0.0
FLASH 4680764 4680952 188 0.0
RAM 221464 221480 16 0.0
chip-tool debug unknown 5984 5984 0 0.0
FLASH 13041802 13042096 294 0.0
RAM 596178 596202 24 0.0
chip-tool-ipv6only arm64 unknown 21776 21776 0 0.0
FLASH 11118672 11118896 224 0.0
RAM 647920 647944 24 0.0
fabric-admin debug unknown 5808 5808 0 0.0
FLASH 11387883 11388177 294 0.0
RAM 596522 596554 32 0.0
fabric-bridge-app debug unknown 4736 4736 0 0.0
FLASH 4505362 4505550 188 0.0
RAM 208648 208664 16 0.0
fabric-sync debug unknown 4976 4976 0 0.0
FLASH 5611605 5611925 320 0.0
RAM 483520 483536 16 0.0
lighting-app debug+rpc+ui unknown 6144 6144 0 0.0
FLASH 5623521 5623713 192 0.0
RAM 231744 231760 16 0.0
lock-app debug unknown 5416 5416 0 0.0
FLASH 4729814 4730066 252 0.0
RAM 207712 207728 16 0.0
ota-provider-app debug unknown 4776 4776 0 0.0
FLASH 4358390 4358610 220 0.0
RAM 201352 201368 16 0.0
ota-requestor-app debug unknown 4728 4728 0 0.0
FLASH 4495894 4496082 188 0.0
RAM 205936 205952 16 0.0
shell debug unknown 4256 4256 0 0.0
FLASH 3003981 3003981 0 0.0
RAM 160504 160504 0 0.0
thermostat-no-ble arm64 unknown 9536 9536 0 0.0
FLASH 4097984 4098048 64 0.0
RAM 246136 246144 8 0.0
tv-app debug unknown 5744 5744 0 0.0
FLASH 5951237 5951525 288 0.0
RAM 606920 606936 16 0.0
tv-casting-app debug unknown 5320 5320 0 0.0
FLASH 11268605 11268877 272 0.0
RAM 710864 710896 32 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 907060 907060 0 0.0
RAM 142395 142395 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 901600 901600 0 0.0
RAM 124739 124739 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 845788 845788 0 0.0
RAM 141323 141323 0 0.0
nxp contact k32w0+release FLASH 584256 584256 0 0.0
RAM 70860 70860 0 0.0
mcxw71+release FLASH 599600 599600 0 0.0
RAM 63080 63080 0 0.0
light k32w0+release FLASH 610684 610684 0 0.0
RAM 70252 70252 0 0.0
k32w1+release FLASH 685160 685160 0 0.0
RAM 48664 48664 0 0.0
lock mcxw71+release FLASH 748632 748632 0 0.0
RAM 67476 67476 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646260 1646260 0 0.0
RAM 211560 211560 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1553036 1553036 0 0.0
RAM 208376 208376 0 0.0
light cy8ckit_062s2_43012 FLASH 1468716 1468716 0 0.0
RAM 200352 200352 0 0.0
lock cy8ckit_062s2_43012 FLASH 1466748 1466748 0 0.0
RAM 224688 224688 0 0.0
qpg lighting-app qpg6105+debug FLASH 661952 661952 0 0.0
RAM 105204 105204 0 0.0
lock-app qpg6105+debug FLASH 619756 619756 0 0.0
RAM 99648 99648 0 0.0
stm32 light STM32WB5MM-DK FLASH 482568 482568 0 0.0
RAM 144672 144672 0 0.0
telink bridge-app tlsr9258a FLASH 681324 681324 0 0.0
RAM 91084 91084 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621354 621354 0 0.0
RAM 31484 31484 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 770194 770194 0 0.0
RAM 49344 49344 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 774624 774624 0 0.0
RAM 99648 99648 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 708528 708528 0 0.0
RAM 73376 73376 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625626 625626 0 0.0
RAM 142016 142016 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 813006 813006 0 0.0
RAM 99560 99560 0 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2025 •
edited
Loading

PR #37134: Size comparison from 6e8676b to f2459a5

Increases above 0.2%:

platform target config section 6e8676b f2459a5 change % change
linux chip-tool debug unknown 5984 6120 136 2.3
FLASH 13041802 13096130 54328 0.4
chip-tool-ipv6only arm64 unknown 21776 21848 72 0.3
FLASH 11118672 1116208 43408 0.4
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink)
platform target config section 6e8676b f2459a5 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1093546 1093546 0 0.0
RAM 103298 103298 0 0.0
bl702 lighting-app bl702+eth FLASH 650158 650158 0 0.0
RAM 25265 25265 0 0.0
bl702+wifi FLASH 828066 828066 0 0.0
RAM 13981 13981 0 0.0
bl706+mfd+rpc+littlefs FLASH 1056626 1056626 0 0.0
RAM 23861 23861 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 888060 888060 0 0.0
RAM 18504 18504 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 971046 971046 0 0.0
RAM 16368 16368 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 837968 838000 32 0.0
RAM 123464 123464 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823388 823420 32 0.0
RAM 125344 125344 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770612 770644 32 0.0
RAM 113804 113804 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 754856 754888 32 0.0
RAM 114012 114012 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538413 538445 32 0.0
RAM 205192 205192 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572277 572309 32 0.0
RAM 205344 205344 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 679377 679409 32 0.0
RAM 78532 78532 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 699229 699261 32 0.0
RAM 81172 81172 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 699229 699261 32 0.0
RAM 81172 81172 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 656157 656189 32 0.0
RAM 73600 73600 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 615761 615793 32 0.0
RAM 71516 71516 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635389 635421 32 0.0
RAM 74060 74060 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635389 635421 32 0.0
RAM 74060 74060 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635233 635273 40 0.0
RAM 74524 74524 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 654941 654981 40 0.0
RAM 77068 77068 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 654941 654981 40 0.0
RAM 77068 77068 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 611677 611709 32 0.0
RAM 68612 68612 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631537 631569 32 0.0
RAM 71252 71252 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631537 631569 32 0.0
RAM 71252 71252 0 0.0
efr32 lock-app BRD4187C FLASH 936200 936232 32 0.0
RAM 159904 159904 0 0.0
BRD4338a FLASH 729788 729892 104 0.0
RAM 234764 234764 0 0.0
window-app BRD4187C FLASH 1029128 1029248 120 0.0
RAM 128040 128040 0 0.0
esp32 all-clusters-app c3devkit DRAM 97296 97296 0 0.0
FLASH 1576990 1577036 46 0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 116092 116092 0 0.0
FLASH 1544926 1544978 52 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4760 4760 0 0.0
FLASH 2707835 2708921 1086 0.0
RAM 132800 132816 16 0.0
all-clusters-app debug unknown 5568 5568 0 0.0
FLASH 5973890 5974944 1054 0.0
RAM 531616 531632 16 0.0
all-clusters-minimal-app debug unknown 5464 5464 0 0.0
FLASH 5322576 5323630 1054 0.0
RAM 242728 242744 16 0.0
bridge-app debug unknown 5480 5480 0 0.0
FLASH 4680764 4681818 1054 0.0
RAM 221464 221480 16 0.0
chip-tool debug unknown 5984 6120 136 2.3
FLASH 13041802 13096130 54328 0.4
RAM 596178 596770 592 0.1
chip-tool-ipv6only arm64 unknown 21776 21848 72 0.3
FLASH 11118672 1116208 43408 0.4
RAM 647920 648496 576 0.1
fabric-admin debug unknown 5808 5808 0 0.0
FLASH 11387883 11388177 294 0.0
RAM 596522 596554 32 0.0
fabric-bridge-app debug unknown 4736 4736 0 0.0
FLASH 4505362 4506416 1054 0.0
RAM 208648 208664 16 0.0
fabric-sync debug unknown 4976 4976 0 0.0
FLASH 5611605 5612789 1184 0.0
RAM 483520 483536 16 0.0
lighting-app debug+rpc+ui unknown 6144 6144 0 0.0
FLASH 5623521 5624577 1056 0.0
RAM 231744 231760 16 0.0
lock-app debug unknown 5416 5416 0 0.0
FLASH 4729814 4730932 1118 0.0
RAM 207712 207728 16 0.0
ota-provider-app debug unknown 4776 4776 0 0.0
FLASH 4358390 4359476 1086 0.0
RAM 201352 201368 16 0.0
ota-requestor-app debug unknown 4728 4728 0 0.0
FLASH 4495894 4496948 1054 0.0
RAM 205936 205952 16 0.0
shell debug unknown 4256 4256 0 0.0
FLASH 3003981 3004845 864 0.0
RAM 160504 160504 0 0.0
thermostat-no-ble arm64 unknown 9536 9536 0 0.0
FLASH 4097984 4098704 720 0.0
RAM 246136 246144 8 0.0
tv-app debug unknown 5744 5744 0 0.0
FLASH 5951237 5952389 1152 0.0
RAM 606920 606936 16 0.0
tv-casting-app debug unknown 5320 5320 0 0.0
FLASH 11268605 11269741 1136 0.0
RAM 710864 710896 32 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 907060 906972 -88 -0.0
RAM 142395 142395 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 901600 901532 -68 -0.0
RAM 124739 124739 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 845788 845696 -92 -0.0
RAM 141323 141323 0 0.0
nxp contact k32w0+release FLASH 584256 584288 32 0.0
RAM 70860 70860 0 0.0
mcxw71+release FLASH 599600 599632 32 0.0
RAM 63080 63080 0 0.0
light k32w0+release FLASH 610684 610732 48 0.0
RAM 70252 70252 0 0.0
k32w1+release FLASH 685160 685192 32 0.0
RAM 48664 48664 0 0.0
lock mcxw71+release FLASH 748632 748664 32 0.0
RAM 67476 67476 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646260 1646372 112 0.0
RAM 211560 211560 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1553036 1553148 112 0.0
RAM 208376 208376 0 0.0
light cy8ckit_062s2_43012 FLASH 1468716 1468828 112 0.0
RAM 200352 200352 0 0.0
lock cy8ckit_062s2_43012 FLASH 1466748 1466860 112 0.0
RAM 224688 224688 0 0.0
qpg lighting-app qpg6105+debug FLASH 661952 661984 32 0.0
RAM 105204 105204 0 0.0
lock-app qpg6105+debug FLASH 619756 619788 32 0.0
RAM 99648 99648 0 0.0
stm32 light STM32WB5MM-DK FLASH 482568 482600 32 0.0
RAM 144672 144672 0 0.0
telink bridge-app tlsr9258a FLASH 681324 681290 -34 -0.0
RAM 91084 91084 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621354 621322 -32 -0.0
RAM 31484 31484 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 770194 770160 -34 -0.0
RAM 49344 49344 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 774624 774590 -34 -0.0
RAM 99648 99648 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 708528 708494 -34 -0.0
RAM 73376 73376 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625626 625592 -34 -0.0
RAM 142016 142016 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 813006 812972 -34 -0.0
RAM 99560 99560 0 0.0

@mergify mergify bot merged commit 8be890b into project-chip:master Jan 30, 2025
69 checks passed
@shubhamdp shubhamdp deleted the dac-revocation-py-controller branch January 30, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkq arkq arkq left review comments

@joonhaengHeo joonhaengHeo joonhaengHeo approved these changes

@tehampson tehampson tehampson approved these changes

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@cecille cecille Awaiting requested review from cecille

Assignees
No one assigned
Labels
controller review - approved tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shubhamdp @tcarmelveilleux @arkq @cecille @tehampson @joonhaengHeo