PASE Commissioner #982
Merged
PASE Commissioner #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance the "doOperationalDeviceConnection" callback with the option to notify the commissioner that the completion of the commissioning process was done via other ways (e.g. from a server differently from the commissioner instance).
The commisioning options got an optional callback to allow custom commissioning completion ways. Additionally streamline the interface (breaking) to allow just to commission to a device without a connection afterwards.
And allow the class to be initialized with data and without storage too.
... but the standard "create" is still requiring it, so external interface stays unchanged
... because makes no sense for now.
This class is a minimalistic commissioning controller that allows to just execute the initial commissioning process without completion. For this it gets initialized with the Root certificate data and the fabric data from a Controller fabric that already exists. A callback is called when operational discovery and completing the commissioning is needed.
lauckhart
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a PASE Commissionier which allows to execute "just" the initial commissioning par e.g, in a react-native environment and have the commissioning completion done separately.
For this it adjusts MatterController internal class to be more flexible and make sure via factory methods that the right data are provided depending on the use case.
It also allows to initialize the Root Certificate manager with a defined certificate without loading from storage.
See commits and changelog.
This code will be tested with building a BLE commissioner in React native, for this marked as "experimental" for now.