Experimental AsyncStorage support for react-native #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use @react-native-async-storage/async-storage to implement an AsyncStorage based storage.
|
Very strange is that - most likely because of a double default export - the types for AsyncStorage tell that it only exists under AsyncStorage.default. That way it is building but I have big doubts if it will be working tbh. |
|
Ok, adjusted now to "without .default" because I assume it is just type issue ... see also https://react-native-async-storage.github.io/async-storage/docs/usage ... so we ignore the errors |
lauckhart
approved these changes
Jul 1, 2024
packages/matter.js-react-native/src/storage/StorageBackendAsyncStorage.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use @react-native-async-storage/async-storage to implement an AsyncStorage based storage.
The whole react-native part is experimental and will be verified by building a react-native app in the next weeks. AFter this we can mark it as stable.
@foxriver76 - please feel free to also review or comment