Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set warnings for enabled Matter commands with disabled response command #1536

Merged
merged 5 commits into from
Mar 27, 2025

Conversation

ethanzhouyc
Copy link
Collaborator

@ethanzhouyc ethanzhouyc commented Mar 6, 2025

  • Added a SQL trigger to generate warnings in the notification system when the response command of any enabled Matter command is disabled.
  • Set missing response command warnings on ZAP file import and log these warnings to the console
  • Implemented a SQL DELETE trigger to remove all related warnings from the notification table when an endpoint is deleted.
  • Added unit tests to cover all the above features.
  • Updated outdated .zap and xml files to prevent incorrect warnings from being triggered by the new feature.
  • Wrote a function to optimize code for getting notification messages in unit tests.

Related Issue: #1165
JIRA: GHM_ZAP-83

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.93%. Comparing base (218bd93) to head (f8e8815).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1536      +/-   ##
==========================================
+ Coverage   66.89%   66.93%   +0.03%     
==========================================
  Files         194      194              
  Lines       21760    21786      +26     
  Branches     4803     4805       +2     
==========================================
+ Hits        14557    14583      +26     
  Misses       7203     7203              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ethanzhouyc
Copy link
Collaborator Author

Example of command response warning for the PayloadTestRequest command
image

@ethanzhouyc ethanzhouyc requested a review from andy31415 March 13, 2025 16:01
@ethanzhouyc ethanzhouyc merged commit b14541b into project-chip:master Mar 27, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants