Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for environment variables for Training images #80

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

ChughShilpa
Copy link
Contributor

@ChughShilpa ChughShilpa commented Nov 21, 2024

Issue link

This issue is related to RHOAIENG-16035

What changes have been made

Add support for environment variables for Training images. This change helps in

  • Providing default value of images
  • consistency with the pattern for all other images
  • providing one common variable for all Training images

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • [] Testing is not required for this change

Copy link
Collaborator

@Fiona-Waters Fiona-Waters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Fiona-Waters
Copy link
Collaborator

/approve

Copy link

openshift-ci bot commented Nov 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChughShilpa, Fiona-Waters

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e99e941 into project-codeflare:main Nov 21, 2024
3 checks passed
@ChughShilpa ChughShilpa deleted the KFTO_images branch November 21, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants