perf: add liveness and readiness probes to deployments #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimakis
force-pushed
the
add-liveness-and-readiness-probes-insta
branch
2 times, most recently
from
67d3d09
to
555c512
Compare
astefanutti
reviewed
Jun 26, 2023
dimakis
force-pushed
the
add-liveness-and-readiness-probes-insta
branch
2 times, most recently
from
4e9a620
to
52b16e8
Compare
dimakis
force-pushed
the
add-liveness-and-readiness-probes-insta
branch
2 times, most recently
from
9362b46
to
0d28729
Compare
astefanutti
approved these changes
Jun 27, 2023
|
@anishasthana @KPostOffice can one of ye give me a lgtm here so I can merge please? |
|
kind bump to review this PR :) |
|
do we know what is pending for getting this PR merged? |
|
@KPostOffice sorry to poke again, but can you approve this? |
|
Can we please make sure we have manually tested this PR? |
|
@dimakis do we know what is pending on this PR? |
dimakis
force-pushed
the
add-liveness-and-readiness-probes-insta
branch
from
22acb43
to
db3b69e
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linked here in the codeflare operator