-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add plugin docs #360
Conversation
Signed-off-by: Sertac Ozercan <[email protected]>
Signed-off-by: Sertac Ozercan <[email protected]>
Signed-off-by: Sertac Ozercan <[email protected]>
website/docs/scanner-plugins.md
Outdated
# Community Scanner Plugins | ||
|
||
If you have built a scanner plugin and would like to add it to this list, please submit a PR to update this section with your plugin. | ||
|
||
:::tip | ||
|
||
If you have any issues with a specific plugin, please open an issue in the applicable plugin's repository. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could add anubhav06/copa-grype to the list,
or I can open a PR to add it once this merges
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added, thank you!
Signed-off-by: Sertac Ozercan <[email protected]>
/hold |
```golang | ||
type UpdateManifest struct { | ||
// API version of the interface (e.g. v1alpha1) | ||
APIVersion string `json:"apiVersion"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add some verbiage about versioning, backward compatibility policy, etc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a note, let me know if you are looking for any specifics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
// Metadata contains information about the OS and config | ||
type Metadata struct { | ||
OS OS `json:"os"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does copa validate against a supported list of OS and Arch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or do the non-supported ones just get skipped?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for OS, yes it'll validate and fail fast if it's not supported
for Arch, it's used for pulling the arch-specific image and vex output
Signed-off-by: Sertac Ozercan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Describe the changes in this pull request using active verbs such as Add, Remove, Replace ...
Closes #352