Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resulve issue #224 GetRef() in support package should remove 'vendor'… #225

Closed
wants to merge 12 commits into from
Closed

Resulve issue #224 GetRef() in support package should remove 'vendor'… #225

wants to merge 12 commits into from

Conversation

yxuco
Copy link
Contributor

@yxuco yxuco commented Oct 8, 2020

… path

What kind of change does this PR introduce? (check one with "x")

[X] Bugfix
[] Feature
[] Code style update (formatting, local variables)
[] Refactoring (no functional changes, no api changes)
[] Other... Please describe:

Fixes: #224

What is the current behavior?
When used with vendor packages, it returns ref with prefix of vendor path.

What is the new behavior?
It now returns only the ref, without the prefix of vendor path.

lixingwang
lixingwang approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@lixingwang lixingwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@lixingwang
Copy link
Contributor

lixingwang commented Oct 16, 2020 •
edited
Loading

@mellistibco Please also approve. thanks

lixingwang and others added 11 commits October 27, 2020 20:08
@lixingwang
1. convert object, param and array from []bytes avoid unnecessary con…
d02ea62 
…version (project-flogo#228)

2. Avoid to create duplicate scope
@vijaynalawade
Engine flow control support (project-flogo#227)
8202430 
* Initial implementation of flow controller

* Added FlowControlAware interface for triggers. Triggers implementing that inteface can be paused/resumed by the engine.

* changes based on reviews
@lixingwang
Fix project-flogo#231 to report clearly error message when connection…
1ae0cf5 
… not imported (project-flogo#232)
@lixingwang
support index variable in array mapper (project-flogo#233)
d9fd6d5
@lixingwang
support function in array mapping for source and filter arguments (pr…
404bfad 
…oject-flogo#235)
@vijaynalawade
Flow control fixes (project-flogo#236)
e590c9e 
* Initial implementation of flow controller

* Added FlowControlAware interface for triggers. Triggers implementing that inteface can be paused/resumed by the engine.

* changes based on reviews

* Addressing missed fixes
@awakchau-tibco
added Lambda as a carrier format for xray tracing (project-flogo#239)
95b8f77
@lixingwang
Fix project-flogo#237 to delete data from app data (project-flogo#238)
095cdc1
@lixingwang
App controller interface optimizing (project-flogo#240)
d0ed3d0
@yxuco
Resulve issue project-flogo#224 GetRef() in support package should re…
41e5656 
…move 'vendor' path

allows trigger developer to pass request parameters to handler w/o going through output mapper
@yxuco
Merge branch 'master' of github.com:yxuco/core
707a6c2
@yxuco yxuco closed this Dec 10, 2020
@yxuco yxuco reopened this Dec 10, 2020
@lixingwang
Copy link
Contributor

lixingwang commented Dec 10, 2020 •
edited
Loading

@yxuco Could you please sync your forked repo to the latest master? to make sure this PR has the latest master in

@yxuco yxuco closed this Dec 10, 2020
@yxuco yxuco mentioned this pull request Dec 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mellistibco mellistibco mellistibco approved these changes

@lixingwang lixingwang lixingwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yxuco @lixingwang @mellistibco @vijaynalawade @awakchau-tibco