Wrong line numbers on CPU64 #76
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I did few tests on small projects and quite big ones including reccursion and noticed, that line numbers're calculated with offset = 2. And it seems to me, that this is a constant value. And tests prove that. Actually I don't have enougth experience to find better solution, but I suppose, you do. This error could lead into more complicated errors, because .CallerAddr is used widely. I'dont think, that mistake is located inside CaptureStackBackTrace(internal RtlCaptureStackBackTrace). It's also could be an Embarcadero bug dcc64 but, as far as I know, it's written completele from zero.
|
What about FPC? Is this the same for that as well? Has any attempt been made to clarify whether the issues comes from a EMBT DCC64 bug or from JCL itsself? |
|
@keksoid have you already looked into quality.embarcadero.com to check if this is actually a DCC64 bug which is already known? Would you please do that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did few tests on small projects and quite big ones including reccursion and noticed, that line numbers're calculated with offset = 2. And it seems to me, that this is a constant value. And tests prove that. Actually I don't have enough experience to find better solution, but I suppose, you do. This error could lead into more complicated errors, because .CallerAddr is used widely. I'dont think, that mistake is located inside CaptureStackBackTrace(internal RtlCaptureStackBackTrace). It's also could be an Embarcadero bug dcc64 but, as far as I know, it's written completely from zero.