Merge pull request #4056 from dlabrecq/placeholder

Missing filter placeholder for EC2 instance and OS
project-koku · Oct 7, 2024 · f04bf7f · f04bf7f
2 parents 44b5f80 + 5f1916b
commit f04bf7f
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/locales/data.json b/locales/data.json
@@ -7746,6 +7746,14 @@
               }
             ]
           },
+          "instance": {
+            "value": [
+              {
+                "type": 0,
+                "value": "Filter by instance"
+              }
+            ]
+          },
           "name": {
             "value": [
               {
@@ -7762,6 +7770,14 @@
               }
             ]
           },
+          "operating_system": {
+            "value": [
+              {
+                "type": 0,
+                "value": "Filter by operating system"
+              }
+            ]
+          },
           "org_unit_id": {
             "value": [
               {

diff --git a/locales/translations.json b/locales/translations.json
@@ -327,7 +327,7 @@
   "filterByInputAriaLabel": "{value, select, account {Input for account name} aws_category {Input for cost category name} cluster {Input for cluster name} gcp_project {Input for GCP project name} name {Input for name} node {Input for node name} org_unit_id {Input for organizational unit name} payer_tenant_id {Input for account name} product_service {Input for service_name} project {Input for project name} region {Input for region name} resource_location {Input for region name} service {Input for service name} service_name {Input for service_name} subscription_guid {Input for account name} status {Input for status value} tag {Input for tag name} tag_key {Input for tag key} tag_key_child {Input for child tag key} tag_key_parent {Input for parent tag key} other {}}",
   "filterByOrgUnitAriaLabel": "Organizational units",
   "filterByOrgUnitPlaceholder": "Choose unit",
-  "filterByPlaceholder": "{value, select, account {Filter by account} aws_category {Filter by cost category} cluster {Filter by cluster} container {Filter by container} description {Filter by description} gcp_project {Filter by GCP project} group {Filter by group} name {Filter by name} node {Filter by node} org_unit_id {Filter by organizational unit} payer_tenant_id {Filter by account} persistent_volume_claim {Filter by persistent volume claim} product_service {Filter by service} project {Filter by project} region {Filter by region} resource_location {Filter by region} service {Filter by service} service_name {Filter by service} source_type {Filter by integration} status {Filter by status} storage_class {Filter by StorageClass} subscription_guid {Filter by account} workload {Filter by workload name} workload_type {Filter by workload type} tag {Filter by tag} tag_key {Filter by tag key} tag_key_child {Filter by child tag key} tag_key_parent {Filter by parent tag key} other {}}",
+  "filterByPlaceholder": "{value, select, account {Filter by account} aws_category {Filter by cost category} cluster {Filter by cluster} container {Filter by container} description {Filter by description} gcp_project {Filter by GCP project} group {Filter by group} instance {Filter by instance} name {Filter by name} node {Filter by node} operating_system {Filter by operating system} org_unit_id {Filter by organizational unit} payer_tenant_id {Filter by account} persistent_volume_claim {Filter by persistent volume claim} product_service {Filter by service} project {Filter by project} region {Filter by region} resource_location {Filter by region} service {Filter by service} service_name {Filter by service} source_type {Filter by integration} status {Filter by status} storage_class {Filter by StorageClass} subscription_guid {Filter by account} workload {Filter by workload name} workload_type {Filter by workload type} tag {Filter by tag} tag_key {Filter by tag key} tag_key_child {Filter by child tag key} tag_key_parent {Filter by parent tag key} other {}}",
   "filterByTagKeyAriaLabel": "Tag keys",
   "filterByTagValueAriaLabel": "Tag values",
   "filterByTagValueButtonAriaLabel": "Filter button for tag value",

diff --git a/src/locales/messages.ts b/src/locales/messages.ts
@@ -2028,8 +2028,10 @@ export default defineMessages({
       'description {Filter by description} ' +
       'gcp_project {Filter by GCP project} ' +
       'group {Filter by group} ' +
+      'instance {Filter by instance} ' +
       'name {Filter by name} ' +
       'node {Filter by node} ' +
+      'operating_system {Filter by operating system} ' +
       'org_unit_id {Filter by organizational unit} ' +
       'payer_tenant_id {Filter by account} ' +
       'persistent_volume_claim {Filter by persistent volume claim} ' +