PatternFly v5 update #3213
Merged
PatternFly v5 update #3213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have a branch for this as well that I've been working with main...gitdallas:koku-ui:pf5-june i've been having some issue with the selecting the source type in the wizard... yours doesn't seem to have that issue, but i'll leave my branch up there in case there is anything worth referencing |
dlabrecq
force-pushed
the
pf-v5
branch
3 times, most recently
from
79dd5d3
to
f60c3ef
Compare
|
noticing that trying to sort details pages is giving an error |
gitdallas
reviewed
Jun 5, 2023
| @@ -97,7 +113,7 @@ class DataTable extends React.Component<DataTableProps, any> { | |||
| }); | |||
| }; | |||
|
|
|||
| private handleOnSort = (event, index, direction) => { | |||
| private handleOnSort = (index, direction) => { | |||
There was a problem hiding this comment.
looks like this is the cause of errors on sorting
Suggested change
| private handleOnSort = (index, direction) => { | |
| private handleOnSort = (_event, index, direction) => { |
There was a problem hiding this comment.
Thanks. I've updated this so it doesn't pass in an unused event
dlabrecq
force-pushed
the
pf-v5
branch
6 times, most recently
from
cdda2bb
to
8ba9bc6
Compare
dlabrecq
force-pushed
the
pf-v5
branch
3 times, most recently
from
f37158c
to
16af317
Compare
dlabrecq
force-pushed
the
pf-v5
branch
2 times, most recently
from
80899df
to
55a93c7
Compare
dlabrecq
removed
the
DO NOT MERGE
dlabrecq
force-pushed
the
pf-v5
branch
5 times, most recently
from
91c7598
to
1290386
Compare
dlabrecq
force-pushed
the
pf-v5
branch
5 times, most recently
from
d087d3d
to
d77e2a7
Compare
dlabrecq
force-pushed
the
pf-v5
branch
3 times, most recently
from
2286a6b
to
3f70fc2
Compare
dlabrecq
force-pushed
the
pf-v5
branch
3 times, most recently
from
79fe5bc
to
dfdacfe
Compare
dlabrecq
force-pushed
the
pf-v5
branch
7 times, most recently
from
f20b043
to
f4cffa1
Compare
dlabrecq
force-pushed
the
pf-v5
branch
6 times, most recently
from
ddf162e
to
fb1a776
Compare
dlabrecq
force-pushed
the
pf-v5
branch
2 times, most recently
from
2268a06
to
b104af1
Compare
dlabrecq
force-pushed
the
pf-v5
branch
2 times, most recently
from
f620ed6
to
76479ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test PatternFly v5 alpha and prerelease updates. To be merged only after official PatternFly release.
https://issues.redhat.com/browse/COST-3931