Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update eslint plugin #3354

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Update eslint plugin #3354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,8 @@
"react/prop-types": 0,
"simple-import-sort/imports": "error",
"spaced-comment": "error",
"testing-library/await-async-query": "error",
"testing-library/no-await-sync-query": "error",
"testing-library/await-async-queries": "error",
"testing-library/no-await-sync-queries": "error",
"testing-library/no-debugging-utils": "warn",
"testing-library/no-dom-import": "off",
"use-isnan": "error"
Expand Down
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
"eslint-plugin-react": "^7.33.2",
"eslint-plugin-simple-import-sort": "^10.0.0",
"eslint-plugin-sort-keys-fix": "^1.1.2",
"eslint-plugin-testing-library": "^5.11.1",
"eslint-plugin-testing-library": "^6.0.1",
"git-revision-webpack-plugin": "^5.0.0",
"jest": "^29.6.4",
"jest-environment-jsdom": "^29.6.4",
Expand Down
50 changes: 0 additions & 50 deletions src/routes/costModels/components/__snapshots__/rateTable.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,53 +24,3 @@ exports[`rate-table sort by metric & measurement 1`] = `
</td>,
]
`;

exports[`rate-table sort by metric & measurement 2`] = `
[
<td
class=""
>
{value, select, cpu {CPU} cluster {Cluster} memory {Memory} node {Node} persistent_volume_claims {Persistent volume claims} storage {Storage} other {}}{"value":"Node"}
</td>,
<td
class=""
>
{value, select, cpu {CPU} cluster {Cluster} memory {Memory} node {Node} persistent_volume_claims {Persistent volume claims} storage {Storage} other {}}{"value":"CPU"}
</td>,
<td
class=""
>
{value, select, cpu {CPU} cluster {Cluster} memory {Memory} node {Node} persistent_volume_claims {Persistent volume claims} storage {Storage} other {}}{"value":"CPU"}
</td>,
<td
class=""
>
{value, select, cpu {CPU} cluster {Cluster} memory {Memory} node {Node} persistent_volume_claims {Persistent volume claims} storage {Storage} other {}}{"value":"CPU"}
</td>,
]
`;

exports[`rate-table sort by metric & measurement 3`] = `
[
<td
class=""
>
{value, select, cpu {CPU} cluster {Cluster} memory {Memory} node {Node} persistent_volume_claims {Persistent volume claims} storage {Storage} other {}}{"value":"Node"}
</td>,
<td
class=""
>
{value, select, cpu {CPU} cluster {Cluster} memory {Memory} node {Node} persistent_volume_claims {Persistent volume claims} storage {Storage} other {}}{"value":"CPU"}
</td>,
<td
class=""
>
{value, select, cpu {CPU} cluster {Cluster} memory {Memory} node {Node} persistent_volume_claims {Persistent volume claims} storage {Storage} other {}}{"value":"CPU"}
</td>,
<td
class=""
>
{value, select, cpu {CPU} cluster {Cluster} memory {Memory} node {Node} persistent_volume_claims {Persistent volume claims} storage {Storage} other {}}{"value":"CPU"}
</td>,
]
`;
10 changes: 6 additions & 4 deletions src/routes/costModels/components/rateTable.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,11 @@ describe('rate-table', () => {
render(<RateTable tiers={tiers} />);
const metrics = screen.getAllByRole('cell', { name: /"value":"(CPU|Node)"/ });
expect(metrics).toMatchSnapshot();
userEvent.click(screen.getByRole('button', { name: /metric/i }));
expect(metrics).toMatchSnapshot();
userEvent.click(screen.getByRole('button', { name: /measurement/i }));
expect(metrics).toMatchSnapshot();
userEvent.click(screen.getByRole('button', { name: /metric/i })).then(() => {
expect(metrics).toMatchSnapshot();
});
userEvent.click(screen.getByRole('button', { name: /measurement/i })).then(() => {
expect(metrics).toMatchSnapshot();
});
});
});
50 changes: 0 additions & 50 deletions src/routes/settings/costModels/components/__snapshots__/rateTable.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,53 +24,3 @@ exports[`rate-table sort by metric & measurement 1`] = `
</td>,
]
`;

exports[`rate-table sort by metric & measurement 2`] = `
[
<td
class=""
>
{value, select, cpu {CPU} cluster {Cluster} memory {Memory} node {Node} persistent_volume_claims {Persistent volume claims} storage {Storage} other {}}{"value":"Node"}
</td>,
<td
class=""
>
{value, select, cpu {CPU} cluster {Cluster} memory {Memory} node {Node} persistent_volume_claims {Persistent volume claims} storage {Storage} other {}}{"value":"CPU"}
</td>,
<td
class=""
>
{value, select, cpu {CPU} cluster {Cluster} memory {Memory} node {Node} persistent_volume_claims {Persistent volume claims} storage {Storage} other {}}{"value":"CPU"}
</td>,
<td
class=""
>
{value, select, cpu {CPU} cluster {Cluster} memory {Memory} node {Node} persistent_volume_claims {Persistent volume claims} storage {Storage} other {}}{"value":"CPU"}
</td>,
]
`;

exports[`rate-table sort by metric & measurement 3`] = `
[
<td
class=""
>
{value, select, cpu {CPU} cluster {Cluster} memory {Memory} node {Node} persistent_volume_claims {Persistent volume claims} storage {Storage} other {}}{"value":"Node"}
</td>,
<td
class=""
>
{value, select, cpu {CPU} cluster {Cluster} memory {Memory} node {Node} persistent_volume_claims {Persistent volume claims} storage {Storage} other {}}{"value":"CPU"}
</td>,
<td
class=""
>
{value, select, cpu {CPU} cluster {Cluster} memory {Memory} node {Node} persistent_volume_claims {Persistent volume claims} storage {Storage} other {}}{"value":"CPU"}
</td>,
<td
class=""
>
{value, select, cpu {CPU} cluster {Cluster} memory {Memory} node {Node} persistent_volume_claims {Persistent volume claims} storage {Storage} other {}}{"value":"CPU"}
</td>,
]
`;
10 changes: 6 additions & 4 deletions src/routes/settings/costModels/components/rateTable.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,11 @@ describe('rate-table', () => {
render(<RateTable tiers={tiers} />);
const metrics = screen.getAllByRole('cell', { name: /"value":"(CPU|Node)"/ });
expect(metrics).toMatchSnapshot();
userEvent.click(screen.getByRole('button', { name: /metric/i }));
expect(metrics).toMatchSnapshot();
userEvent.click(screen.getByRole('button', { name: /measurement/i }));
expect(metrics).toMatchSnapshot();
userEvent.click(screen.getByRole('button', { name: /metric/i })).then(() => {
expect(metrics).toMatchSnapshot();
});
userEvent.click(screen.getByRole('button', { name: /measurement/i })).then(() => {
expect(metrics).toMatchSnapshot();
});
});
});
Loading