Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EC2 page should use a common filter key for export #4037

Merged
merged 1 commit into from
Sep 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/routes/details/awsBreakdown/instances/instances.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ const Instances: React.FC<InstancesProps> = ({ costType, currency }) => {
<ExportModal
count={isAllSelected ? itemsTotal : items.length}
isAllItems={(isAllSelected || selectedItems.length === itemsTotal) && computedItems.length > 0}
groupBy="resource_id"
groupBy="instance"
isOpen={isExportModalOpen}
isTimeScoped
items={items}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ const InstancesTable: React.FC<InstancesTableProps> = ({
// There is no group by for instances, but we use it to format messages
return (
<Actions
groupBy={'resource_id'}
groupBy={'instance'}
isDisabled={isDisabled}
item={item}
isTimeScoped
Expand Down
Loading