Skip to content

🧹 [code health improvement] Generate view id if not provided #5114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tiziano88 wants to merge 4 commits into
base: main
Choose a base branch
from
+6 −2
Open

🧹 [code health improvement] Generate view id if not provided #5114

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
88e0cd7
🧹 Fix code health issue: Generate view id if not provided
google-labs-jules[bot] Apr 23, 2026
6e4ec0b
🧹 Fix code health issue: Generate view id if not provided
google-labs-jules[bot] Apr 23, 2026
27f4197
🧹 Fix code health issue: Generate view id if not provided
google-labs-jules[bot] Apr 23, 2026
2bb0a3c
🧹 Fix code health issue: Generate view id if not provided
google-labs-jules[bot] Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions oak_private_memory/database/icing.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,9 +633,13 @@ impl IcingMetaDatabase {
let mut pending_views: Vec<PendingLlmViewMetadata> = Vec::new();
if let Some(views) = memory.views.as_ref() {
for view in &views.llm_views {
// TODO: yongheng - Generate view id if not provided.
let mut view = view.clone();
if view.id.is_empty() {
let random: u128 = rand::rng().random::<u128>();
view.id = format!("{:032x}", random);
}
if let Some(pending_view_metadata) =
PendingLlmViewMetadata::new(memory, view, &blob_id)?
PendingLlmViewMetadata::new(memory, &view, &blob_id)?
{
pending_views.push(pending_view_metadata);
}
Expand Down
Loading