[REFACTOR] 프로젝트 전반적인 리펙토링 - #179
Open
eum018 wants to merge 15 commits into
Open
Conversation
ChatRoutes, CommunityRoutes, HomeRoutes, ProfileRoute, PasswordResetRoutes, SignupRoutes 분리 각 route 클래스에서 binding isRegistered 체크 적용 Resolve: #176 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
NavigationScreen을 ShellRoute로 감싸 하단 탭 유지 구조로 변경 postDetail onExit에서 PostViewController tag 기반 삭제 적용 RoutePaths navigation 제거 및 경로 정리 Resolve: #176 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
auth_binding 분리, navigation_binding 공통 의존성만 유지 post_binding PostViewController tag 기반 등록으로 변경 post_detail_view_binding 제거 Resolve: #176 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
PageView 제거 후 GoRouter ShellRoute child 방식으로 변경 Map 기반 탭 관리 및 GoRouterState 경로로 currentIndex 계산 _lastIndex로 탭 외 화면에서 이전 탭 하이라이트 유지 NavigationController 제거 Resolve: #176 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
postId를 필수 파라미터로 받아 tag 기반으로 PostViewController 조회 Resolve: #176 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
RoutePaths.navigation 제거에 따라 home 경로로 변경 Resolve: #176 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
PostBinding isFavorite 파라미터 반영 NavigationScreen ShellRoute 방식 유지 Resolve: #176 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
4 tasks
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the routing architecture by modularizing route definitions into dedicated files and migrating the navigation system from GetX's PageController to GoRouter. Key improvements include the introduction of AuthBinding for centralized dependency management and the use of tagged controllers in PostDetailScreen for better state isolation. Review feedback identifies a critical bug in AuthBinding where dependencies are incorrectly registered only if they already exist. Other suggestions include avoiding side effects within the build method of NavigationScreen, optimizing dependency injection with registration checks in the router, and removing obsolete TODO comments.
_lastIndex 업데이트 로직을 build에서 didChangeDependencies로 이동 GoRouterState 의존성 변경 시 생명주기 메서드에서 상태 처리 Resolve: #176 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
auth_binding isRegistered 조건 반전 버그 수정 postDetail builder PostViewController isRegistered 체크 추가 post_binding TODO 주석 제거 Resolve: #176 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
MainTopSearchBar pageId/resultPageBuilder 제거, child 방식으로 단순화 MainTopBarSearchController context 기반 섹션 감지 후 navigate 처리 SearchState copyWith 불변 객체 패턴 적용 SearchPopup tip 제출 시 navigate 연동 Resolve: #176 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
HomeSearchController, HomeSearchBinding 분리 HomeRoutes search route에서 SearchState extra 추출 및 binding 적용 HomeBinding datasource/repository 제거 후 usecase 직접 등록으로 정리 Resolve: #176 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
CommunitySearchController, CommunitySearchBinding 분리 CommunityRoutes search route SearchState extra 추출 및 binding 적용 CommunityMainScreen MainTopSearchBar 방식으로 변경 Resolve: #176 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
MainTopSearchBar child 방식으로 변경 Resolve: #176 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
HomeSearchBinding, HomeSearchController 구현 내용 반영 CommunitySearchBinding, CommunitySearchController 구현 내용 반영 Resolve: #176 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
initialLocation을 splash로 복구 HomeBinding에 PostRemoteDatasource, PostRepositoryImpl 등록 추가 Resolve: #176 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 개요
프로젝트의 전반적인 구조를 테스트하고 변경한다.
🧩 작업 내용
📎 참고 사항