Skip to content

[FIX] 게시물 하트 버그 수정 - #258

Merged
ryusuye0n merged 10 commits into
developfrom
feature/#254-heart-bug-fix
Jun 21, 2026
Merged

[FIX] 게시물 하트 버그 수정#258
ryusuye0n merged 10 commits into
developfrom
feature/#254-heart-bug-fix

Conversation

@ryusuye0n

@ryusuye0n ryusuye0n commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

📌 개요

게시물 하트 기능 버그를 수정하도록 하겠습니다.


🎯 작업 목표

  • 게시물 하트 기능 정상작동 시키기

🧩 작업 내용

  • 게시물 하트 버그 수정

✅ 완료 조건

  • 게시물 하트 기능이 정상적으로 작동된다
  • 게시물 상세보기 하트 상태와 미리보기 하트 상태가 통일되어있다

📎 참고 사항

  • 디자인 시안 (figma)
  • api 명세서

closes #254

@ryusuye0n ryusuye0n self-assigned this Jun 4, 2026
@ryusuye0n ryusuye0n added the fix 버그 수정 label Jun 4, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request synchronizes and reactively updates the post liked and bookmarked states across the home, community, and post detail screens, including wrapping the home post list in an Obx widget. The review feedback identifies a critical bug in _resolveIsFavorite where an initial liked state prevents unlike actions from taking effect, and points out a missing local persistence call in HomeController.updatePostLike that leads to state loss on app restart. Additionally, the reviewer recommends awaiting the updated asynchronous updatePostLike method and replacing an inefficient list copy with a simple refresh call on the reactive list.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread lib/presentation/post/controllers/post_view_controller.dart Outdated
Comment thread lib/presentation/home/controllers/home_controller.dart Outdated
Comment thread lib/presentation/post/controllers/post_view_controller.dart Outdated
Comment thread lib/presentation/home/controllers/home_controller.dart Outdated

@heoeunseo08 heoeunseo08 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다.

Comment thread lib/presentation/home/controllers/home_controller.dart Outdated
Comment thread lib/presentation/post/controllers/post_view_controller.dart Outdated
Comment thread lib/presentation/post/controllers/post_view_controller.dart Outdated
@project-ondo project-ondo deleted a comment from eum018 Jun 4, 2026
Comment thread lib/presentation/home/controllers/home_controller.dart Outdated
Comment thread lib/core/design_system/components/custom_icon_button.dart Outdated
Comment thread lib/core/router/bindings/navigation_binding.dart Outdated
Comment thread lib/core/router/bindings/post_view_binding.dart Outdated
Comment thread lib/presentation/community/widgets/community_post_list.dart Outdated
Comment thread lib/presentation/home/controllers/home_controller.dart Outdated
Comment thread lib/presentation/community/controllers/like_state_controller.dart Outdated
Comment thread lib/presentation/community/controllers/like_state_controller.dart Outdated
Comment thread lib/presentation/home/controllers/home_controller.dart
Comment thread lib/presentation/post/controllers/post_controller.dart
Comment thread lib/core/design_system/components/custom_icon_button.dart Outdated
@ryusuye0n
ryusuye0n force-pushed the feature/#254-heart-bug-fix branch from 0c71bbc to 485a966 Compare June 21, 2026 07:50
ryusuye0n and others added 4 commits June 21, 2026 16:52
- LikeStateController 제거 후 PostController로 좋아요 이벤트/동기화 로직 병합
- LikeChangedEvent를 domain/post/entity로 이동
- LikeStateController 전역 바인딩을 PostBinding(permanent)으로 이동
- HomeController _updatePostLikeInList의 delta 인자 제거 (내부에서 계산)
- PostViewBinding의 미사용 isFavorite 인자 제거 및 호출부 정리
- CustomIconButton을 StatefulWidget으로 변경해 자체 상태 관리 (totalStyle.copyWith)
- CommunityPostList PostItem key를 postId 기준으로 단순화

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

@eum018 eum018 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다.

@ryusuye0n
ryusuye0n merged commit bda7bee into develop Jun 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix 버그 수정

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FIX] 게시물 하트 버그 수정

3 participants