Skip to content

Qa/fix potential date issue #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anobjectw wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Qa/fix potential date issue #51

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25b04bc
Merge pull request #35 from project-pareto/working/#83-Update-Request…
mfucilli-troyweb Aug 6, 2025
dd912c4
Merge pull request #50 from project-pareto/develop
mfucilli-troyweb Oct 3, 2025
c43c313
if dates come back with not just Y-m-d but with H:i:s, there could be…
anobjectw Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 24 additions & 5 deletions inc/element-builders.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -905,11 +905,9 @@ function buildRequestTable( $type = '' ) {

$transaction_status_class = ( get_post_meta( $post, 'status', true ) ) ? 'status-'. get_post_meta( $post, 'status', true ) : 'status-none';

$start = get_post_meta( $post, 'start_date', true );
( $start ) ? $start = DateTime::createFromFormat('Y-m-d', $start)->format('m/d/Y') : "";
$end = get_post_meta( $post, 'end_date', true );
( $end ) ? $end = DateTime::createFromFormat('Y-m-d', $end)->format('m/d/Y') : "";
$range = "$start - $end";
$start = waterportal_format_date_meta( get_post_meta( $post, 'start_date', true ) );
$end = waterportal_format_date_meta( get_post_meta( $post, 'end_date', true ) );
$range = trim( "$start - $end", ' -' );
$rate = ( get_post_meta( $post, 'rate_bpd', true ) ) ? get_post_meta( $post, 'rate_bpd', true ) : "";


Expand Down Expand Up @@ -1240,6 +1238,27 @@ function buildRequestTable( $type = '' ) {
return $table;
}

function waterportal_format_date_meta( $raw_date ) {
if ( empty( $raw_date ) ) {
return '';
}

$formats = [
'Y-m-d',
'Y-m-d H:i:s',
'Y-m-d\TH:i:sP',
];

foreach ( $formats as $format ) {
$dt = DateTime::createFromFormat( $format, $raw_date );
if ( $dt instanceof DateTime ) {
Copy link

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DateTime::createFromFormat() method can return false on failure, but it can also return a DateTime object with parsing errors. Use $dt !== false && $dt->getLastErrors()['warning_count'] === 0 && $dt->getLastErrors()['error_count'] === 0 instead of just checking instanceof to ensure the date was parsed correctly.

Suggested change
if ( $dt instanceof DateTime ) {
if ( $dt !== false && $dt->getLastErrors()['warning_count'] === 0 && $dt->getLastErrors()['error_count'] === 0 ) {

Copilot uses AI. Check for mistakes.
return $dt->format( 'm/d/Y' );
}
}

return '';
}

function getWaterRequestData($pid){
$post_info = [];
$post_info['pid'] = $pid;
Expand Down