Skip to content
This repository has been archived by the owner on Dec 4, 2020. It is now read-only.

Staff Meeting 020 Summary

Jump to bottom
zircon-tpl edited this page Jun 25, 2020 · 2 revisions

Roll Call

aether, cocosolos, ibm2431, Wiggo, Zircon

Opening Remarks

Due to the consistent increase in the number of Pull Requests opened to Project Topaz, our Staff does not have the capacity to ensure that all Pull Requests are steadily reviewed on the "automatically merge if not held" schedule we have been holding to until now.

While we do value all Pull Requests and do wish that we had the capacity to maintain such a system, our endeavor to do so with our current volume of Pull Requests has put undue pressure on Staff. This endeavor has also stalled development for Project Focuses, as Staff have been dedicating all of their time to Pull Request reviews to meet the scheduled times in which Pull Requests must be reviewed by.

Therefore, it is with great regret that I state we will pause the process in which all Pull Requests are brought up for discussion during Staff meetings and decisions made to either hold or merge the Pull Request. Starting with this meeting, the only Pull Requests that will be brought up for discussion are those which have been reviewed.

We are currently exploring new processes to ensure that community contributions are reviewed, improved, and accepted into the codebase. One such process is the establishment of recognized community reviewers - who are not Staff and will not have the powers of Staff - who have demonstrated their ability to thoroughly review submissions and assist Staff by making the review process easier. We will discuss such roles further during General Remarks.

All opened Pull Requests which have not been reviewed will be listed in a new section of our meeting format - "Unreviewed Pull Requests". This section will ensure that Staff are reminded of these Pull Requests, and provide an easy list for community reviewers to see which Pull Requests our Staff might need assistance reviewing! I hope the addition of this section will provide Pull Request authors with sufficient confidence that they are not being ignored by the project.

I wish to make it clear that we have no intention of letting any Pull Request languish for extended period without engagement by Project Topaz. We want everyone to feel involved in development! I will be watching how this decision affects contributions and community morale. If the health of project is negatively affected, we will pursue further revising or enact new processes to ensure a healthy contribution environment.

Despite how exceptional our Staff may be, they are still only human - and unpaid volunteers at that! We thank you for your understanding.

Staff Updates

aether: Testing new database update tool

cocosolos: Reviewing Pull Requests; working on database tool; finished planned work on hunts

ibm2431: Reviewing Pull Requests; primarily focusing on Geomancer Pull Requests

Wiggo: Progressing in capture of mythic quest line

General Remarks

  • Discussed review process, adoption of recognized Reviewer role, and how that role might factor into the Pull Request process. This was a prolonged discussion with several views and concerns. The recognized Reviewer role has not been adopted at this time.
  • Discussed adoption of recognized Developer, Tester, and Researcher roles; affirmed their use; Zircon will establish process in which Community Members may acquire these roles

Reviewed Pull Requests (11)

  1. #548 - Pathfind fix for Novalmauge
    • Held (cocosolos): Desired changes
    • Held (ibm2431): Desired changes
  2. #607 - Full Speed Ahead + Packet 0x3A + Packet 0x75 + Packet 0x77
    • Merged into raptor-speed
  3. #638 - [FIX] Remove 1 day wait for Ranperre's Final Rest quest
    • Closed; changes made redundant by another merged Pull Request
  4. #685 - Abyssea Lights system
    • Held (cocosolos): Intends to review
    • Held (ibm2431): Desires changes
  5. #698 - Additional geomancy bubbles
    • Held (ibm2431): Desires changes; will develop them
    • Held (cocosolos): Intends to review changes
  6. #730 - Adds "All in the Cards" repeatable quest to Chululu
    • Held (cocosolos): Desires changes
  7. #731 - Adjust NPC script for Sandy 6-2 "Ranperre's Final Rest"
    • Merged into ranperre-rest
  8. #732 - Client Update 30200604_0
    • Merged into release
  9. #735 - Fixes pet not despawning in combat when master dies.
    • Held (ibm2431): Desires changes
  10. #736 - Adds scripting and DB edits for NM Backoo
    • Merged into backoo
  11. #738 - Fix Half Partition synth level requirements
    • Held (cocosolos): Desires changes

Unreviewed Pull Requests (18)

  1. #572 - Add effects rework
    • Opened: May 2
  2. #578 - [WIP] Trust animations + zone misc flag
    • Opened: May 3
  3. #651 - [WIP] Refactor effort
    • Opened: May 23
  4. #720 - Update Vulcan Shot Mob WS to reflect retail DMG
    • Opened: Jun 13
  5. #723 - Geomancer abilities, merits, and adjustments
    • Opened: Jun 14
  6. #726 - Last Genkai + Prelude Quest
    • Opened: Jun 15
  7. #734 - Add ordering to status effects
    • Opened: Jun 16
  8. #743 - Implement Eco-Warrior quests
    • Opened: Jun 17
  9. #744 - Fix BRD song overwrite bug
    • Opened: Jun 18
  10. #749 - Updated item_basic.sql to match with Lelia
    • Opened: Jun 19
  11. #751 - Added Scholar AF quest Seeing Blood-Red
    • Opened: Jun 20
  12. #754 - Updates for item_equipment.sql, item_latents.sql, item_weapon.sql
    • Opened: Jun 22
  13. #755 - Adjusted Switchstix Relic wait time to current retail
    • Opened: Jun 22
  14. #762 - Entity positioning
    • Opened: Jun 23
  15. #764 - Adding capability for cross-server commands (lua)
    • Opened: Jun 23
  16. #765 - Update to hunts global
    • Opened: Jun 23
  17. #766 - Fix True Will title
    • Opened: Jun 24
  18. #768 - Added POS info for Aqueduct Spiders in Sacrarium
    • Opened: Jun 24

Feature Branches (19)

  1. adventuringfellow
    • Basic adventuring fellow and initial quests
    • Merge date: Unknown
    • Not in canary. Downstream servers should not pull this branch.
  2. apoc-nigh
    • Implements Shadows of the Departed
    • Implements quest and reward logic for Apocalypse Nigh
    • Partially implements Apocalypse Nigh BCNM
    • Merge date: Unknown
  3. backoo
    • Implements NM "Backoo"
    • Merge date: Next week
  4. blue-mage
    • Fixes to Blue Mage spell damage and attack type classifications
    • Implements "Omens" quest
    • Implements "Transformations" quest
    • Adds capability to craft Blue Mage Artifact armor
    • Add Pinecone Bomb spell
    • Merge date: Unknown
  5. compiler-updates
    • Adds -Werror to builds
    • Various small Core fixes
    • Merge date: Delayed, tentatively next week
  6. dual-wield
    • Work on improvements to how dual wielding players and mobs are handled
    • Merged into release
  7. geo
    • Implements Geomancer job
    • Merge date: Unknown
    • Not in canary. Downstream servers should not pull this branch.
  8. hunt-system
    • Implements NM hunts
    • Merge date: Unknown
  9. limbus
    • Updates Limbus entry and chest mechanics
    • Adds all level 75 Apollyon BCNMs
    • Adds all level 75 Temenos BCNMs
    • Merge date: Unknown
  10. mystery
    • Basic daily tally accruing
    • Capability to use dials to obtain items from most goblins
    • Capability to trade keys to goblins for free dial spins
    • Merge date: Unknown
  11. rampart
    • Adjusts Paladin ability "Rampart" to match current retail
    • Merge date: Delayed, tentatively next week
  12. ranperre-rest
    • Adjusts NPCs related to San d'Oria mission "Ranperre's Final Rest"
    • Merge date: Two weeks
  13. raptor-speed
    • Implements Jeuno quest "Full Speed Ahead!"
    • Implements packet 0x3A
    • Implements packet 0x75
    • Implements packet 0x77
    • Merge date: Unknown
  14. rov
    • Rhapsodies of Vana'diel 1-1 to 1-18
    • Merge date: Two weeks
  15. time-mage
    • Allows changing the current vana'diel date
    • Merge date: Delayed, tentatively next week
  16. trust
    • Basic trust summoning and behavior
    • Capability to quest starting trusts; enabled by default with setting
    • Basic capability to script trusts to use magic and job abilities
    • Merge date: Unknown

Closing Remarks

On behalf of Project Topaz, I again apologize for the change in our review process. Moving forward we will seek to strike a balance to ensure that all community contributions are reviewed and accepted on a consistent schedule, while being mindful of the capacity that we currently have. We will explore revising our processes, and pursue new methods which may be suggested to us. I thank all contributors for their kindness and understanding in this matter.

Community Members who wish to assist Project Topaz in a more directed capacity may send me a Direct Message if they are interested in obtaining the Developer, Tester, and Researcher role. We do not yet have a firmly established process for acquiring these roles, and we will seek to increase the amount of automation involved in the future.

Home

Clone this wiki locally