-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added support for changing config via API #729
Open
eusebiu-constantin-petu-dbk
wants to merge
1
commit into
project-zot:main
Choose a base branch
from
eusebiu-constantin-petu-dbk:api_config_reload
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: added support for changing config via API #729
eusebiu-constantin-petu-dbk
wants to merge
1
commit into
project-zot:main
from
eusebiu-constantin-petu-dbk:api_config_reload
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eusebiu-constantin-petu-dbk
force-pushed
the
api_config_reload
branch
2 times, most recently
from
August 16, 2022 14:49
b01598f
to
c4a8343
Compare
eusebiu-constantin-petu-dbk
requested review from
rchincha and
andaaron
as code owners
August 16, 2022 14:49
eusebiu-constantin-petu-dbk
force-pushed
the
api_config_reload
branch
6 times, most recently
from
August 19, 2022 12:02
19df363
to
b8eeb82
Compare
Codecov Report
@@ Coverage Diff @@
## main #729 +/- ##
==========================================
+ Coverage 88.75% 88.85% +0.10%
==========================================
Files 73 77 +4
Lines 13847 14009 +162
==========================================
+ Hits 12290 12448 +158
- Misses 1212 1215 +3
- Partials 345 346 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
eusebiu-constantin-petu-dbk
force-pushed
the
api_config_reload
branch
from
August 25, 2022 16:57
b8eeb82
to
ef23662
Compare
eusebiu-constantin-petu-dbk
force-pushed
the
api_config_reload
branch
15 times, most recently
from
September 1, 2022 16:32
d117f37
to
4925a11
Compare
eusebiu-constantin-petu-dbk
force-pushed
the
api_config_reload
branch
6 times, most recently
from
September 7, 2022 16:37
d870f38
to
4bc9813
Compare
rchincha
reviewed
Sep 20, 2022
eusebiu-constantin-petu-dbk
force-pushed
the
api_config_reload
branch
3 times, most recently
from
September 26, 2022 09:01
0422c39
to
48b0b95
Compare
eusebiu-constantin-petu-dbk
force-pushed
the
api_config_reload
branch
3 times, most recently
from
October 27, 2022 10:14
5f131e9
to
9229444
Compare
eusebiu-constantin-petu-dbk
changed the title
Added support for changing config via API
feat: added support for changing config via API
Oct 27, 2022
eusebiu-constantin-petu-dbk
force-pushed
the
api_config_reload
branch
9 times, most recently
from
October 28, 2022 12:16
630b3bf
to
ffa9e91
Compare
closes project-zot#268, closes project-zot#698 Signed-off-by: Petu Eusebiu <[email protected]>
eusebiu-constantin-petu-dbk
force-pushed
the
api_config_reload
branch
from
October 28, 2022 15:27
ffa9e91
to
8efbe56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #268, closes #698
Signed-off-by: Petu Eusebiu [email protected]
What does this PR do / Why do we need it:
added a http handler to GET current zot config or POST a new one
only admins can GET/POST configs
after zot successfully starts its server it will back up the current configurationafter a POST config, zot will validate it and restart the server with the new configuration
if the server crashes because of config errors zot will restore the config to the last backup.(not anymore)the config file which zot starts with is the single source of configuration and it will always reflect the current configuration of a running zot.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.