Skip to content

Conversation

shawn111
Copy link

@shawn111 shawn111 commented Mar 25, 2019

- What I did
Fix stopped container still report as running.

- How I did it
When containerd restarted, check correct container running status

- How to verify it

# dockerd-> containerd -> containerd-shim -> <runc_container_process>

$ docker run xxx
$ docker ps  ## correct, shows one container is up

# simulate the heavy scenario
$ kill -STOP <dockerd_PID>

$ kill <docker-containerd-shim_PID> or kill <runc_container_process_PID>
$ kill <docker-containerd_PID>

$ kill -CONT <dockerd_PID>
$ docker ps  ## wrong, still shows one container is up

After, apply the patch, the final docker ps could be correct.

Reference issue:

@rh-atomic-bot
Copy link

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@rhatdan
Copy link
Member

rhatdan commented Mar 26, 2019

bot, add author to whitelist
LGTM
You need to sign your commit

git commit -a --amend -s
git push --force

Was this a backport from upstream?

@shawn111
Copy link
Author

Hi @rhatdan,

Not, it is not from upstream.
Maybe I should send another PR for upstream.

Thanks for your review.

@rhatdan
Copy link
Member

rhatdan commented Mar 27, 2019

Yes send it to them and get their approval.

@rhatdan
Copy link
Member

rhatdan commented Mar 27, 2019

Hopefully we don't have this inconsistency in Podman.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants