Add placeholder loading animation to expand button #1536
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases the scope of the selector to target all turbo frames, not only the lazy loading turbo frames, in the collection context sidebar. This adds the loading animation above the "Expand" button once clicked:
The change from
after
tobefore
does not change the existing behavior because all theloading="lazy"
turbo frame containers inapp/components/arclight/document_components_hierarchy_component.html.erb
are empty.I believe the docs suggest we can use
busy
in this way:This is something we are thinking of adding to our app. I thought I'd check if there was interest here first.