Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruby 3.4 to the test matrix #1573

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add ruby 3.4 to the test matrix #1573

wants to merge 1 commit into from

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Jan 8, 2025

No description provided.

@seanaery
Copy link
Contributor

seanaery commented Jan 8, 2025

Thanks @jcoyne . Looks like the failing tests here are because ruby dropped the csv gem from the standard library in 3.4.0. So I think we probably just need to explicitly require it in the arclight gemspec now, i.e., spec.add_dependency 'csv'

@jcoyne
Copy link
Member Author

jcoyne commented Jan 8, 2025

@seanaery we don't use the CSV gem in Arclight though, so it seems wrong to fix it here. I think sul-dlss/traject_plus#39 is what we're waiting for.

@seanaery
Copy link
Contributor

seanaery commented Jan 8, 2025

@jcoyne Aha, you're right -- thanks for the heads-up about traject_plus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants