chore(deps): update graphene-django

Update to graphene-django 2.12.1 and fix connection field, schema.
projectcaluma · Aug 5, 2020 · ddbc13e · ddbc13e
1 parent a5acc5f
commit ddbc13e
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 8 deletions.
diff --git a/caluma/caluma_core/types.py b/caluma/caluma_core/types.py
@@ -65,10 +65,13 @@ class DjangoConnectionField(DjangoConnectionField):
     This can be removed, when (or better if)
     https://github.com/graphql-python/graphql-relay-py/issues/12
     is resolved.
+
+    TODO: properly implement max_limit, see
+    https://github.com/graphql-python/graphene-django/blob/b552dcac24364d3ef824f865ba419c74605942b2/graphene_django/fields.py#L133
     """
 
     @classmethod
-    def resolve_connection(cls, connection, args, iterable):
+    def resolve_connection(cls, connection, args, iterable, max_limit=None):
         iterable = maybe_queryset(iterable)
         if isinstance(iterable, QuerySet):
             # only query count on database when pagination is needed

diff --git a/caluma/caluma_form/schema.py b/caluma/caluma_form/schema.py
@@ -746,6 +746,9 @@ class Meta:
 
 
 class SaveDocument(Mutation):
+    class Input:
+        id = graphene.ID()
+
     class Meta:
         serializer_class = serializers.DocumentSerializer
         model_operations = ["create", "update"]

diff --git a/caluma/caluma_workflow/schema.py b/caluma/caluma_workflow/schema.py
@@ -257,6 +257,9 @@ class Meta:
 
 
 class SaveCase(Mutation):
+    class Input:
+        id = graphene.ID()
+
     class Meta:
         serializer_class = serializers.SaveCaseSerializer
         model_operations = ["create", "update"]

diff --git a/caluma/tests/__snapshots__/test_schema.ambr b/caluma/tests/__snapshots__/test_schema.ambr
@@ -1293,7 +1293,7 @@
   }
 
   input SaveCaseInput {
-    id: String
+    id: ID
     workflow: ID!
     meta: JSONString
     parentWorkItem: ID
@@ -1395,7 +1395,6 @@
     document: ID!
     meta: JSONString
     value: String
-    valueId: ID
     clientMutationId: String
   }
 
@@ -1418,7 +1417,7 @@
   }
 
   input SaveDocumentInput {
-    id: String
+    id: ID
     form: ID!
     meta: JSONString
     clientMutationId: String
@@ -2134,9 +2133,9 @@
     task: Task!
     status: WorkItemStatus!
     meta: GenericScalar
-    addressedGroups: [String]!
-    controllingGroups: [String]!
-    assignedUsers: [String]!
+    addressedGroups: [String!]!
+    controllingGroups: [String!]!
+    assignedUsers: [String!]!
     case: Case!
     childCase: Case
     document: Document

diff --git a/requirements.txt b/requirements.txt
@@ -8,7 +8,7 @@ django-localized-fields==5.4.2
 django-postgres-extra==1.22
 djangorestframework==3.11.0
 django_simple_history==2.11.0
-graphene-django==2.8.2
+graphene-django==2.12.1
 idna==2.10
 minio==5.0.10
 psycopg2-binary==2.8.5