Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(guides): document namespace migration #8

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

Svarrogh1337
Copy link
Contributor

Add namespace migration across tenants under guides.
Closes: projectcapsule/capsule#1131

Copy link
Member

@prometherion prometherion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'll wait for @oliverbaehler review

ns-foo Active 36s capsule.clastix.io/tenant=solar,kubernetes.io/metadata.name=ns-foo
0df8e9ee-5f6f-40a4-897d-b80d349ca36f%
```
Edit UID and labels to match the output of the previous commands.
Copy link

@shadow625 shadow625 Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, sorry i delyed so much to start the document.
About the procedure, i think we only need to change the tenant name and UID in ownerReferences, the capsule tenant label will be changed automatically once we change the ownerReferences.
And also, i don't know it's intended or not, you can change the ownership by only change the tenant name in ownerReferences, which will leave the tenant name and tenant uid conflict, but capsule works fine. Seems capsule respect the tenant name rather than uid.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bout the procedure, i think we only need to change the tenant name and UID in ownerReferences, the capsule tenant label will be changed automatically once we change the ownerReferences.

Sounds interesting, I will give it a try and I will update the documentation afterwards.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shadow625 I've updated the wording, let me know if it looks good to you.

@@ -28,7 +28,7 @@ ns-bar Active 28s capsule.clastix.io/tenant=wind,kubernetes.io/metadata.na
ns-foo Active 36s capsule.clastix.io/tenant=solar,kubernetes.io/metadata.name=ns-foo
0df8e9ee-5f6f-40a4-897d-b80d349ca36f%
```
Edit UID and labels to match the output of the previous commands.
While altering ownerReferences name is sufficient on its own, it's highly recommended to edit the UID and labels to match the output of the previous commands.
Copy link

@shadow625 shadow625 Aug 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's highly recommended to edit the UID and labels

Looks good, just one thing, we only need to change tenant name and tenant UID, not the labels .
If you change the label and save, you will find the label stay same, namespace still belong to the old tenant. And if you change the tenant name and UID, the label will be automatically changed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed and also adjusted the wording in the previous paragraphs to match the findings.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely 👍 , thanks.

Copy link

@shadow625 shadow625 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Svarrogh1337
Copy link
Contributor Author

If everything looks good, @prometherion can you approve the workflows?

@maxgio92
Copy link
Collaborator

maxgio92 commented Aug 3, 2024

Hi @Svarrogh1337, can you reformat your commit messages to include column after the type (e.g. docs(guides): etc.) and lowercase, please?

@Svarrogh1337
Copy link
Contributor Author

Svarrogh1337 commented Aug 3, 2024

Hi @Svarrogh1337, can you reformat your commit messages to include column after the type (e.g. docs(guides): etc.) and lowercase, please?

@maxgio92, done.

Copy link
Collaborator

@maxgio92 maxgio92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prometherion prometherion merged commit 4b70ebd into projectcapsule:main Aug 14, 2024
3 of 4 checks passed
@prometherion prometherion changed the title docs(guides) Document namespace migration docs(guides): document namespace migration Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to move a namespace to another tenant without delete and recreate
4 participants