-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(guides): document namespace migration #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'll wait for @oliverbaehler review
191a78e
to
1e4579e
Compare
ns-foo Active 36s capsule.clastix.io/tenant=solar,kubernetes.io/metadata.name=ns-foo | ||
0df8e9ee-5f6f-40a4-897d-b80d349ca36f% | ||
``` | ||
Edit UID and labels to match the output of the previous commands. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, sorry i delyed so much to start the document.
About the procedure, i think we only need to change the tenant name and UID in ownerReferences, the capsule tenant label will be changed automatically once we change the ownerReferences.
And also, i don't know it's intended or not, you can change the ownership by only change the tenant name in ownerReferences, which will leave the tenant name and tenant uid conflict, but capsule works fine. Seems capsule respect the tenant name rather than uid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bout the procedure, i think we only need to change the tenant name and UID in ownerReferences, the capsule tenant label will be changed automatically once we change the ownerReferences.
Sounds interesting, I will give it a try and I will update the documentation afterwards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shadow625 I've updated the wording, let me know if it looks good to you.
@@ -28,7 +28,7 @@ ns-bar Active 28s capsule.clastix.io/tenant=wind,kubernetes.io/metadata.na | |||
ns-foo Active 36s capsule.clastix.io/tenant=solar,kubernetes.io/metadata.name=ns-foo | |||
0df8e9ee-5f6f-40a4-897d-b80d349ca36f% | |||
``` | |||
Edit UID and labels to match the output of the previous commands. | |||
While altering ownerReferences name is sufficient on its own, it's highly recommended to edit the UID and labels to match the output of the previous commands. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's highly recommended to edit the UID and
labels
Looks good, just one thing, we only need to change tenant name and tenant UID, not the labels .
If you change the label and save, you will find the label stay same, namespace still belong to the old tenant. And if you change the tenant name and UID, the label will be automatically changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed and also adjusted the wording in the previous paragraphs to match the findings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely 👍 , thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
If everything looks good, @prometherion can you approve the workflows? |
Hi @Svarrogh1337, can you reformat your commit messages to include column after the type (e.g. |
Signed-off-by: Hristo Hristov <[email protected]>
@maxgio92, done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add namespace migration across tenants under guides.
Closes: projectcapsule/capsule#1131