Improve error handling and efficiency in Result methods

README.md

@@ -120,7 +120,7 @@ Example of using uncover as library is provided in [examples](examples/main.go)
 The default provider configuration file should be located at `$CONFIG/uncover/provider-config.yaml` and has the following contents as an example.
 
 
-> **Note**: API keys are required needs to be configured before running uncover.
+> **Note**: API keys are required and must be configured before running uncover.
 
 ```yaml
 shodan:
@@ -130,7 +130,7 @@ censys:
   - CENSYS_API_ID_1:CENSYS_API_SECRET_1
   - CENSYS_API_ID_2:CENSYS_API_SECRET_2
 fofa:
-  - FOFA_EMAIL_1:FOFA_KEY_2
+  - FOFA_EMAIL_1:FOFA_KEY_1
   - FOFA_EMAIL_2:FOFA_KEY_2
 quake:
   - QUAKE_TOKEN_1

go.mod

@@ -86,7 +86,7 @@ require (
 	github.com/projectdiscovery/hmap v0.0.38 // indirect
 	github.com/projectdiscovery/networkpolicy v0.0.7 // indirect
 	github.com/projectdiscovery/retryabledns v1.0.55 // indirect
-	github.com/quic-go/quic-go v0.38.1 // indirect
+	github.com/quic-go/quic-go v0.38.2 // indirect
 	github.com/refraction-networking/utls v1.5.4 // indirect
 	github.com/rivo/uniseg v0.4.4 // indirect
 	github.com/syndtr/goleveldb v1.0.0 // indirect

go.sum

@@ -187,8 +187,8 @@ github.com/projectdiscovery/retryablehttp-go v1.0.45 h1:rpWHbver3qeFUx0Vf0R7VOag
 github.com/projectdiscovery/retryablehttp-go v1.0.45/go.mod h1:vTOfQqJa0S2sSGaBhGbgZKltpWFEj4nZm4XP+tKFf0k=
 github.com/projectdiscovery/utils v0.0.77 h1:HPLNY/WgVsLaHPBW1XA5XYMkTo9VRjhbOIZs+Lfww7s=
 github.com/projectdiscovery/utils v0.0.77/go.mod h1:XkHTUln/MJaWAgber2C0o1Mqacr2s9JMRhOVBjmII7w=
-github.com/quic-go/quic-go v0.38.1 h1:M36YWA5dEhEeT+slOu/SwMEucbYd0YFidxG3KlGPZaE=
-github.com/quic-go/quic-go v0.38.1/go.mod h1:ijnZM7JsFIkp4cRyjxJNIzdSfCLmUMg9wdyhGmg+SN4=
+github.com/quic-go/quic-go v0.38.2 h1:VWv/6gxIoB8hROQJhx1JEyiegsUQ+zMN3em3kynTGdg=
+github.com/quic-go/quic-go v0.38.2/go.mod h1:ijnZM7JsFIkp4cRyjxJNIzdSfCLmUMg9wdyhGmg+SN4=
 github.com/refraction-networking/utls v1.5.4 h1:9k6EO2b8TaOGsQ7Pl7p9w6PUhx18/ZCeT0WNTZ7Uw4o=
 github.com/refraction-networking/utls v1.5.4/go.mod h1:SPuDbBmgLGp8s+HLNc83FuavwZCFoMmExj+ltUHiHUw=
 github.com/rivo/uniseg v0.1.0/go.mod h1:J6wj4VEh+S6ZtnVlnTBMWIodfgj8LQOQFoIToxlJtxc=

sources/result.go

@@ -1,8 +1,9 @@
 package sources
+
 import (
 	"encoding/json"
-	"fmt"
 	"net"
+	"strconv"
 )
 
 type Result struct {
@@ -13,22 +14,33 @@ type Result struct {
 	Host      string `json:"host"`
 	Url       string `json:"url"`
 	Raw       []byte `json:"-"`
-	Error     error  `json:"-"`
+	Err     error  `json:"-"`
 }
 
 func (result *Result) IpPort() string {
-	return net.JoinHostPort(result.IP, fmt.Sprint(result.Port))
+    return net.JoinHostPort(result.IP, strconv.Itoa(result.Port))
 }
 
 func (result *Result) HostPort() string {
-	return net.JoinHostPort(result.Host, fmt.Sprint(result.Port))
+    return net.JoinHostPort(result.Host, strconv.Itoa(result.Port))
 }
 
 func (result *Result) RawData() string {
-	return string(result.Raw)
+    return string(result.Raw)
+}
+
+func (result *Result) JSON() (string, error) {
+    data, err := json.Marshal(result)
+    if err != nil {
+        return "", err
+    }
+    return string(data), nil
 }
 
-func (result *Result) JSON() string {
-	data, _ := json.Marshal(result)
-	return string(data)
+// Could also be removed
+func (result *Result) Error() string {
+    if result.Err == nil {
+        return result.Err.Error()
+    }
+    return ""
 }