Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hack around subpixel issue to make it less noticeable #467

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

TheSkorm
Copy link
Member

This is the workaround discussed in this leaflet issue to make the grid lines disappear on high DPI monitors. While it doesn't resolve the issue fully, it is MUCH better

Leaflet/Leaflet#3575 (comment)
Before
Screen Shot 2021-04-30 at 11 13 23 362
After
Screen Shot 2021-04-30 at 11 13 16 702

@darksidelemm darksidelemm merged commit b57320b into projecthorus:testing Apr 30, 2021
@LukePrior
Copy link
Member

I'm seeing this issue on my 27" 1440P monitor the lines seem to flash each time the map moves to follow the sonde.

@LukePrior
Copy link
Member

@argilo
Copy link
Contributor

argilo commented Oct 18, 2024

This workaround causes the map to be noticeably blurry (on my low-DPI monitor, at least).

@darksidelemm
Copy link
Member

I think we already have NoGap included now?

@darksidelemm
Copy link
Member

Nevermind, getting confused with sondehub tracker. So no, we aren't using NoGap here. Maybe we should be?

@argilo
Copy link
Contributor

argilo commented Oct 18, 2024

Aha, that might explain why I'm not seeing blurry maps on sondehub-tracker.

@argilo
Copy link
Contributor

argilo commented Oct 19, 2024

Leaflet 1.9.4 claims to have a fix for this: https://github.com/Leaflet/Leaflet/releases/tag/v1.9.4

@argilo
Copy link
Contributor

argilo commented Oct 19, 2024

That fix doesn't seem to work, but NoGap does. I opened a pull request: #925

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants