Search for peaks over a wider range #942
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the removal of scan plot data decimation in #939, some peaks are displayed with incorrect amplitude:
This is because the code that searches for the peak amplitude in the bins near the quantized frequency does not search far enough. It only looks from 5 bins down (-4000 Hz) to 4 bins up (+3200 Hz), even though the original peak frequency may be up to 10000/2 = 5000 Hz away.
Here I've solved the problem by calculating the required search radius based on the
quantization
andsearch_step
values. I also fixed the off-by-one in the upper limit. (Python ranges do not include the end value.)