Add support for Cilium 1.17 #184
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
force-pushed
the
deps/cilium-1.17
branch
3 times, most recently
from
4b215ff to
a8d69c6
Compare
simu
force-pushed
the
feat/egress-ip-range-cidr
branch
from
3b3fa23 to
2c44042
Compare
simu
force-pushed
the
deps/cilium-1.17
branch
2 times, most recently
from
4345a8b to
f80c143
Compare
simu
force-pushed
the
feat/egress-ip-range-cidr
branch
from
2c44042 to
cb3b446
Compare
simu
force-pushed
the
deps/cilium-1.17
branch
from
9e27e93 to
31d9b7d
Compare
simu
force-pushed
the
feat/egress-ip-range-cidr
branch
2 times, most recently
from
52be249 to
68cd898
Compare
simu
force-pushed
the
deps/cilium-1.17
branch
2 times, most recently
from
88b0a15 to
6853e72
Compare
simu
force-pushed
the
deps/cilium-1.17
branch
8 times, most recently
from
e969ddf to
569a06c
Compare
simu
force-pushed
the
deps/cilium-1.17
branch
from
569a06c to
9605d8a
Compare
simu
force-pushed
the
deps/cilium-1.17
branch
from
9b480be to
a1ae9fc
Compare
This commit adds a bit of logic which takes the last entry in `hubble.metrics.enabled` for each metrics type (i.e. making the part before the first `|` unique in the entries). By taking the last entry for each type we allow users to customize metrics which are enabled by default through the config hierarchy by simply providing an additional entry for the same metrics type.
With Cilium 1.17 the separate Envoy daemonset is also supported on OpenShift, so we can enable it by default.
The sync hook executes the steps which are documented on docs.isovalent.com for migrating from cilium-ee-olm to clife. After deleting the `ciliumconfigs.cilium.io` CRD, we don't recreate the CRD and config from the pre-sync job, since that's not enough for ArgoCD to then be able to apply the new ciliumconfig resource. As far as we've been able to determine the only way to avoid the ArgoCD sync getting stuck is to delete the `syn-argocd-application-controller-0` pod to clear any conflicting cache entries for `ciliumconfigs.cilium.io`.
simu
force-pushed
the
deps/cilium-1.17
branch
from
a1ae9fc to
9802106
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.
TODO