Add support for configuring arbitrary policy labels on namespace egress policies #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
force-pushed
the
feat/egress-ip-range-cidr
branch
2 times, most recently
from
52be249 to
68cd898
Compare
simu
force-pushed
the
feat/namespace-egress-policy-labels
branch
2 times, most recently
from
2e18f6a to
40a46da
Compare
…ss policies This commit introduces a new field `policy_labels` for entries in `egress_ip_ranges`. In contrast to field `bgp_policy_labels`, providing labels in the new field doesn't modify the behavior of the policy generation.
simu
force-pushed
the
feat/namespace-egress-policy-labels
branch
from
40a46da to
26346d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new field
policy_labelsfor entries inegress_ip_ranges. In contrast to fieldbgp_policy_labels, providing labels in the new field doesn't modify the behavior of the policy generation.Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.