foot templates: remove quotes around color code causing parsing errors #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the latest foot version (1.23.1 as of now), when applying the generated themes under
themes/foot/, errors will be returned complaining that the color code must be in RGB format.This is caused by the single quotes surrounding the color hex codes. After removing the quotes, the themes can be successfully applied when copying to
XDG_CONFIG_HOME/foot/foot.ini.This PR removes the aforementioned singles quotes in the typescript file for theme generation for foot, as well as the generated themes.