-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor: bump support for ansible from v2.16.* to v2.17.* #414
minor: bump support for ansible from v2.16.* to v2.17.* #414
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and the docs are now incorporated into |
5e65002
to
1ec838d
Compare
The GitHub Action workflow failure in PRs like #411 may a solution to this. |
At that time 2.17 was unreleased, but those two are essentially equal, the operator "less than" The reason for the change was due to how we are using the supported versions to do testing in the CI, but it has the same effect for the user. Anyways, thanks for the PR, can you rebase? |
Fix prometheus-community#386 Signed-off-by: Andy Grunwald <[email protected]>
…or Ansible 2.17 Full error: ERROR: tests/integration/molecule.sh:54:1: SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. Signed-off-by: Andy Grunwald <[email protected]>
Signed-off-by: Andy Grunwald <[email protected]>
3290e1b
to
2e51da8
Compare
@gardar Rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to exclude 2.17 from almalinux-8, since 2.17 is not supported on el8 based distros.
You can do so by adding it here:
ansible/.config/molecule/config.yml
Lines 75 to 90 in 15369b7
host_vars: | |
fedora-39: | |
exclude_ansible_vers: | |
- "2.9" | |
- "2.10" | |
- "2.11" | |
fedora-40: | |
exclude_ansible_vers: | |
- "2.9" | |
- "2.10" | |
- "2.11" | |
ubuntu-24.04: | |
exclude_ansible_vers: | |
- "2.9" | |
- "2.10" | |
- "2.11" |
Signed-off-by: Andy Grunwald <[email protected]>
4fcb2a2
to
e0d0aa4
Compare
This has support for Ansible 2.17.* prometheus-community/ansible#414
Context
Fix #386
Last version bump
The last version bump was in 2e0a30d
It is not clear to me, why the version was set down to 2.16.* (from 2.17)
A lot of changes has been between Ansible v2.16.10 and v2.17.3, see ansible/ansible@v2.16.10...v2.17.3
Ansible version
The following ansible version is used with v0.17.1 of the ansible role
prometheus.prometheus
: